From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: [PATCH 1/5] xl: remove needless error checking from calls to xl_fork Date: Wed, 19 Mar 2014 14:28:50 +0000 Message-ID: <1395239334-19579-2-git-send-email-ian.jackson@eu.citrix.com> References: <1395239334-19579-1-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1395239334-19579-1-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xensource.com Cc: Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org xl_fork cannot fail - it exits instead. Signed-off-by: Ian Jackson CC: Ian Campbell --- tools/libxl/xl_cmdimpl.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 8990020..e19b1cf 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -230,10 +230,7 @@ static void autoconnect_vncviewer(uint32_t domid, int autopass) vncviewer_child_report(); pid_t pid = xl_fork(child_vncviewer); - if (pid < 0) { - perror("unable to fork vncviewer"); - return; - } else if (pid > 0) + if (pid) return; postfork(); @@ -2009,10 +2006,7 @@ static void autoconnect_console(libxl_ctx *ctx_ignored, console_child_report(); pid_t pid = xl_fork(child_console); - if (pid < 0) { - perror("unable to fork xenconsole"); - return; - } else if (pid > 0) + if (pid) return; postfork(); -- 1.7.10.4