From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: julien.grall@citrix.com, Ian.Campbell@citrix.com,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [PATCH v5 03/10] xen/arm: set GICH_HCR_UIE if all the LRs are in use
Date: Mon, 24 Mar 2014 18:49:28 +0000 [thread overview]
Message-ID: <1395686975-12649-3-git-send-email-stefano.stabellini@eu.citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1403241841450.8273@kaball.uk.xensource.com>
On return to guest, if there are no free LRs and we still have more
interrupt to inject, set GICH_HCR_UIE so that we are going to receive a
maintenance interrupt when no pending interrupts are present in the LR
registers.
The maintenance interrupt handler won't do anything anymore, but
receiving the interrupt is going to cause gic_inject to be called on
return to guest that is going to clear the old LRs and inject new
interrupts.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Acked-by: Julien Grall <julien.grall@linaro.org>
---
Changes in v5:
- introduce lr_all_full() helper.
Changes in v2:
- disable/enable the GICH_HCR_UIE bit in GICH_HCR;
- only enable GICH_HCR_UIE if this_cpu(lr_mask) == ((1 << nr_lrs) - 1).
---
xen/arch/arm/gic.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
index dbba5d3..a7b29d8 100644
--- a/xen/arch/arm/gic.c
+++ b/xen/arch/arm/gic.c
@@ -57,6 +57,7 @@ static DEFINE_PER_CPU(irq_desc_t[NR_LOCAL_IRQS], local_irq_desc);
static DEFINE_PER_CPU(uint64_t, lr_mask);
static unsigned nr_lrs;
+#define lr_all_full() (this_cpu(lr_mask) == ((1 << nr_lrs) - 1))
/* The GIC mapping of CPU interfaces does not necessarily match the
* logical CPU numbering. Let's use mapping as returned by the GIC
@@ -738,6 +739,11 @@ void gic_inject(void)
vgic_vcpu_inject_irq(current, current->domain->arch.evtchn_irq);
gic_restore_pending_irqs(current);
+
+ if ( !list_empty(¤t->arch.vgic.lr_pending) && lr_all_full() )
+ GICH[GICH_HCR] |= GICH_HCR_UIE;
+ else
+ GICH[GICH_HCR] &= ~GICH_HCR_UIE;
}
int gic_route_irq_to_guest(struct domain *d, const struct dt_irq *irq,
--
1.7.10.4
next prev parent reply other threads:[~2014-03-24 18:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 18:48 [PATCH v5 0/10] remove maintenance interrupts Stefano Stabellini
2014-03-24 18:49 ` [PATCH v5 01/10] xen/arm: no need to set HCR_VI when using the vgic to inject irqs Stefano Stabellini
2014-03-24 18:49 ` [PATCH v5 02/10] xen/arm: remove unused virtual parameter from vgic_vcpu_inject_irq Stefano Stabellini
2014-03-24 18:49 ` Stefano Stabellini [this message]
2014-04-01 11:46 ` [PATCH v5 03/10] xen/arm: set GICH_HCR_UIE if all the LRs are in use Ian Campbell
2014-03-24 18:49 ` [PATCH v5 04/10] xen/arm: support HW interrupts, do not request maintenance_interrupts Stefano Stabellini
2014-04-01 11:56 ` Ian Campbell
2014-04-01 12:13 ` Ian Campbell
2014-04-02 14:59 ` Stefano Stabellini
2014-04-02 15:19 ` Stefano Stabellini
2014-03-24 18:49 ` [PATCH v5 05/10] xen/arm: nr_lrs should be uint8_t Stefano Stabellini
2014-03-25 15:47 ` Julien Grall
2014-04-01 11:59 ` Ian Campbell
2014-04-01 12:12 ` Julien Grall
2014-04-01 12:15 ` Ian Campbell
2014-03-24 18:49 ` [PATCH v5 06/10] xen/arm: keep track of the GICH_LR used for the irq in struct pending_irq Stefano Stabellini
2014-04-01 12:00 ` Ian Campbell
2014-03-24 18:49 ` [PATCH v5 07/10] xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq Stefano Stabellini
2014-04-01 12:00 ` Ian Campbell
2014-03-24 18:49 ` [PATCH v5 08/10] xen/arm: second irq injection while the first irq is still inflight Stefano Stabellini
2014-04-01 12:14 ` Ian Campbell
2014-04-02 15:31 ` Stefano Stabellini
2014-04-02 15:43 ` Ian Campbell
2014-04-06 16:58 ` Stefano Stabellini
2014-04-07 8:48 ` Ian Campbell
2014-03-24 18:49 ` [PATCH v5 09/10] xen/arm: don't protect GICH and lr_queue accesses with gic.lock Stefano Stabellini
2014-03-24 18:49 ` [PATCH v5 10/10] xen/arm: gic_events_need_delivery and irq priorities Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395686975-12649-3-git-send-email-stefano.stabellini@eu.citrix.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).