From: Julien Grall <julien.grall@linaro.org>
To: xen-devel@lists.xenproject.org
Cc: ian.campbell@citrix.com, Julien Grall <julien.grall@linaro.org>,
tim@xen.org, stefano.stabellini@citrix.com,
Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: [PATCH 30/34] xen: Add missing includes on different files
Date: Tue, 25 Mar 2014 16:55:37 +0000 [thread overview]
Message-ID: <1395766541-23979-31-git-send-email-julien.grall@linaro.org> (raw)
In-Reply-To: <1395766541-23979-1-git-send-email-julien.grall@linaro.org>
There is a bunch of functions in xen code which are declared without the
prototypes defined before. This may lead to runtime issue if the propotype
doesn't match the declaration.
Add missing includes where the prototype of theses functions are defined.
This was spotted by -Wmissing-prototypes, which we can't enable because there
is exported function for assembly. I'm not sure if we need to add a prototype
for them.
Signed-off-by: Julien Grall <julien.grall@linaro.org>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@citrix.com>
Cc: Tim Deegan <tim@xen.org>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>
---
xen/arch/arm/hvm.c | 1 +
xen/arch/arm/mm.c | 1 +
xen/arch/arm/shutdown.c | 1 +
xen/arch/arm/smp.c | 1 +
xen/arch/arm/time.c | 1 +
xen/arch/arm/vtimer.c | 1 +
xen/common/event_channel.c | 1 +
xen/common/grant_table.c | 1 +
xen/common/multicall.c | 3 +++
xen/common/sort.c | 1 +
xen/common/tmem.c | 1 +
xen/drivers/video/arm_hdlcd.c | 1 +
xen/xsm/flask/ss/conditional.h | 1 +
13 files changed, 15 insertions(+)
diff --git a/xen/arch/arm/hvm.c b/xen/arch/arm/hvm.c
index 471c4cd..b695b26 100644
--- a/xen/arch/arm/hvm.c
+++ b/xen/arch/arm/hvm.c
@@ -4,6 +4,7 @@
#include <xen/errno.h>
#include <xen/guest_access.h>
#include <xen/sched.h>
+#include <xen/hypercall.h>
#include <xsm/xsm.h>
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index fc58fc6..84b6ccc 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -39,6 +39,7 @@
#include <xen/vmap.h>
#include <xsm/xsm.h>
#include <xen/pfn.h>
+#include <asm/setup.h>
struct domain *dom_xen, *dom_io, *dom_cow;
diff --git a/xen/arch/arm/shutdown.c b/xen/arch/arm/shutdown.c
index adc0529..43eaf47 100644
--- a/xen/arch/arm/shutdown.c
+++ b/xen/arch/arm/shutdown.c
@@ -4,6 +4,7 @@
#include <xen/delay.h>
#include <xen/lib.h>
#include <xen/smp.h>
+#include <xen/shutdown.h>
#include <asm/platform.h>
static void raw_machine_reset(void)
diff --git a/xen/arch/arm/smp.c b/xen/arch/arm/smp.c
index 30203b8..7bb602d 100644
--- a/xen/arch/arm/smp.c
+++ b/xen/arch/arm/smp.c
@@ -1,4 +1,5 @@
#include <xen/config.h>
+#include <xen/smp.h>
#include <asm/system.h>
#include <asm/smp.h>
#include <asm/cpregs.h>
diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c
index 7f4f2b4..3b0feec 100644
--- a/xen/arch/arm/time.c
+++ b/xen/arch/arm/time.c
@@ -29,6 +29,7 @@
#include <xen/time.h>
#include <xen/sched.h>
#include <xen/event.h>
+#include <xen/delay.h>
#include <asm/system.h>
#include <asm/time.h>
#include <asm/gic.h>
diff --git a/xen/arch/arm/vtimer.c b/xen/arch/arm/vtimer.c
index 83f4c0f..6aeae5d 100644
--- a/xen/arch/arm/vtimer.c
+++ b/xen/arch/arm/vtimer.c
@@ -25,6 +25,7 @@
#include <asm/time.h>
#include <asm/gic.h>
#include <asm/regs.h>
+#include "vtimer.h"
static void phys_timer_expired(void *data)
{
diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c
index db952af..e94e37e 100644
--- a/xen/common/event_channel.c
+++ b/xen/common/event_channel.c
@@ -28,6 +28,7 @@
#include <xen/keyhandler.h>
#include <xen/event_fifo.h>
#include <asm/current.h>
+#include <xen/hypercall.h>
#include <public/xen.h>
#include <public/event_channel.h>
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index 107b000..386cdff 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -37,6 +37,7 @@
#include <xen/iommu.h>
#include <xen/paging.h>
#include <xen/keyhandler.h>
+#include <xen/hypercall.h>
#include <xsm/xsm.h>
#include <asm/flushtlb.h>
diff --git a/xen/common/multicall.c b/xen/common/multicall.c
index e66c798..bb7550b 100644
--- a/xen/common/multicall.c
+++ b/xen/common/multicall.c
@@ -6,6 +6,9 @@
#include <xen/types.h>
#include <xen/lib.h>
#include <xen/mm.h>
+#ifndef COMPAT
+#include <xen/hypercall.h>
+#endif
#include <xen/sched.h>
#include <xen/event.h>
#include <xen/multicall.h>
diff --git a/xen/common/sort.c b/xen/common/sort.c
index d96fc2a..7069888 100644
--- a/xen/common/sort.c
+++ b/xen/common/sort.c
@@ -5,6 +5,7 @@
*/
#include <xen/types.h>
+#include <xen/sort.h>
static void u32_swap(void *a, void *b, int size)
{
diff --git a/xen/common/tmem.c b/xen/common/tmem.c
index 5155114..865d154 100644
--- a/xen/common/tmem.c
+++ b/xen/common/tmem.c
@@ -23,6 +23,7 @@
#include <xen/radix-tree.h>
#include <xen/list.h>
#include <xen/init.h>
+#include <xen/hypercall.h>
#define TMEM_SPEC_VERSION 1
diff --git a/xen/drivers/video/arm_hdlcd.c b/xen/drivers/video/arm_hdlcd.c
index 841d0d0..04a3091 100644
--- a/xen/drivers/video/arm_hdlcd.c
+++ b/xen/drivers/video/arm_hdlcd.c
@@ -25,6 +25,7 @@
#include <xen/libfdt/libfdt.h>
#include <xen/init.h>
#include <xen/mm.h>
+#include <xen/video.h>
#include "font.h"
#include "lfb.h"
#include "modelines.h"
diff --git a/xen/xsm/flask/ss/conditional.h b/xen/xsm/flask/ss/conditional.h
index d389ecf..65af76b 100644
--- a/xen/xsm/flask/ss/conditional.h
+++ b/xen/xsm/flask/ss/conditional.h
@@ -13,6 +13,7 @@
#include "avtab.h"
#include "symtab.h"
#include "policydb.h"
+#include "../include/conditional.h"
#define COND_EXPR_MAXDEPTH 10
--
1.7.10.4
next prev parent reply other threads:[~2014-03-25 16:56 UTC|newest]
Thread overview: 152+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 16:55 [PATCH 00/34] Add clang support for ARM and cleanups Julien Grall
2014-03-25 16:55 ` [PATCH 01/34] xen: clang: Disable initializer-overrides warning Julien Grall
2014-03-26 11:51 ` Jan Beulich
2014-03-26 15:00 ` Julien Grall
2014-03-26 15:09 ` Tim Deegan
2014-03-26 15:11 ` Julien Grall
2014-03-25 16:55 ` [PATCH 02/34] xen: clang: Disable built-in assembler Julien Grall
2014-03-26 11:53 ` Jan Beulich
2014-03-26 13:16 ` Tim Deegan
2014-03-26 15:08 ` Julien Grall
2014-03-26 15:30 ` Jan Beulich
2014-03-27 18:01 ` Tim Deegan
2014-03-28 8:14 ` Jan Beulich
2014-03-28 11:28 ` Tim Deegan
2014-03-28 11:39 ` Jan Beulich
2014-04-03 16:07 ` [PATCH v2] asm-offsets: encode magic asm-offset runes as strings Tim Deegan
2014-04-03 16:25 ` Ian Campbell
2014-04-04 7:11 ` Jan Beulich
2014-04-23 13:17 ` Julien Grall
2014-04-24 10:45 ` Tim Deegan
2014-04-24 11:29 ` Julien Grall
2014-03-29 22:55 ` [PATCH 02/34] xen: clang: Disable built-in assembler Julien Grall
2014-03-31 8:58 ` Jan Beulich
2014-04-01 13:11 ` Ian Campbell
2014-04-01 14:50 ` Julien Grall
2014-04-01 15:28 ` Ian Campbell
2014-04-01 15:52 ` Julien Grall
2014-03-25 16:55 ` [PATCH 03/34] xen: clang: Support correctly cross-compile Julien Grall
2014-03-25 16:55 ` [PATCH 04/34] xen/compiler: Introduce always_unused define Julien Grall
2014-03-25 17:34 ` Stefano Stabellini
2014-03-25 17:56 ` Julien Grall
2014-03-25 16:55 ` [PATCH 05/34] xen/xsm: flask: Remove unused function avc_sidcmp Julien Grall
2014-03-25 17:36 ` Daniel De Graaf
2014-03-26 11:57 ` Jan Beulich
2014-03-26 16:11 ` Julien Grall
2014-03-26 16:42 ` Jan Beulich
2014-03-26 17:06 ` Julien Grall
2014-03-26 17:30 ` Julien Grall
2014-03-25 16:55 ` [PATCH 06/34] xen/x86: shadow: sh_next_page is only used when GUEST_PAGING_LEVELS = 2 Julien Grall
2014-03-25 16:55 ` [PATCH 07/34] xen/common: sched_sedf: Remove unused functions Julien Grall
2014-03-25 17:03 ` George Dunlap
2014-03-25 16:55 ` [PATCH 08/34] xen/common: rcupdate: Remove unused function rcu_batch_after Julien Grall
2014-03-25 16:55 ` [PATCH 09/34] xen/common: tmem: Remove dumb check in do_tmem_destroy_pool Julien Grall
2014-03-25 18:05 ` Andrew Cooper
2014-03-25 18:18 ` Julien Grall
2014-04-03 18:06 ` Konrad Rzeszutek Wilk
2014-05-22 16:01 ` [PATCH 09/34] xen/common: tmem: Remove dumb check in do_tmem_destroy_pool [and 2 more messages] Ian Jackson
2014-05-23 6:08 ` Jan Beulich
2014-05-23 10:23 ` Ian Jackson
2014-05-23 10:47 ` Jan Beulich
2014-03-25 16:55 ` [PATCH 10/34] xen/crypto: rijndael: Fix compilation with Clang 3.5 Julien Grall
2014-04-01 15:54 ` Keir Fraser
2014-03-25 16:55 ` [PATCH 11/34] xen/arm: Introduce __builtin_stack_pointer Julien Grall
2014-03-25 17:18 ` Ian Campbell
2014-03-25 18:01 ` Julien Grall
2014-03-26 10:31 ` Ian Campbell
2014-03-26 10:38 ` Julien Grall
2014-03-26 10:42 ` Ian Campbell
2014-03-25 16:55 ` [PATCH 12/34] xen/arm: psci: Don't need to check if vcpuid is negative Julien Grall
2014-03-27 16:42 ` Ian Campbell
2014-03-25 16:55 ` [PATCH 13/34] xen/arm: gic: Introduce GIC_SGI_MAX Julien Grall
2014-03-25 18:19 ` Stefano Stabellini
2014-03-25 23:23 ` Julien Grall
2014-03-26 9:03 ` Ian Campbell
2014-03-26 9:41 ` Julien Grall
2014-03-26 10:21 ` Ian Campbell
2014-03-26 9:57 ` Julien Grall
2014-03-26 14:24 ` Stefano Stabellini
2014-03-25 16:55 ` [PATCH 14/34] xen/arm: mm: Mark check_memory_layout_alignment_constraints as unused Julien Grall
2014-03-27 16:42 ` Ian Campbell
2014-03-25 16:55 ` [PATCH 15/34] xen/arm: traps: Mark check_stack_alignment_constraints " Julien Grall
2014-03-27 16:43 ` Ian Campbell
2014-03-25 16:55 ` [PATCH 16/34] xen/arm: Guard correctly asm-arm/platforms/midway.h Julien Grall
2014-03-27 16:43 ` Ian Campbell
2014-03-25 16:55 ` [PATCH 17/34] xen/arm: Guard correctly asm-arm/platform/omap5.h Julien Grall
2014-03-27 16:44 ` Ian Campbell
2014-03-27 16:52 ` Julien Grall
2014-03-27 17:06 ` Ian Campbell
2014-03-25 16:55 ` [PATCH 18/34] xen/arm: omap5: Correctly constify platform compatibility list Julien Grall
2014-03-27 17:03 ` Ian Campbell
2014-03-25 16:55 ` [PATCH 19/34] xen/arm: Provide eabi wrapper for __aeabi_mem* functions Julien Grall
2014-03-25 17:25 ` Ian Campbell
2014-03-25 18:12 ` Julien Grall
2014-03-26 10:39 ` Ian Campbell
2014-03-26 15:38 ` Julien Grall
2014-03-26 15:46 ` Julien Grall
2014-03-26 15:47 ` Ian Campbell
2014-03-26 16:01 ` Julien Grall
2014-03-26 16:11 ` Ian Campbell
2014-03-26 16:16 ` Julien Grall
2014-03-26 16:22 ` Tim Deegan
2014-03-26 16:39 ` Julien Grall
2014-03-26 16:42 ` Ian Campbell
2014-03-26 16:46 ` Tim Deegan
2014-03-26 16:52 ` Julien Grall
2014-03-25 16:55 ` [PATCH 20/34] xen/common: cpupool: cpupool_unassign_cpu is only used internally Julien Grall
2014-03-31 5:02 ` Juergen Gross
2014-03-25 16:55 ` [PATCH 21/34] xen/common: domctl: Some functions are " Julien Grall
2014-04-01 17:40 ` Keir Fraser
2014-03-25 16:55 ` [PATCH 22/34] xen/common: tmem: " Julien Grall
2014-03-25 16:55 ` [PATCH 23/34] xen/sched: credit2: " Julien Grall
2014-03-25 17:03 ` George Dunlap
2014-03-25 16:55 ` [PATCH 24/34] xen/arm: setup: setup_cache is " Julien Grall
2014-03-27 17:07 ` Ian Campbell
2014-03-28 17:17 ` Julien Grall
2014-03-25 16:55 ` [PATCH 25/34] xen/arm: traps: show_stack " Julien Grall
2014-03-27 17:08 ` Ian Campbell
2014-03-25 16:55 ` [PATCH 26/34] xen/arm: traps: Drop dump_guest_s1_walk Julien Grall
2014-03-27 17:09 ` Ian Campbell
2014-04-01 16:59 ` Julien Grall
2014-04-02 8:38 ` Ian Campbell
2014-03-25 16:55 ` [PATCH 27/34] xen/arm: time: move ticks_to_ns and ns_to_ticks in asm/time.h Julien Grall
2014-03-27 17:11 ` Ian Campbell
2014-03-25 16:55 ` [PATCH 28/34] xen/xsm: flask: flask_disable is only used internally Julien Grall
2014-03-25 17:36 ` Daniel De Graaf
2014-03-25 16:55 ` [PATCH 29/34] xen/xsm: flask: ss: remove unused function determine_oocontext Julien Grall
2014-03-25 17:37 ` Daniel De Graaf
2014-03-25 16:55 ` Julien Grall [this message]
2014-03-25 17:38 ` [PATCH 30/34] xen: Add missing includes on different files Daniel De Graaf
2014-03-26 12:57 ` Jan Beulich
2014-03-26 17:41 ` Julien Grall
2014-03-27 7:57 ` Jan Beulich
2014-04-09 16:06 ` Julien Grall
2014-04-09 16:17 ` Jan Beulich
2014-04-09 16:40 ` Julien Grall
2014-03-27 17:11 ` Ian Campbell
2014-03-27 17:30 ` Julien Grall
2014-03-27 17:39 ` Ian Campbell
2014-03-27 17:47 ` Julien Grall
2014-03-28 9:59 ` Ian Campbell
2014-04-01 17:58 ` Julien Grall
2014-04-02 8:45 ` Ian Campbell
2014-03-25 16:55 ` [PATCH 31/34] tools: Disable ignored-attributes warning when compiling with clang Julien Grall
2014-03-27 17:14 ` Ian Campbell
2014-03-27 17:49 ` Julien Grall
2014-09-13 18:42 ` [PATCH] clang: sizeof(type) must not have __attribute__(aligned) Marcin Cieslak
2014-09-16 16:21 ` Ian Campbell
2014-09-16 18:26 ` Julien Grall
2014-09-16 18:32 ` Ian Campbell
2014-09-17 10:50 ` Jan Beulich
2014-09-17 21:18 ` Julien Grall
2014-03-25 16:55 ` [PATCH 32/34] tools/libxl: list_domains: shutdown is typed unsigned Julien Grall
2014-03-25 18:22 ` Andrew Cooper
2014-03-27 17:15 ` Ian Campbell
2014-03-25 16:55 ` [PATCH 33/34] tools/libxl: libxl__json_object_to_yajl_gen should return yajl_gen_status Julien Grall
2014-03-25 17:28 ` Ian Campbell
2014-03-27 12:37 ` Julien Grall
2014-03-27 17:16 ` [PATCH 33/34] tools/libxl: libxl__json_object_to_yajl_gen should Ian Campbell
2014-03-25 16:55 ` [PATCH 34/34] DO NOT APPLY xen/common: kernel: Workaround clang 3.5 Julien Grall
2014-03-25 18:22 ` [PATCH 00/34] Add clang support for ARM and cleanups Stefano Stabellini
2014-03-25 23:26 ` Julien Grall
2014-03-27 16:34 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395766541-23979-31-git-send-email-julien.grall@linaro.org \
--to=julien.grall@linaro.org \
--cc=dgdegra@tycho.nsa.gov \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).