From: Wei Liu <wei.liu2@citrix.com>
To: xen-devel@lists.xen.org
Cc: Wei Liu <wei.liu2@citrix.com>,
ian.jackson@eu.citrix.com, ian.campbell@citrix.com
Subject: [PATCH v5 09/13] TestSupport.pm: introduce iso_copy_content_from_image
Date: Wed, 2 Apr 2014 20:29:42 +0100 [thread overview]
Message-ID: <1396466986-21198-10-git-send-email-wei.liu2@citrix.com> (raw)
In-Reply-To: <1396466986-21198-1-git-send-email-wei.liu2@citrix.com>
... which returns a string of commands to pass into target_cmd_root.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
Osstest/TestSupport.pm | 14 ++++++++++++++
ts-redhat-install | 10 +---------
2 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index 82d3baa..b74422b 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -104,6 +104,7 @@ BEGIN {
iso_create_xorriso
iso_create_empty
iso_gen_flags_basic
+ iso_copy_content_from_image
guest_editconfig_nocd
);
%EXPORT_TAGS = ( );
@@ -1929,6 +1930,19 @@ sub iso_gen_flags_basic() {
-boot-info-table);
}
+sub iso_copy_content_from_image($$) {
+ my ($gho,$newiso) = @_;
+ return <<"END";
+ set -ex
+ umount /mnt ||:
+ rm -rf $newiso
+ mount -o loop -r $gho->{Rimage} /mnt
+ mkdir $newiso
+ cp -a /mnt/. $newiso/.
+ umount /mnt
+END
+}
+
sub guest_editconfig_nocd ($$) {
my ($gho,$emptyiso) = @_;
guest_editconfig($gho->{Host}, $gho, sub {
diff --git a/ts-redhat-install b/ts-redhat-install
index 01e3615..924abac 100755
--- a/ts-redhat-install
+++ b/ts-redhat-install
@@ -130,15 +130,7 @@ sub prep () {
more_prepareguest_hvm($ho,$gho, $ram_mb, $disk_mb,
OnReboot => 'preserve',
PostImageHook => sub {
- target_cmd_root($ho, <<END, $isotimeout);
- set -ex
- umount /mnt ||:
- rm -rf $newiso
- mount -o loop -r $gho->{Rimage} /mnt
- mkdir $newiso
- cp -a /mnt/. $newiso/.
- umount /mnt
-END
+ target_cmd_root($ho, copy_iso_content_to_dir($gho,$newiso), $isotimeout);
target_editfile_root($ho, "$newiso/isolinux/isolinux.cfg", sub {
while (<EI>) {
if (m/^\s+append/) {
--
1.7.10.4
next prev parent reply other threads:[~2014-04-02 19:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 19:29 [PATCH v5 00/13] OSSTest: OVMF test job Wei Liu
2014-04-02 19:29 ` [PATCH v5 01/13] standalone-reset: fix typo Wei Liu
2014-04-03 14:16 ` Ian Jackson
2014-04-02 19:29 ` [PATCH v5 02/13] TestSupport.pm: add bios option to guest config file Wei Liu
2014-04-02 19:29 ` [PATCH v5 03/13] TestSupport.pm: introduce iso_create_xorriso Wei Liu
2014-04-03 14:17 ` Ian Jackson
2014-04-02 19:29 ` [PATCH v5 04/13] TestSupport.pm: move rewrite_config_nocd to support library Wei Liu
2014-04-03 14:18 ` Ian Jackson
2014-04-02 19:29 ` [PATCH v5 05/13] TestSupport.pm: introduce guest_create Wei Liu
2014-04-02 19:29 ` [PATCH v5 06/13] ts-redhat-install: use $flight, $job and $gn when creating iso Wei Liu
2014-04-02 19:29 ` [PATCH v5 07/13] TestSupport.pm: introduce iso_create_empty Wei Liu
2014-04-03 14:18 ` Ian Jackson
2014-04-02 19:29 ` [PATCH v5 08/13] TestSupport.pm: introduce iso_gen_flags_basic Wei Liu
2014-04-02 19:29 ` Wei Liu [this message]
2014-04-02 19:29 ` [PATCH v5 10/13] Debian.pm: factor out preseed_base Wei Liu
2014-04-02 19:29 ` [PATCH v5 11/13] Introduce ts-debian-hvm-install Wei Liu
2014-04-03 14:19 ` Ian Jackson
2014-04-02 19:29 ` [PATCH v5 12/13] sg-run-job: OVMF job Wei Liu
2014-04-02 19:29 ` [PATCH v5 13/13] make-flight: OVMF test flight Wei Liu
2014-04-03 14:20 ` Ian Jackson
2014-04-03 14:27 ` Wei Liu
2014-04-03 14:28 ` Wei Liu
2014-04-03 15:17 ` Ian Jackson
2014-04-03 16:19 ` Wei Liu
2014-04-03 16:31 ` Ian Jackson
2014-04-03 14:34 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396466986-21198-10-git-send-email-wei.liu2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).