From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xen.org
Cc: julien.grall@linaro.org, tim@xen.org,
Ian Campbell <ian.campbell@citrix.com>,
stefano.stabellini@eu.citrix.com
Subject: [PATCH v4 6/6] xen: arm: relax barriers when flushing caches
Date: Thu, 3 Apr 2014 09:59:45 +0100 [thread overview]
Message-ID: <1396515585-5737-6-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1396515560.4211.33.camel@kazak.uk.xensource.com>
We only need an inner shareable barrier here.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
v4: new patch
---
xen/include/asm-arm/page.h | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/xen/include/asm-arm/page.h b/xen/include/asm-arm/page.h
index a96e40b..b4d5597 100644
--- a/xen/include/asm-arm/page.h
+++ b/xen/include/asm-arm/page.h
@@ -263,20 +263,20 @@ extern size_t cacheline_bytes;
static inline void clean_xen_dcache_va_range(void *p, unsigned long size)
{
void *end;
- dsb(sy); /* So the CPU issues all writes to the range */
+ dsb(ish); /* So the CPU issues all writes to the range */
for ( end = p + size; p < end; p += cacheline_bytes )
asm volatile (__clean_xen_dcache_one(0) : : "r" (p));
- dsb(sy); /* So we know the flushes happen before continuing */
+ dsb(ish); /* So we know the flushes happen before continuing */
}
static inline void clean_and_invalidate_xen_dcache_va_range
(void *p, unsigned long size)
{
void *end;
- dsb(sy); /* So the CPU issues all writes to the range */
+ dsb(ish); /* So the CPU issues all writes to the range */
for ( end = p + size; p < end; p += cacheline_bytes )
asm volatile (__clean_and_invalidate_xen_dcache_one(0) : : "r" (p));
- dsb(sy); /* So we know the flushes happen before continuing */
+ dsb(ish); /* So we know the flushes happen before continuing */
}
/* Macros for flushing a single small item. The predicate is always
@@ -288,9 +288,9 @@ static inline void clean_and_invalidate_xen_dcache_va_range
clean_xen_dcache_va_range(_p, sizeof(x)); \
else \
asm volatile ( \
- "dsb sy;" /* Finish all earlier writes */ \
+ "dsb ish;" /* Finish all earlier writes */ \
__clean_xen_dcache_one(0) \
- "dsb sy;" /* Finish flush before continuing */ \
+ "dsb ish;" /* Finish flush before continuing */ \
: : "r" (_p), "m" (*_p)); \
} while (0)
@@ -300,9 +300,9 @@ static inline void clean_and_invalidate_xen_dcache_va_range
clean_and_invalidate_xen_dcache_va_range(_p, sizeof(x)); \
else \
asm volatile ( \
- "dsb sy;" /* Finish all earlier writes */ \
+ "dsb ish;" /* Finish all earlier writes */ \
__clean_and_invalidate_xen_dcache_one(0) \
- "dsb sy;" /* Finish flush before continuing */ \
+ "dsb ish;" /* Finish flush before continuing */ \
: : "r" (_p), "m" (*_p)); \
} while (0)
--
1.7.10.4
next prev parent reply other threads:[~2014-04-03 8:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 8:59 [PATCH v4 0/6 ] xen: arm: smp & tlb cleanups Ian Campbell
2014-04-03 8:59 ` [PATCH v4 1/6] xen: arm: clarify naming of the Xen TLB flushing functions Ian Campbell
2014-04-03 8:59 ` [PATCH v4 2/6] xen: arm: consolidate body of flush_xen_data_tlb_range_va_local Ian Campbell
2014-04-03 10:56 ` Julien Grall
2014-04-03 8:59 ` [PATCH v4 3/6] xen: arm: flush TLB on all CPUs when setting or clearing fixmaps Ian Campbell
2014-04-03 10:58 ` Julien Grall
2014-04-03 8:59 ` [PATCH v4 4/6] xen: arm32: don't force the compiler to allocate a dummy register Ian Campbell
2014-04-03 8:59 ` [PATCH v4 5/6] xen: arm: relax barriers in tlb flushes Ian Campbell
2014-04-03 11:12 ` Julien Grall
2014-04-03 12:18 ` Ian Campbell
2014-04-03 12:42 ` Julien Grall
2014-04-03 8:59 ` Ian Campbell [this message]
2014-04-03 12:55 ` [PATCH v4 6/6] xen: arm: relax barriers when flushing caches Tim Deegan
2014-04-03 13:00 ` Ian Campbell
2014-04-03 16:29 ` [PATCH v4 0/6 ] xen: arm: smp & tlb cleanups Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396515585-5737-6-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).