xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Don Slutz <dslutz@verizon.com>
To: xen-devel@lists.xen.org
Cc: Ian Campbell <ian.campbell@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	George Dunlap <george.dunlap@eu.citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Don Slutz <dslutz@verizon.com>, Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v10 12/19] xenctx: Add error output if --all-vcpus (-C) and [VCPU] are both specified.
Date: Thu,  3 Apr 2014 15:07:02 -0400	[thread overview]
Message-ID: <1396552029-21318-13-git-send-email-dslutz@verizon.com> (raw)
In-Reply-To: <1396552029-21318-1-git-send-email-dslutz@verizon.com>

To do this correctly the program name must be remembered since argv
is adjusted at the end of option parsing.

Switch all uses of argv[0] to prog.

Signed-off-by: Don Slutz <dslutz@verizon.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
---
 tools/xentrace/xenctx.c | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/tools/xentrace/xenctx.c b/tools/xentrace/xenctx.c
index 9aa55e2..aa0c9d1 100644
--- a/tools/xentrace/xenctx.c
+++ b/tools/xentrace/xenctx.c
@@ -1001,6 +1001,7 @@ int main(int argc, char **argv)
 {
     int ch;
     int ret;
+    const char *prog = argv[0];
     static const char *sopts = "fs:hak:SCn:b:l:Dt"
 #ifndef NO_TRANSLATION
         "m:"
@@ -1053,7 +1054,7 @@ int main(int argc, char **argv)
             {
                 fprintf(stderr,
                         "%s: Unsupported value(%d) for --display-stack-pages '%s'. Needs to be >= 1\n",
-                        argv[0], xenctx.nr_stack_pages, optarg);
+                        prog, xenctx.nr_stack_pages, optarg);
                 exit(-1);
             }
             break;
@@ -1070,7 +1071,7 @@ int main(int argc, char **argv)
             {
                 fprintf(stderr,
                         "%s: Unsupported value for --bytes-per-line '%s'. Needs to be 4 <= %d <= %d\n",
-                        argv[0], optarg, xenctx.bytes_per_line,
+                        prog, optarg, xenctx.bytes_per_line,
                         MAX_BYTES_PER_LINE);
                 exit(-1);
             }
@@ -1085,7 +1086,7 @@ int main(int argc, char **argv)
             {
                 fprintf(stderr,
                         "%s: Unsupported value(%d) for --lines '%s'. Needs to be >= 0, < %d\n",
-                        argv[0], xenctx.lines, optarg, INT_MAX);
+                        prog, xenctx.lines, optarg, INT_MAX);
                 exit(-1);
             }
             break;
@@ -1107,7 +1108,7 @@ int main(int argc, char **argv)
             usage();
             exit(-1);
         case '?':
-            fprintf(stderr, "%s --help for more options\n", argv[0]);
+            fprintf(stderr, "%s --help for more options\n", prog);
             exit(-1);
         }
     }
@@ -1125,8 +1126,17 @@ int main(int argc, char **argv)
             exit(-1);
     }
 
-    if (argc == 2)
+    if ( argc == 2 )
+    {
+        if ( xenctx.all_vcpus )
+        {
+            fprintf(stderr,
+                    "%s: both --all-vcpus and [VCPU] is not supported\n",
+                    prog);
+            exit(-1);
+        }
         vcpu = atoi(argv[1]);
+    }
 
     if (symbol_table)
         read_symbol_table(symbol_table);
-- 
1.8.4

  parent reply	other threads:[~2014-04-03 19:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03 19:06 [PATCH v10 00/19] xenctx: Many changes Don Slutz
2014-04-03 19:06 ` [PATCH v10 01/19] xenctx: Correct FMT_??B_WORD for arm64 Don Slutz
2014-04-03 20:53   ` Don Slutz
2014-04-04  8:46     ` Ian Campbell
2014-04-03 19:06 ` [PATCH v10 02/19] xenctx: clean up usage output Don Slutz
2014-04-03 19:06 ` [PATCH v10 03/19] xenctx: Clean up stack trace when hypercall_page not in symbol table Don Slutz
2014-04-03 19:06 ` [PATCH v10 04/19] xenctx: Add -n (--display-stack-pages) option to output larger stack Don Slutz
2014-04-03 19:06 ` [PATCH v10 05/19] xenctx: Add command line options -b (--bytes-per-line) and -l (--lines) Don Slutz
2014-04-03 19:06 ` [PATCH v10 06/19] xenctx: Add command line option -D (--decode-as-ascii) Don Slutz
2014-04-03 19:06 ` [PATCH v10 07/19] xenctx: Add command line option -t (--tag-stack-dump) Don Slutz
2014-04-03 19:06 ` [PATCH v10 08/19] xenctx: Change print_symbol to do the space before Don Slutz
2014-04-03 19:06 ` [PATCH v10 09/19] xenctx: More info on failed to map page Don Slutz
2014-04-03 19:07 ` [PATCH v10 10/19] xenctx: Add output of stack address to Call and Stack Trace Don Slutz
2014-04-03 19:07 ` [PATCH v10 11/19] xenctx: Add -m (--memory) <maddr> option to dump memory at maddr Don Slutz
2014-04-03 19:07 ` Don Slutz [this message]
2014-04-03 19:07 ` [PATCH v10 13/19] xenctx: Add -d (--dump-as-stack) <daddr> option to dump memory at daddr as a stack Don Slutz
2014-04-03 19:07 ` [PATCH v10 14/19] xenctx: change is_kernel_text() into kernel_addr() Don Slutz
2014-04-03 19:07 ` [PATCH v10 15/19] xenctx: Add conversion of more registers to symbols Don Slutz
2014-04-03 19:07 ` [PATCH v10 16/19] xenctx: Add output of vcpu value and state for --all-vcpus Don Slutz
2014-04-03 19:07 ` [PATCH v10 17/19] xenctx: Fix handling of !guest_protected_mode Don Slutz
2014-04-03 19:07 ` [PATCH v10 18/19] xenctx: Add 16 bit output Don Slutz
2014-04-03 19:07 ` [PATCH v10 19/19] xenctx: Fix print_ctx_32on64's print_special call Don Slutz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396552029-21318-13-git-send-email-dslutz@verizon.com \
    --to=dslutz@verizon.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).