From: vijay.kilari@gmail.com
To: Ian.Campbell@citrix.com, julien.grall@linaro.org,
stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com,
xen-devel@lists.xen.org
Cc: Prasun.Kapoor@caviumnetworks.com,
Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>,
vijay.kilari@gmail.com
Subject: [PATCH v2 01/15] xen/arm: register mmio handler at runtime
Date: Fri, 4 Apr 2014 17:26:19 +0530 [thread overview]
Message-ID: <1396612593-443-2-git-send-email-vijay.kilari@gmail.com> (raw)
In-Reply-To: <1396612593-443-1-git-send-email-vijay.kilari@gmail.com>
From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
register mmio handlers at runtime and make
mmio handlers domain specific.
Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
---
xen/arch/arm/domain.c | 4 ++++
xen/arch/arm/io.c | 34 +++++++++++++++++++++++-----------
xen/arch/arm/io.h | 8 ++++++--
xen/arch/arm/vgic.c | 4 +++-
xen/arch/arm/vuart.c | 6 +++++-
xen/include/asm-arm/domain.h | 1 +
6 files changed, 42 insertions(+), 15 deletions(-)
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index f26b77b..e2f0cc4 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -34,6 +34,7 @@
#include <asm/platform.h>
#include "vtimer.h"
#include "vuart.h"
+#include "io.h"
DEFINE_PER_CPU(struct vcpu *, curr_vcpu);
@@ -521,6 +522,9 @@ int arch_domain_create(struct domain *d, unsigned int domcr_flags)
share_xen_page_with_guest(
virt_to_page(d->shared_info), d, XENSHARE_writable);
+ if ( (d->arch.io_handlers = xmalloc(struct io_handler)) == NULL )
+ goto fail;
+
if ( (rc = p2m_alloc_table(d)) != 0 )
goto fail;
diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
index a6db00b..d6231d0 100644
--- a/xen/arch/arm/io.c
+++ b/xen/arch/arm/io.c
@@ -17,31 +17,43 @@
*/
#include <xen/config.h>
+#include <xen/init.h>
+#include <xen/kernel.h>
#include <xen/lib.h>
+#include <xen/spinlock.h>
#include <asm/current.h>
+#include <xen/sched.h>
#include "io.h"
-static const struct mmio_handler *const mmio_handlers[] =
-{
- &vgic_distr_mmio_handler,
- &vuart_mmio_handler,
-};
-#define MMIO_HANDLER_NR ARRAY_SIZE(mmio_handlers)
+static DEFINE_SPINLOCK(handler_lock);
int handle_mmio(mmio_info_t *info)
{
struct vcpu *v = current;
int i;
+ struct io_handler *mmio_handle = v->domain->arch.io_handlers;
- for ( i = 0; i < MMIO_HANDLER_NR; i++ )
- if ( mmio_handlers[i]->check_handler(v, info->gpa) )
+ for ( i = 0; i < mmio_handle->num_entries; i++ )
+ {
+ if ( mmio_handle->mmio_handlers[i]->check_handler(v, info->gpa) )
return info->dabt.write ?
- mmio_handlers[i]->write_handler(v, info) :
- mmio_handlers[i]->read_handler(v, info);
-
+ mmio_handle->mmio_handlers[i]->write_handler(v, info) :
+ mmio_handle->mmio_handlers[i]->read_handler(v, info);
+ }
return 0;
}
+
+void register_mmio_handler(struct domain *d, struct mmio_handler * handle)
+{
+ unsigned long flags;
+ struct io_handler *handler = d->arch.io_handlers;
+ BUG_ON(handler->num_entries >= MAX_IO_HANDLER);
+
+ spin_lock_irqsave(&handler_lock, flags);
+ handler->mmio_handlers[handler->num_entries++] = handle;
+ spin_unlock_irqrestore(&handler_lock, flags);
+}
/*
* Local variables:
* mode: C
diff --git a/xen/arch/arm/io.h b/xen/arch/arm/io.h
index 8d252c0..5fc1660 100644
--- a/xen/arch/arm/io.h
+++ b/xen/arch/arm/io.h
@@ -40,10 +40,14 @@ struct mmio_handler {
mmio_write_t write_handler;
};
-extern const struct mmio_handler vgic_distr_mmio_handler;
-extern const struct mmio_handler vuart_mmio_handler;
+#define MAX_IO_HANDLER 16
+struct io_handler {
+ int num_entries;
+ struct mmio_handler *mmio_handlers[MAX_IO_HANDLER];
+};
extern int handle_mmio(mmio_info_t *info);
+void register_mmio_handler(struct domain *d, struct mmio_handler * handle);
#endif
diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
index 8616534..77b561e 100644
--- a/xen/arch/arm/vgic.c
+++ b/xen/arch/arm/vgic.c
@@ -35,6 +35,7 @@
/* Number of ranks of interrupt registers for a domain */
#define DOMAIN_NR_RANKS(d) (((d)->arch.vgic.nr_lines+31)/32)
+static struct mmio_handler vgic_distr_mmio_handler;
/*
* Rank containing GICD_<FOO><n> for GICD_<FOO> with
* <b>-bits-per-interrupt
@@ -107,6 +108,7 @@ int domain_vgic_init(struct domain *d)
}
for (i=0; i<DOMAIN_NR_RANKS(d); i++)
spin_lock_init(&d->arch.vgic.shared_irqs[i].lock);
+ register_mmio_handler(d, &vgic_distr_mmio_handler);
return 0;
}
@@ -673,7 +675,7 @@ static int vgic_distr_mmio_check(struct vcpu *v, paddr_t addr)
return (addr >= (d->arch.vgic.dbase)) && (addr < (d->arch.vgic.dbase + PAGE_SIZE));
}
-const struct mmio_handler vgic_distr_mmio_handler = {
+static struct mmio_handler vgic_distr_mmio_handler = {
.check_handler = vgic_distr_mmio_check,
.read_handler = vgic_distr_mmio_read,
.write_handler = vgic_distr_mmio_write,
diff --git a/xen/arch/arm/vuart.c b/xen/arch/arm/vuart.c
index b9d3ced..96df6b3 100644
--- a/xen/arch/arm/vuart.c
+++ b/xen/arch/arm/vuart.c
@@ -44,6 +44,8 @@
#define domain_has_vuart(d) ((d)->arch.vuart.info != NULL)
+static struct mmio_handler vuart_mmio_handler;
+
int domain_vuart_init(struct domain *d)
{
ASSERT( !d->domain_id );
@@ -59,6 +61,8 @@ int domain_vuart_init(struct domain *d)
if ( !d->arch.vuart.buf )
return -ENOMEM;
+ register_mmio_handler(d, &vuart_mmio_handler);
+
return 0;
}
@@ -133,7 +137,7 @@ static int vuart_mmio_write(struct vcpu *v, mmio_info_t *info)
return 1;
}
-const struct mmio_handler vuart_mmio_handler = {
+static struct mmio_handler vuart_mmio_handler = {
.check_handler = vuart_mmio_check,
.read_handler = vuart_mmio_read,
.write_handler = vuart_mmio_write,
diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
index 50b9b54..23dac85 100644
--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -116,6 +116,7 @@ struct arch_domain
struct hvm_domain hvm_domain;
xen_pfn_t *grant_table_gpfn;
+ struct io_handler *io_handlers;
/* Continuable domain_relinquish_resources(). */
enum {
RELMEM_not_started,
--
1.7.9.5
next prev parent reply other threads:[~2014-04-04 11:56 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 11:56 [PATCH v2 00/15] xen/arm: Add GICv3 support vijay.kilari
2014-04-04 11:56 ` vijay.kilari [this message]
2014-04-04 12:18 ` [PATCH v2 01/15] xen/arm: register mmio handler at runtime Julien Grall
2014-04-04 12:30 ` Vijay Kilari
2014-04-04 12:42 ` Ian Campbell
2014-04-04 12:54 ` Julien Grall
2014-04-04 12:59 ` Ian Campbell
2014-04-04 13:06 ` Julien Grall
2014-04-04 12:59 ` Julien Grall
2014-04-08 4:47 ` Vijay Kilari
2014-04-08 10:17 ` Julien Grall
2014-04-08 10:34 ` Vijay Kilari
2014-04-08 10:51 ` Julien Grall
2014-04-08 11:41 ` Vijay Kilari
2014-04-08 12:29 ` Ian Campbell
2014-04-04 15:24 ` Vijay Kilari
2014-04-04 15:27 ` Julien Grall
2014-04-08 6:35 ` Vijay Kilari
2014-04-08 10:25 ` Julien Grall
2014-04-09 15:34 ` Ian Campbell
2014-04-04 11:56 ` [PATCH v2 02/15] xen/arm: move vgic rank data to gic header file vijay.kilari
2014-04-04 13:16 ` Julien Grall
2014-04-04 15:27 ` Vijay Kilari
2014-04-04 11:56 ` [PATCH v2 03/15] arm/xen: move gic save and restore registers to gic driver vijay.kilari
2014-04-04 13:23 ` Julien Grall
2014-04-09 16:51 ` Ian Campbell
2014-04-10 4:50 ` Vijay Kilari
2014-04-10 8:32 ` Ian Campbell
2014-04-04 11:56 ` [PATCH v2 04/15] xen/arm: move gic definitions to seperate file vijay.kilari
2014-04-04 13:27 ` Julien Grall
2014-04-04 15:29 ` Vijay Kilari
2014-04-04 15:37 ` Julien Grall
2014-04-09 15:41 ` Ian Campbell
2014-04-04 11:56 ` [PATCH v2 05/15] xen/arm: segregate GIC low level functionality vijay.kilari
2014-04-04 13:55 ` Julien Grall
2014-04-09 7:43 ` Vijay Kilari
2014-04-09 8:36 ` Julien Grall
2014-04-09 15:55 ` Ian Campbell
2014-04-09 17:00 ` Ian Campbell
2014-04-09 17:07 ` Julien Grall
2014-04-10 5:24 ` Vijay Kilari
2014-04-10 8:59 ` Ian Campbell
2014-04-09 8:50 ` Julien Grall
2014-04-09 11:34 ` Vijay Kilari
2014-04-09 12:10 ` Julien Grall
2014-04-09 15:54 ` Ian Campbell
2014-04-04 11:56 ` [PATCH v2 06/15] xen/arm: move gic lock out of gic data structure vijay.kilari
2014-04-10 8:52 ` Ian Campbell
2014-04-10 9:24 ` Vijay Kilari
2014-04-10 10:02 ` Ian Campbell
2014-04-10 10:12 ` Vijay Kilari
2014-04-10 10:31 ` Ian Campbell
2014-04-04 11:56 ` [PATCH v2 07/15] xen/arm: split gic driver into generic and gic-v2 driver vijay.kilari
2014-04-10 8:58 ` Ian Campbell
2014-04-10 9:27 ` Vijay Kilari
2014-04-04 11:56 ` [PATCH v2 08/15] xen/arm: use device api to detect GIC version vijay.kilari
2014-04-04 14:07 ` Julien Grall
2014-04-09 14:28 ` Vijay Kilari
2014-04-09 14:32 ` Julien Grall
2014-04-10 9:05 ` Ian Campbell
2014-04-04 11:56 ` [PATCH v2 09/15] xen/arm: segregate VGIC low level functionality vijay.kilari
2014-04-04 14:13 ` Julien Grall
2014-04-10 9:08 ` Ian Campbell
2014-04-04 11:56 ` [PATCH v2 10/15] xen/arm: split vgic driver into generic and vgic-v2 driver vijay.kilari
2014-04-10 9:12 ` Ian Campbell
2014-04-04 11:56 ` [PATCH v2 11/15] xen/arm: make GIC context data version specific vijay.kilari
2014-04-04 14:09 ` Julien Grall
2014-04-10 9:14 ` Ian Campbell
2014-04-04 11:56 ` [PATCH v2 12/15] xen/arm: move GIC data to driver from domain structure vijay.kilari
2014-04-10 9:21 ` Ian Campbell
2014-04-04 11:56 ` [PATCH v2 13/15] xen/arm: Add support for GIC v3 vijay.kilari
2014-04-10 9:25 ` Ian Campbell
2014-04-10 10:00 ` Ian Campbell
2014-04-10 10:34 ` Julien Grall
2014-04-10 11:06 ` Vijay Kilari
2014-04-10 11:21 ` Julien Grall
2014-04-10 11:24 ` Julien Grall
2014-04-11 12:59 ` Vijay Kilari
2014-04-14 8:27 ` Ian Campbell
2014-04-14 9:52 ` Vijay Kilari
2014-04-04 11:56 ` [PATCH v2 14/15] xen/arm: Add vgic " vijay.kilari
2014-04-10 10:23 ` Ian Campbell
2014-04-10 10:43 ` Vijay Kilari
2014-04-10 10:51 ` Ian Campbell
2014-04-10 11:19 ` Vijay Kilari
2014-04-10 11:26 ` Ian Campbell
2014-04-10 11:38 ` Vijay Kilari
2014-04-10 12:08 ` Ian Campbell
2014-04-10 13:14 ` Vijay Kilari
2014-04-04 11:56 ` [PATCH v2 15/15] xen/arm: update GIC dt node with GIC v3 information vijay.kilari
2014-04-04 14:22 ` Julien Grall
2014-04-04 15:45 ` Vijay Kilari
2014-04-04 16:00 ` Julien Grall
2014-04-04 16:13 ` Vijay Kilari
2014-04-04 16:42 ` Julien Grall
2014-04-10 10:28 ` Ian Campbell
2014-04-04 13:01 ` [PATCH v2 00/15] xen/arm: Add GICv3 support Julien Grall
2014-04-04 15:56 ` Vijay Kilari
2014-04-04 16:03 ` Julien Grall
2014-04-10 8:45 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396612593-443-2-git-send-email-vijay.kilari@gmail.com \
--to=vijay.kilari@gmail.com \
--cc=Ian.Campbell@citrix.com \
--cc=Prasun.Kapoor@caviumnetworks.com \
--cc=Vijaya.Kumar@caviumnetworks.com \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).