From: vijay.kilari@gmail.com
To: Ian.Campbell@citrix.com, julien.grall@linaro.org,
stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com,
xen-devel@lists.xen.org
Cc: Prasun.Kapoor@caviumnetworks.com,
Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>,
vijay.kilari@gmail.com
Subject: [PATCH v2 03/15] arm/xen: move gic save and restore registers to gic driver
Date: Fri, 4 Apr 2014 17:26:21 +0530 [thread overview]
Message-ID: <1396612593-443-4-git-send-email-vijay.kilari@gmail.com> (raw)
In-Reply-To: <1396612593-443-1-git-send-email-vijay.kilari@gmail.com>
From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
gic saved registers are moved to gic driver.
This required structure is allocated at runtime
and is saved & restored.
Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
---
xen/arch/arm/domain.c | 3 +++
xen/arch/arm/gic.c | 26 +++++++++++++++++---------
xen/include/asm-arm/domain.h | 3 +--
xen/include/asm-arm/gic.h | 8 ++++++++
4 files changed, 29 insertions(+), 11 deletions(-)
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 3d7e685..701298a 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -467,6 +467,9 @@ int vcpu_initialise(struct vcpu *v)
v->arch.saved_context.sp = (register_t)v->arch.cpu_info;
v->arch.saved_context.pc = (register_t)continue_new_vcpu;
+ if ( (rc = vcpu_gic_init(v)) != 0 )
+ return rc;
+
/* Idle VCPUs don't need the rest of this setup */
if ( is_idle_vcpu(v) )
return rc;
diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
index 86c52ac..a59118f 100644
--- a/xen/arch/arm/gic.c
+++ b/xen/arch/arm/gic.c
@@ -106,11 +106,11 @@ void gic_save_state(struct vcpu *v)
* this call and it only accesses struct vcpu fields that cannot be
* accessed simultaneously by another pCPU.
*/
- for ( i=0; i<nr_lrs; i++)
- v->arch.gic_lr[i] = GICH[GICH_LR + i];
+ for ( i = 0; i < nr_lrs; i++ )
+ v->arch.gic_state->gic_lr[i] = GICH[GICH_LR + i];
v->arch.lr_mask = this_cpu(lr_mask);
- v->arch.gic_apr = GICH[GICH_APR];
- v->arch.gic_vmcr = GICH[GICH_VMCR];
+ v->arch.gic_state->gic_apr = GICH[GICH_APR];
+ v->arch.gic_state->gic_vmcr = GICH[GICH_VMCR];
/* Disable until next VCPU scheduled */
GICH[GICH_HCR] = 0;
isb();
@@ -125,10 +125,10 @@ void gic_restore_state(struct vcpu *v)
return;
this_cpu(lr_mask) = v->arch.lr_mask;
- for ( i=0; i<nr_lrs; i++)
- GICH[GICH_LR + i] = v->arch.gic_lr[i];
- GICH[GICH_APR] = v->arch.gic_apr;
- GICH[GICH_VMCR] = v->arch.gic_vmcr;
+ for ( i = 0; i < nr_lrs; i++ )
+ GICH[GICH_LR + i] = v->arch.gic_state->gic_lr[i];
+ GICH[GICH_APR] = v->arch.gic_state->gic_apr;
+ GICH[GICH_VMCR] = v->arch.gic_state->gic_vmcr;
GICH[GICH_HCR] = GICH_HCR_EN;
isb();
@@ -975,6 +975,14 @@ void gic_interrupt(struct cpu_user_regs *regs, int is_fiq)
} while (1);
}
+int vcpu_gic_init(struct vcpu *v)
+{
+ v->arch.gic_state = xzalloc(struct gic_state_data);
+ if(!v->arch.gic_state)
+ return -ENOMEM;
+ return 0;
+}
+
int gicv_setup(struct domain *d)
{
int ret;
@@ -1044,7 +1052,7 @@ void gic_dump_info(struct vcpu *v)
printk(" HW_LR[%d]=%x\n", i, GICH[GICH_LR + i]);
} else {
for ( i = 0; i < nr_lrs; i++ )
- printk(" VCPU_LR[%d]=%x\n", i, v->arch.gic_lr[i]);
+ printk(" VCPU_LR[%d]=%x\n", i, v->arch.gic_state->gic_lr[i]);
}
list_for_each_entry ( p, &v->arch.vgic.inflight_irqs, inflight )
diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
index 5b23d07..c51b3cb 100644
--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -252,8 +252,7 @@ struct arch_vcpu
uint32_t csselr;
register_t vmpidr;
- uint32_t gic_hcr, gic_vmcr, gic_apr;
- uint32_t gic_lr[64];
+ struct gic_state_data *gic_state;
uint64_t event_mask;
uint64_t lr_mask;
diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h
index dd7e891..8a28c4a 100644
--- a/xen/include/asm-arm/gic.h
+++ b/xen/include/asm-arm/gic.h
@@ -169,12 +169,20 @@ struct vgic_irq_rank {
uint32_t itargets[8];
};
+struct gic_state_data {
+ uint32_t gic_hcr, gic_vmcr;
+ uint32_t gic_apr;
+ uint32_t gic_lr[64];
+};
+
extern int domain_vgic_init(struct domain *d);
extern void domain_vgic_free(struct domain *d);
extern int vcpu_vgic_init(struct vcpu *v);
extern int vcpu_vgic_free(struct vcpu *v);
+extern int vcpu_gic_init(struct vcpu *v);
+
extern void vgic_vcpu_inject_irq(struct vcpu *v, unsigned int irq);
extern void vgic_clear_pending_irqs(struct vcpu *v);
extern struct pending_irq *irq_to_pending(struct vcpu *v, unsigned int irq);
--
1.7.9.5
next prev parent reply other threads:[~2014-04-04 11:56 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 11:56 [PATCH v2 00/15] xen/arm: Add GICv3 support vijay.kilari
2014-04-04 11:56 ` [PATCH v2 01/15] xen/arm: register mmio handler at runtime vijay.kilari
2014-04-04 12:18 ` Julien Grall
2014-04-04 12:30 ` Vijay Kilari
2014-04-04 12:42 ` Ian Campbell
2014-04-04 12:54 ` Julien Grall
2014-04-04 12:59 ` Ian Campbell
2014-04-04 13:06 ` Julien Grall
2014-04-04 12:59 ` Julien Grall
2014-04-08 4:47 ` Vijay Kilari
2014-04-08 10:17 ` Julien Grall
2014-04-08 10:34 ` Vijay Kilari
2014-04-08 10:51 ` Julien Grall
2014-04-08 11:41 ` Vijay Kilari
2014-04-08 12:29 ` Ian Campbell
2014-04-04 15:24 ` Vijay Kilari
2014-04-04 15:27 ` Julien Grall
2014-04-08 6:35 ` Vijay Kilari
2014-04-08 10:25 ` Julien Grall
2014-04-09 15:34 ` Ian Campbell
2014-04-04 11:56 ` [PATCH v2 02/15] xen/arm: move vgic rank data to gic header file vijay.kilari
2014-04-04 13:16 ` Julien Grall
2014-04-04 15:27 ` Vijay Kilari
2014-04-04 11:56 ` vijay.kilari [this message]
2014-04-04 13:23 ` [PATCH v2 03/15] arm/xen: move gic save and restore registers to gic driver Julien Grall
2014-04-09 16:51 ` Ian Campbell
2014-04-10 4:50 ` Vijay Kilari
2014-04-10 8:32 ` Ian Campbell
2014-04-04 11:56 ` [PATCH v2 04/15] xen/arm: move gic definitions to seperate file vijay.kilari
2014-04-04 13:27 ` Julien Grall
2014-04-04 15:29 ` Vijay Kilari
2014-04-04 15:37 ` Julien Grall
2014-04-09 15:41 ` Ian Campbell
2014-04-04 11:56 ` [PATCH v2 05/15] xen/arm: segregate GIC low level functionality vijay.kilari
2014-04-04 13:55 ` Julien Grall
2014-04-09 7:43 ` Vijay Kilari
2014-04-09 8:36 ` Julien Grall
2014-04-09 15:55 ` Ian Campbell
2014-04-09 17:00 ` Ian Campbell
2014-04-09 17:07 ` Julien Grall
2014-04-10 5:24 ` Vijay Kilari
2014-04-10 8:59 ` Ian Campbell
2014-04-09 8:50 ` Julien Grall
2014-04-09 11:34 ` Vijay Kilari
2014-04-09 12:10 ` Julien Grall
2014-04-09 15:54 ` Ian Campbell
2014-04-04 11:56 ` [PATCH v2 06/15] xen/arm: move gic lock out of gic data structure vijay.kilari
2014-04-10 8:52 ` Ian Campbell
2014-04-10 9:24 ` Vijay Kilari
2014-04-10 10:02 ` Ian Campbell
2014-04-10 10:12 ` Vijay Kilari
2014-04-10 10:31 ` Ian Campbell
2014-04-04 11:56 ` [PATCH v2 07/15] xen/arm: split gic driver into generic and gic-v2 driver vijay.kilari
2014-04-10 8:58 ` Ian Campbell
2014-04-10 9:27 ` Vijay Kilari
2014-04-04 11:56 ` [PATCH v2 08/15] xen/arm: use device api to detect GIC version vijay.kilari
2014-04-04 14:07 ` Julien Grall
2014-04-09 14:28 ` Vijay Kilari
2014-04-09 14:32 ` Julien Grall
2014-04-10 9:05 ` Ian Campbell
2014-04-04 11:56 ` [PATCH v2 09/15] xen/arm: segregate VGIC low level functionality vijay.kilari
2014-04-04 14:13 ` Julien Grall
2014-04-10 9:08 ` Ian Campbell
2014-04-04 11:56 ` [PATCH v2 10/15] xen/arm: split vgic driver into generic and vgic-v2 driver vijay.kilari
2014-04-10 9:12 ` Ian Campbell
2014-04-04 11:56 ` [PATCH v2 11/15] xen/arm: make GIC context data version specific vijay.kilari
2014-04-04 14:09 ` Julien Grall
2014-04-10 9:14 ` Ian Campbell
2014-04-04 11:56 ` [PATCH v2 12/15] xen/arm: move GIC data to driver from domain structure vijay.kilari
2014-04-10 9:21 ` Ian Campbell
2014-04-04 11:56 ` [PATCH v2 13/15] xen/arm: Add support for GIC v3 vijay.kilari
2014-04-10 9:25 ` Ian Campbell
2014-04-10 10:00 ` Ian Campbell
2014-04-10 10:34 ` Julien Grall
2014-04-10 11:06 ` Vijay Kilari
2014-04-10 11:21 ` Julien Grall
2014-04-10 11:24 ` Julien Grall
2014-04-11 12:59 ` Vijay Kilari
2014-04-14 8:27 ` Ian Campbell
2014-04-14 9:52 ` Vijay Kilari
2014-04-04 11:56 ` [PATCH v2 14/15] xen/arm: Add vgic " vijay.kilari
2014-04-10 10:23 ` Ian Campbell
2014-04-10 10:43 ` Vijay Kilari
2014-04-10 10:51 ` Ian Campbell
2014-04-10 11:19 ` Vijay Kilari
2014-04-10 11:26 ` Ian Campbell
2014-04-10 11:38 ` Vijay Kilari
2014-04-10 12:08 ` Ian Campbell
2014-04-10 13:14 ` Vijay Kilari
2014-04-04 11:56 ` [PATCH v2 15/15] xen/arm: update GIC dt node with GIC v3 information vijay.kilari
2014-04-04 14:22 ` Julien Grall
2014-04-04 15:45 ` Vijay Kilari
2014-04-04 16:00 ` Julien Grall
2014-04-04 16:13 ` Vijay Kilari
2014-04-04 16:42 ` Julien Grall
2014-04-10 10:28 ` Ian Campbell
2014-04-04 13:01 ` [PATCH v2 00/15] xen/arm: Add GICv3 support Julien Grall
2014-04-04 15:56 ` Vijay Kilari
2014-04-04 16:03 ` Julien Grall
2014-04-10 8:45 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396612593-443-4-git-send-email-vijay.kilari@gmail.com \
--to=vijay.kilari@gmail.com \
--cc=Ian.Campbell@citrix.com \
--cc=Prasun.Kapoor@caviumnetworks.com \
--cc=Vijaya.Kumar@caviumnetworks.com \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).