xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: xen-devel@lists.xenproject.org
Cc: stefano.stabellini@citrix.com,
	Julien Grall <julien.grall@linaro.org>,
	tim@xen.org, ian.campbell@citrix.com
Subject: [PATCH v3 05/18] xen/arm: IRQ: drop irq parameter in __setup_irq
Date: Tue,  8 Apr 2014 15:43:54 +0100	[thread overview]
Message-ID: <1396968247-8768-6-git-send-email-julien.grall@linaro.org> (raw)
In-Reply-To: <1396968247-8768-1-git-send-email-julien.grall@linaro.org>

The IRQ number is already provided by desc and __setup_irq doesn't use
it in any case.

Signed-off-by: Julien Grall <julien.grall@linaro.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>

---
    Changes in v2:
        - Patch added
---
 xen/arch/arm/gic.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
index bc928ec..9cc5fd6 100644
--- a/xen/arch/arm/gic.c
+++ b/xen/arch/arm/gic.c
@@ -598,8 +598,7 @@ void __init release_irq(unsigned int irq)
         xfree(action);
 }
 
-static int __setup_irq(struct irq_desc *desc, unsigned int irq,
-                       struct irqaction *new)
+static int __setup_irq(struct irq_desc *desc, struct irqaction *new)
 {
     if ( desc->action != NULL )
         return -EBUSY;
@@ -619,7 +618,7 @@ int __init setup_dt_irq(const struct dt_irq *irq, struct irqaction *new)
     desc = irq_to_desc(irq->irq);
 
     spin_lock_irqsave(&desc->lock, flags);
-    rc = __setup_irq(desc, irq->irq, new);
+    rc = __setup_irq(desc, new);
     spin_unlock_irqrestore(&desc->lock, flags);
 
     if ( !rc )
@@ -903,7 +902,7 @@ int gic_route_irq_to_guest(struct domain *d, const struct dt_irq *irq,
     gic_set_irq_properties(irq->irq, level, cpumask_of(smp_processor_id()),
                            GIC_PRI_IRQ);
 
-    retval = __setup_irq(desc, irq->irq, action);
+    retval = __setup_irq(desc, action);
     if (retval) {
         xfree(action);
         goto out;
-- 
1.7.10.4

  parent reply	other threads:[~2014-04-08 14:44 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-08 14:43 [PATCH v3 00/18] xen/arm: Interrupt management reworking Julien Grall
2014-04-08 14:43 ` [PATCH v3 01/18] xen/arm: timer: replace timer_dt_irq by timer_get_irq Julien Grall
2014-04-16 15:27   ` Ian Campbell
2014-04-08 14:43 ` [PATCH v3 02/18] xen/arm: IRQ: Use default irq callback from common code for no_irq_type Julien Grall
2014-04-08 14:43 ` [PATCH v3 03/18] xen/arm: IRQ: Rename irq_cfg into arch_irq_desc Julien Grall
2014-04-08 14:43 ` [PATCH v3 04/18] xen/arm: IRQ: move gic {, un}lock in gic_set_irq_properties Julien Grall
2014-04-08 14:43 ` Julien Grall [this message]
2014-04-08 14:43 ` [PATCH v3 06/18] xen/arm: IRQ: remove __init from setup_dt_irq, request_dt_irq and release_irq Julien Grall
2014-04-08 14:43 ` [PATCH v3 07/18] xen/arm: IRQ: Rework gic_route_irq_to_guest function Julien Grall
2014-04-16 15:31   ` Ian Campbell
2014-04-08 14:43 ` [PATCH v3 08/18] xen/arm: IRQ: Move IRQ management from gic.c to irq.c Julien Grall
2014-04-17 10:38   ` Ian Campbell
2014-04-08 14:43 ` [PATCH v3 09/18] xen/arm: IRQ Introduce irq_get_domain Julien Grall
2014-04-08 14:43 ` [PATCH v3 10/18] xen/arm: IRQ: Require desc.lock held by callers of hw_irq_controller callbacks Julien Grall
2014-04-16 15:36   ` Ian Campbell
2014-04-16 15:39     ` Julien Grall
2014-04-08 14:44 ` [PATCH v3 11/18] xen/arm: IRQ: Defer routing IRQ to Xen until setup_irq() call Julien Grall
2014-04-16 15:39   ` Ian Campbell
2014-04-08 14:44 ` [PATCH v3 12/18] xen/arm: IRQ: Do not allow IRQ to be shared between domains and XEN Julien Grall
2014-04-16 15:40   ` Ian Campbell
2014-04-21 19:16   ` Julien Grall
2014-04-08 14:44 ` [PATCH v3 13/18] xen/serial: remove serial_dt_irq Julien Grall
2014-04-17 10:22   ` Julien Grall
2014-04-17 10:35     ` Ian Campbell
2014-04-08 14:44 ` [PATCH v3 14/18] xen/arm: IRQ: Store IRQ type in arch_irq_desc Julien Grall
2014-04-16 15:45   ` Ian Campbell
2014-04-16 15:52     ` Julien Grall
2014-04-08 14:44 ` [PATCH v3 15/18] xen/arm: IRQ: Replace {request, setup}_dt_irq by {request, setup}_irq Julien Grall
2014-04-16 15:46   ` Ian Campbell
2014-04-08 14:44 ` [PATCH v3 16/18] xen: IRQ: Add dev_id parameter to release_irq Julien Grall
2014-04-08 14:55   ` Jan Beulich
2014-04-16 15:47   ` Ian Campbell
2014-04-08 14:44 ` [PATCH v3 17/18] xen/arm: IRQ: extend {request, setup}_irq to take an irqflags in parameter Julien Grall
2014-04-08 14:58   ` Jan Beulich
2014-04-16 15:46     ` Julien Grall
2014-04-16 15:48     ` Ian Campbell
2014-04-08 14:44 ` [PATCH v3 18/18] xen/arm: IRQ: Handle multiple action per IRQ Julien Grall
2014-04-08 14:59   ` Jan Beulich
2014-04-16 16:01     ` Julien Grall
2014-04-16 15:54   ` Ian Campbell
2014-04-16 16:06     ` Julien Grall
2014-04-16 16:17       ` Ian Campbell
2014-04-16 16:21         ` Jan Beulich
2014-04-16 16:23         ` Julien Grall
2014-04-17  7:07           ` Jan Beulich
2014-04-17 10:36             ` Julien Grall
2014-04-17 11:15               ` Jan Beulich
2014-04-17 11:22                 ` Julien Grall
2014-04-17 11:36                   ` Ian Campbell
2014-04-17 12:18                     ` Julien Grall
2014-04-17 12:27                       ` Ian Campbell
2014-04-17 12:35                         ` Julien Grall
2014-04-17 10:26 ` [PATCH v3 00/18] xen/arm: Interrupt management reworking Julien Grall
2014-04-17 10:39   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396968247-8768-6-git-send-email-julien.grall@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=stefano.stabellini@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).