From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2] Xen: Spread boot time page scrubbing across all available CPU's Date: Thu, 10 Apr 2014 13:09:50 +0200 Message-ID: <1397128190.5295.109.camel@Abyss> References: <20140401192905.GA16392@andromeda.dapyr.net> <20140403011918.GA24177@andromeda.dapyr.net> <20140403090007.GB38209@deinos.phlegethon.org> <20140409142059.GB5860@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0602747108863594189==" Return-path: In-Reply-To: <20140409142059.GB5860@phenom.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: keir@xen.org, andrew.cooper3@citrix.com, Tim Deegan , xen-devel@lists.xen.org, JBeulich@suse.com, Konrad Rzeszutek Wilk , Malcolm Crossley List-Id: xen-devel@lists.xenproject.org --===============0602747108863594189== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-MJsbgiy1XY0wm3XwuCpd" --=-MJsbgiy1XY0wm3XwuCpd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2014-04-09 at 10:20 -0400, Konrad Rzeszutek Wilk wrote: > On Thu, Apr 03, 2014 at 11:00:07AM +0200, Tim Deegan wrote: > An option would be for the worker to do: >=20 > void __init smp_scrub_heap_pages(void *data) > { > bool_t scrub_bsp =3D (bool_t)data; > unsigned long node_id =3D cpu_to_node(smp_processor_id()); > struct scrub_region *data; >=20 > if (node_id =3D=3D NUMA_NO_NODE) > if (scrub_bsp) > data =3D region[0]; > else > goto out; > else > data =3D region[node_id]; >=20 > and use that. Then the parameter passed in is just whether this > is the first loop (false) or the second loop (true). >=20 >=20 > Or perhaps: >=20 > >You're struggling a little to force this information into the SMP > >protocol; I think it would be cleaner if you carved the central loop of > >smp_scrub_heap_pages() out into its own funciton and called that here > >instead. >=20 > Just do that and then the workers will just quit if they detect > (node_id =3D=3D NUMA_NO_NODE) and there is no parameter parsing. >=20 FWIW, I think this option would look a lot better. > Let me try that. =09 >=20 Let us know how it goes... I'm also interested in this patch. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-MJsbgiy1XY0wm3XwuCpd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEABECAAYFAlNGe/4ACgkQk4XaBE3IOsQM3ACfRlygp/bCp6Ldtxpm3XX6IQQ/ e/AAn03mcA+xABAzTGX4KPAr8ng9PLKM =JyrF -----END PGP SIGNATURE----- --=-MJsbgiy1XY0wm3XwuCpd-- --===============0602747108863594189== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0602747108863594189==--