From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH V2 4/4] libxl_types.idl: replace empty
 Struct with None for libxl_event
Date: Mon, 14 Apr 2014 17:49:35 +0100
Message-ID: <1397494175.7802.18.camel@dagon.hellion.org.uk>
References: <1397143594-15308-1-git-send-email-wei.liu2@citrix.com>
	<1397143594-15308-5-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1397143594-15308-5-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Thu, 2014-04-10 at 16:26 +0100, Wei Liu wrote:
> Now we generate empty map for None, the empty Struct trick is not
> necessary anymore.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

But you've missed
            ("domain_death", Struct(None, [])),
in the same struct.

Arguably this is an API change -- but since the struct was 
        struct {
                } domain_create_console_available;

I don't think it is material enough to warrant a #define etc.