xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH V2 4/4] libxl_types.idl: replace empty Struct with None for libxl_event
Date: Mon, 14 Apr 2014 18:09:19 +0100	[thread overview]
Message-ID: <1397495359.7802.31.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <20140414165427.GC3635@zion.uk.xensource.com>

On Mon, 2014-04-14 at 17:54 +0100, Wei Liu wrote:
> On Mon, Apr 14, 2014 at 05:49:35PM +0100, Ian Campbell wrote:
> > On Thu, 2014-04-10 at 16:26 +0100, Wei Liu wrote:
> > > Now we generate empty map for None, the empty Struct trick is not
> > > necessary anymore.
> > > 
> > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > 
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > 
> > But you've missed
> >             ("domain_death", Struct(None, [])),
> > in the same struct.
> 
> Oops. My fault.

No worries, you can keep the ack on the new version too.

      reply	other threads:[~2014-04-14 17:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10 15:26 [PATCH V2 0/4] libxl: fixes for JSON infrastructure Wei Liu
2014-04-10 15:26 ` [PATCH V2 1/4] libxl/gentypes.py: don't generate JSON for private type(s) Wei Liu
2014-04-14 16:46   ` Ian Campbell
2014-04-10 15:26 ` [PATCH V2 2/4] libxl_json: fix JSON parser debug code Wei Liu
2014-04-14 16:47   ` Ian Campbell
2014-04-10 15:26 ` [PATCH V2 3/4] libxl/gentypes.py: generate empty map for None field in keyed-union Wei Liu
2014-04-14 16:47   ` Ian Campbell
2014-04-14 16:53   ` Ian Campbell
2014-04-14 16:59     ` Wei Liu
2014-04-14 17:08       ` Ian Campbell
2014-04-14 17:11         ` Wei Liu
2014-04-16 16:30           ` Ian Campbell
2014-04-16 16:36             ` Wei Liu
2014-04-15 10:29         ` Ian Jackson
2014-04-15 10:32           ` Ian Campbell
2014-04-15 11:29             ` Ian Jackson
2014-04-10 15:26 ` [PATCH V2 4/4] libxl_types.idl: replace empty Struct with None for libxl_event Wei Liu
2014-04-14 16:49   ` Ian Campbell
2014-04-14 16:54     ` Wei Liu
2014-04-14 17:09       ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397495359.7802.31.camel@dagon.hellion.org.uk \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).