From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: [PATCH RFC 17/23] libxl: add support for FreeBSD uuid implementation
Date: Wed, 16 Apr 2014 16:13:26 +0200 [thread overview]
Message-ID: <1397657612-57277-18-git-send-email-roger.pau@citrix.com> (raw)
In-Reply-To: <1397657612-57277-1-git-send-email-roger.pau@citrix.com>
Add the FreeBSD specific uuid implementation. Since uuid_t is not
defined as an array, but as a struct on FreeBSD, use a union with a
array in order to be able to return the uuid as a bytearray.
Also, added a libxl internal compile time assert macro, that is used
to assert that the size of uuid_t is the same as the union used in
libxl.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
---
tools/libxl/libxl_internal.h | 4 +++
tools/libxl/libxl_uuid.c | 51 ++++++++++++++++++++++++++++++++++++++++++
tools/libxl/libxl_uuid.h | 12 ++++++++++
3 files changed, 67 insertions(+), 0 deletions(-)
diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
index c2b73c4..9f8ab49 100644
--- a/tools/libxl/libxl_internal.h
+++ b/tools/libxl/libxl_internal.h
@@ -3085,6 +3085,10 @@ void libxl__numa_candidate_put_nodemap(libxl__gc *gc,
*/
#define CTYPE(isfoo,c) (isfoo((unsigned char)(c)))
+/*
+ * Compile time assertion
+ */
+#define BUILD_BUG_ON(p) ((void)sizeof(char[1 - 2 * !!(p)]))
#endif
diff --git a/tools/libxl/libxl_uuid.c b/tools/libxl/libxl_uuid.c
index ecc29c7..4b35e88 100644
--- a/tools/libxl/libxl_uuid.c
+++ b/tools/libxl/libxl_uuid.c
@@ -102,6 +102,57 @@ uint8_t *libxl_uuid_bytearray(libxl_uuid *uuid)
return uuid->uuid;
}
+#elif defined(__FreeBSD__)
+
+int libxl_uuid_is_nil(libxl_uuid *uuid)
+{
+
+ return uuid_is_nil(&uuid->uuid, NULL);
+}
+
+void libxl_uuid_generate(libxl_uuid *uuid)
+{
+ uint32_t status;
+
+ BUILD_BUG_ON(sizeof(libxl_uuid) != sizeof(uuid_t));
+ uuid_create(&uuid->uuid, &status);
+ assert(status == uuid_s_ok);
+}
+
+int libxl_uuid_from_string(libxl_uuid *uuid, const char *in)
+{
+ uint32_t status;
+
+ uuid_from_string(in, &uuid->uuid, &status);
+ if (status != uuid_s_ok)
+ return -1;
+ return 0;
+}
+
+void libxl_uuid_copy(libxl_uuid *dst, const libxl_uuid *src)
+{
+
+ memcpy(&dst->uuid, &src->uuid, sizeof(dst->uuid));
+}
+
+void libxl_uuid_clear(libxl_uuid *uuid)
+{
+
+ memset(&uuid->uuid, 0, sizeof(uuid->uuid));
+}
+
+int libxl_uuid_compare(libxl_uuid *uuid1, libxl_uuid *uuid2)
+{
+
+ return uuid_compare(&uuid1->uuid, &uuid2->uuid, NULL);
+}
+
+uint8_t *libxl_uuid_bytearray(libxl_uuid *uuid)
+{
+
+ return uuid->uuid_raw;
+}
+
#else
#error "Please update libxl_uuid.c for your OS"
diff --git a/tools/libxl/libxl_uuid.h b/tools/libxl/libxl_uuid.h
index 93c65a7..3604180 100644
--- a/tools/libxl/libxl_uuid.h
+++ b/tools/libxl/libxl_uuid.h
@@ -47,6 +47,18 @@ typedef struct {
uint8_t uuid[16];
} libxl_uuid;
+#elif defined(__FreeBSD__)
+
+#include <uuid.h>
+#include <stdint.h>
+
+typedef union {
+ uuid_t uuid;
+ uint8_t uuid_raw[16];
+} libxl_uuid;
+
+#define LIBXL_UUID_BYTES(arg) LIBXL__UUID_BYTES(arg.uuid_raw)
+
#else
#error "Please update libxl_uuid.h for your OS"
--
1.7.7.5 (Apple Git-26)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-04-16 14:24 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 14:13 [PATCH RFC 00/23] tools: add support for FreeBSD Roger Pau Monne
2014-04-16 14:13 ` [PATCH RFC 01/23] build: set FreeBSD specific build variables Roger Pau Monne
2014-04-17 16:20 ` Ian Jackson
2014-04-28 14:27 ` Ian Campbell
2014-04-16 14:13 ` [PATCH RFC 02/23] configure: make the libaio test non-fatal on OSes different than Linux Roger Pau Monne
2014-04-17 16:21 ` Ian Jackson
2014-04-22 14:30 ` Roger Pau Monné
2014-04-28 14:28 ` Ian Campbell
2014-04-16 14:13 ` [PATCH RFC 03/23] include: import FreeBSD headers for evtchn and privcmd devices Roger Pau Monne
2014-04-17 16:16 ` Ian Jackson
2014-04-22 14:35 ` Roger Pau Monné
2014-04-22 14:39 ` Ian Campbell
2014-04-28 14:29 ` Ian Campbell
2014-04-16 14:13 ` [PATCH RFC 04/23] libxc: add support for FreeBSD Roger Pau Monne
2014-04-17 16:30 ` Ian Jackson
2014-04-17 16:39 ` Ian Campbell
2014-04-17 17:18 ` Ian Jackson
2014-04-16 14:13 ` [PATCH RFC 05/23] libxc: remove usage of "daylight" variable Roger Pau Monne
2014-04-17 16:44 ` Ian Jackson
2014-04-28 14:32 ` Ian Campbell
2014-04-16 14:13 ` [PATCH RFC 06/23] libxc: remove include of malloc.h Roger Pau Monne
2014-04-17 16:44 ` Ian Jackson
2014-04-16 14:13 ` [PATCH RFC 07/23] libelf: add defines for bswap_* functions for FreeBSD Roger Pau Monne
2014-04-17 16:45 ` Ian Jackson
2014-04-28 14:34 ` Ian Campbell
2014-04-16 14:13 ` [PATCH RFC 08/23] configure: add checks for endian.h and sys/endian.h Roger Pau Monne
2014-04-17 16:46 ` Ian Jackson
2014-04-16 14:13 ` [PATCH RFC 09/23] lz4: add support for OSes that don't have asm/unaligned.h Roger Pau Monne
2014-04-17 17:00 ` Ian Jackson
2014-04-22 14:46 ` Roger Pau Monné
2014-04-22 15:25 ` Ian Jackson
2014-04-22 15:55 ` Ian Campbell
2014-04-22 16:40 ` Roger Pau Monné
2014-04-22 22:27 ` Yann Collet
2014-04-23 8:53 ` Ian Campbell
2014-04-23 9:06 ` Roger Pau Monné
2014-04-23 9:09 ` Ian Campbell
2014-04-23 16:18 ` Roger Pau Monné
2014-04-24 8:28 ` Ian Campbell
2014-04-24 9:19 ` Roger Pau Monné
2014-04-24 9:38 ` Ian Campbell
2014-04-16 14:13 ` [PATCH RFC 10/23] xenstored: add the FreeBSD xenstored interface Roger Pau Monne
2014-04-17 17:02 ` Ian Jackson
2014-04-22 14:50 ` Roger Pau Monné
2014-04-22 15:45 ` Ian Jackson
2014-04-16 14:13 ` [PATCH RFC 11/23] xenstore: add some missing headers Roger Pau Monne
2014-04-17 17:03 ` Ian Jackson
2014-04-16 14:13 ` [PATCH RFC 12/23] console: add FreeBSD includes Roger Pau Monne
2014-04-17 17:05 ` Ian Jackson
2014-04-16 14:13 ` [PATCH RFC 13/23] init: add FreeBSD xencommons init script Roger Pau Monne
2014-04-28 14:36 ` Ian Campbell
2014-06-02 11:53 ` Roger Pau Monné
2014-06-02 13:50 ` Ian Campbell
2014-04-16 14:13 ` [PATCH RFC 14/23] hotplug: add FreeBSD vif-bridge Roger Pau Monne
2014-04-28 14:39 ` Ian Campbell
2014-06-02 11:56 ` Roger Pau Monné
2014-06-02 13:52 ` Ian Campbell
2014-06-02 14:46 ` Roger Pau Monné
2014-06-02 15:08 ` Ian Campbell
2014-04-16 14:13 ` [PATCH RFC 15/23] libxl: add support for OS-specific names to backend interfaces Roger Pau Monne
2014-04-17 17:06 ` Ian Jackson
2014-04-16 14:13 ` [PATCH RFC 16/23] libxl: add FreeBSD OS support Roger Pau Monne
2014-04-17 17:10 ` Ian Jackson
2014-04-22 14:55 ` Roger Pau Monné
2014-04-16 14:13 ` Roger Pau Monne [this message]
2014-04-17 17:11 ` [PATCH RFC 17/23] libxl: add support for FreeBSD uuid implementation Ian Jackson
2014-04-22 15:09 ` Roger Pau Monné
2014-04-16 14:13 ` [PATCH RFC 18/23] libxl: only include utmp.h if it's present Roger Pau Monne
2014-04-17 17:13 ` Ian Jackson
2014-04-17 17:21 ` Roger Pau Monné
2014-04-17 18:26 ` Ian Jackson
2014-04-16 14:13 ` [PATCH RFC 19/23] hvmloader: remove size_t typedef and include stddef.h Roger Pau Monne
2014-04-28 14:43 ` Ian Campbell
2014-06-02 12:13 ` Roger Pau Monné
2014-06-02 13:53 ` Ian Campbell
2014-04-16 14:13 ` [PATCH RFC 20/23] xenstat: add a dummy FreeBSD implementation Roger Pau Monne
2014-04-17 17:15 ` Ian Jackson
2014-04-17 17:25 ` Roger Pau Monné
2014-04-17 18:26 ` Ian Jackson
2014-04-28 14:45 ` Ian Campbell
2014-04-16 14:13 ` [PATCH RFC 21/23] gdbsx: remove cast from ioctl Roger Pau Monne
2014-04-17 17:17 ` Ian Jackson
2014-04-28 14:46 ` Ian Campbell
2014-04-28 19:42 ` Mukesh Rathor
2014-04-16 14:13 ` [PATCH RFC 22/23] build: export CC value to SeaBIOS Roger Pau Monne
2014-04-28 14:47 ` Ian Campbell
2014-04-16 14:13 ` [PATCH RFC 23/23] build: export linker emulation parameter " Roger Pau Monne
2014-04-28 14:50 ` Ian Campbell
2014-04-17 8:55 ` [PATCH RFC 00/23] tools: add support for FreeBSD Roger Pau Monné
2014-05-02 13:00 ` Ian Campbell
2014-05-02 13:02 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397657612-57277-18-git-send-email-roger.pau@citrix.com \
--to=roger.pau@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).