From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: [PATCH RFC 21/23] gdbsx: remove cast from ioctl
Date: Wed, 16 Apr 2014 16:13:30 +0200 [thread overview]
Message-ID: <1397657612-57277-22-git-send-email-roger.pau@citrix.com> (raw)
In-Reply-To: <1397657612-57277-1-git-send-email-roger.pau@citrix.com>
The ulong type is not defined on FreeBSD, and the cast seems
pointless, so just remove it.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
---
tools/debugger/gdbsx/xg/xg_main.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/debugger/gdbsx/xg/xg_main.c b/tools/debugger/gdbsx/xg/xg_main.c
index 0fc3f82..c95e4ed 100644
--- a/tools/debugger/gdbsx/xg/xg_main.c
+++ b/tools/debugger/gdbsx/xg/xg_main.c
@@ -180,7 +180,7 @@ _domctl_hcall(uint32_t cmd, /* which domctl hypercall */
hypercall.op = __HYPERVISOR_domctl;
hypercall.arg[0] = (unsigned long)&domctl;
- rc = ioctl(_dom0_fd, IOCTL_PRIVCMD_HYPERCALL, (ulong)&hypercall);
+ rc = ioctl(_dom0_fd, IOCTL_PRIVCMD_HYPERCALL, &hypercall);
if (domctlarg && sz)
munlock(domctlarg, sz);
return rc;
@@ -220,7 +220,7 @@ _check_hyp(int guest_bitness)
hypercall.arg[0] = (unsigned long)XENVER_capabilities;
hypercall.arg[1] = (unsigned long)&xen_caps;
- rc = ioctl(_dom0_fd, IOCTL_PRIVCMD_HYPERCALL, (ulong)&hypercall);
+ rc = ioctl(_dom0_fd, IOCTL_PRIVCMD_HYPERCALL, &hypercall);
munlock(&xen_caps, sizeof(xen_caps));
XGTRC("XENCAPS:%s\n", xen_caps);
--
1.7.7.5 (Apple Git-26)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-04-16 14:23 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 14:13 [PATCH RFC 00/23] tools: add support for FreeBSD Roger Pau Monne
2014-04-16 14:13 ` [PATCH RFC 01/23] build: set FreeBSD specific build variables Roger Pau Monne
2014-04-17 16:20 ` Ian Jackson
2014-04-28 14:27 ` Ian Campbell
2014-04-16 14:13 ` [PATCH RFC 02/23] configure: make the libaio test non-fatal on OSes different than Linux Roger Pau Monne
2014-04-17 16:21 ` Ian Jackson
2014-04-22 14:30 ` Roger Pau Monné
2014-04-28 14:28 ` Ian Campbell
2014-04-16 14:13 ` [PATCH RFC 03/23] include: import FreeBSD headers for evtchn and privcmd devices Roger Pau Monne
2014-04-17 16:16 ` Ian Jackson
2014-04-22 14:35 ` Roger Pau Monné
2014-04-22 14:39 ` Ian Campbell
2014-04-28 14:29 ` Ian Campbell
2014-04-16 14:13 ` [PATCH RFC 04/23] libxc: add support for FreeBSD Roger Pau Monne
2014-04-17 16:30 ` Ian Jackson
2014-04-17 16:39 ` Ian Campbell
2014-04-17 17:18 ` Ian Jackson
2014-04-16 14:13 ` [PATCH RFC 05/23] libxc: remove usage of "daylight" variable Roger Pau Monne
2014-04-17 16:44 ` Ian Jackson
2014-04-28 14:32 ` Ian Campbell
2014-04-16 14:13 ` [PATCH RFC 06/23] libxc: remove include of malloc.h Roger Pau Monne
2014-04-17 16:44 ` Ian Jackson
2014-04-16 14:13 ` [PATCH RFC 07/23] libelf: add defines for bswap_* functions for FreeBSD Roger Pau Monne
2014-04-17 16:45 ` Ian Jackson
2014-04-28 14:34 ` Ian Campbell
2014-04-16 14:13 ` [PATCH RFC 08/23] configure: add checks for endian.h and sys/endian.h Roger Pau Monne
2014-04-17 16:46 ` Ian Jackson
2014-04-16 14:13 ` [PATCH RFC 09/23] lz4: add support for OSes that don't have asm/unaligned.h Roger Pau Monne
2014-04-17 17:00 ` Ian Jackson
2014-04-22 14:46 ` Roger Pau Monné
2014-04-22 15:25 ` Ian Jackson
2014-04-22 15:55 ` Ian Campbell
2014-04-22 16:40 ` Roger Pau Monné
2014-04-22 22:27 ` Yann Collet
2014-04-23 8:53 ` Ian Campbell
2014-04-23 9:06 ` Roger Pau Monné
2014-04-23 9:09 ` Ian Campbell
2014-04-23 16:18 ` Roger Pau Monné
2014-04-24 8:28 ` Ian Campbell
2014-04-24 9:19 ` Roger Pau Monné
2014-04-24 9:38 ` Ian Campbell
2014-04-16 14:13 ` [PATCH RFC 10/23] xenstored: add the FreeBSD xenstored interface Roger Pau Monne
2014-04-17 17:02 ` Ian Jackson
2014-04-22 14:50 ` Roger Pau Monné
2014-04-22 15:45 ` Ian Jackson
2014-04-16 14:13 ` [PATCH RFC 11/23] xenstore: add some missing headers Roger Pau Monne
2014-04-17 17:03 ` Ian Jackson
2014-04-16 14:13 ` [PATCH RFC 12/23] console: add FreeBSD includes Roger Pau Monne
2014-04-17 17:05 ` Ian Jackson
2014-04-16 14:13 ` [PATCH RFC 13/23] init: add FreeBSD xencommons init script Roger Pau Monne
2014-04-28 14:36 ` Ian Campbell
2014-06-02 11:53 ` Roger Pau Monné
2014-06-02 13:50 ` Ian Campbell
2014-04-16 14:13 ` [PATCH RFC 14/23] hotplug: add FreeBSD vif-bridge Roger Pau Monne
2014-04-28 14:39 ` Ian Campbell
2014-06-02 11:56 ` Roger Pau Monné
2014-06-02 13:52 ` Ian Campbell
2014-06-02 14:46 ` Roger Pau Monné
2014-06-02 15:08 ` Ian Campbell
2014-04-16 14:13 ` [PATCH RFC 15/23] libxl: add support for OS-specific names to backend interfaces Roger Pau Monne
2014-04-17 17:06 ` Ian Jackson
2014-04-16 14:13 ` [PATCH RFC 16/23] libxl: add FreeBSD OS support Roger Pau Monne
2014-04-17 17:10 ` Ian Jackson
2014-04-22 14:55 ` Roger Pau Monné
2014-04-16 14:13 ` [PATCH RFC 17/23] libxl: add support for FreeBSD uuid implementation Roger Pau Monne
2014-04-17 17:11 ` Ian Jackson
2014-04-22 15:09 ` Roger Pau Monné
2014-04-16 14:13 ` [PATCH RFC 18/23] libxl: only include utmp.h if it's present Roger Pau Monne
2014-04-17 17:13 ` Ian Jackson
2014-04-17 17:21 ` Roger Pau Monné
2014-04-17 18:26 ` Ian Jackson
2014-04-16 14:13 ` [PATCH RFC 19/23] hvmloader: remove size_t typedef and include stddef.h Roger Pau Monne
2014-04-28 14:43 ` Ian Campbell
2014-06-02 12:13 ` Roger Pau Monné
2014-06-02 13:53 ` Ian Campbell
2014-04-16 14:13 ` [PATCH RFC 20/23] xenstat: add a dummy FreeBSD implementation Roger Pau Monne
2014-04-17 17:15 ` Ian Jackson
2014-04-17 17:25 ` Roger Pau Monné
2014-04-17 18:26 ` Ian Jackson
2014-04-28 14:45 ` Ian Campbell
2014-04-16 14:13 ` Roger Pau Monne [this message]
2014-04-17 17:17 ` [PATCH RFC 21/23] gdbsx: remove cast from ioctl Ian Jackson
2014-04-28 14:46 ` Ian Campbell
2014-04-28 19:42 ` Mukesh Rathor
2014-04-16 14:13 ` [PATCH RFC 22/23] build: export CC value to SeaBIOS Roger Pau Monne
2014-04-28 14:47 ` Ian Campbell
2014-04-16 14:13 ` [PATCH RFC 23/23] build: export linker emulation parameter " Roger Pau Monne
2014-04-28 14:50 ` Ian Campbell
2014-04-17 8:55 ` [PATCH RFC 00/23] tools: add support for FreeBSD Roger Pau Monné
2014-05-02 13:00 ` Ian Campbell
2014-05-02 13:02 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397657612-57277-22-git-send-email-roger.pau@citrix.com \
--to=roger.pau@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).