xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Waiman Long <Waiman.Long@hp.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <peterz@infradead.org>
Cc: linux-arch@vger.kernel.org, Waiman Long <Waiman.Long@hp.com>,
	Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
	Gleb Natapov <gleb@redhat.com>,
	kvm@vger.kernel.org, Scott J Norton <scott.norton@hp.com>,
	x86@kernel.org, Paolo Bonzini <paolo.bonzini@gmail.com>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Chegu Vinod <chegu_vinod@hp.com>,
	David Vrabel <david.vrabel@citrix.com>,
	Oleg Nesterov <oleg@redhat.com>,
	xen-devel@lists.xenproject.org,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH v9 15/19] pvqspinlock, x86: Add PV data structure & methods
Date: Thu, 17 Apr 2014 11:04:07 -0400	[thread overview]
Message-ID: <1397747051-15401-16-git-send-email-Waiman.Long@hp.com> (raw)
In-Reply-To: <1397747051-15401-1-git-send-email-Waiman.Long@hp.com>

This patch modifies the para-virtualization (PV) infrastructure code
of the x86-64 architecture to support the PV queue spinlock. Three
new virtual methods are added to support PV qspinlock:

 1) kick_cpu - schedule in a virtual CPU
 2) halt_cpu - schedule out a virtual CPU
 3) lockstat - update statistical data for debugfs

Signed-off-by: Waiman Long <Waiman.Long@hp.com>
---
 arch/x86/include/asm/paravirt.h       |   18 +++++++++++++++++-
 arch/x86/include/asm/paravirt_types.h |   17 +++++++++++++++++
 arch/x86/kernel/paravirt-spinlocks.c  |    6 ++++++
 3 files changed, 40 insertions(+), 1 deletions(-)

diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h
index cd6e161..d71e123 100644
--- a/arch/x86/include/asm/paravirt.h
+++ b/arch/x86/include/asm/paravirt.h
@@ -711,7 +711,23 @@ static inline void __set_fixmap(unsigned /* enum fixed_addresses */ idx,
 }
 
 #if defined(CONFIG_SMP) && defined(CONFIG_PARAVIRT_SPINLOCKS)
+#ifdef CONFIG_QUEUE_SPINLOCK
+static __always_inline void __queue_kick_cpu(int cpu)
+{
+	PVOP_VCALL1(pv_lock_ops.kick_cpu, cpu);
+}
+
+static __always_inline void
+__queue_halt_cpu(enum pv_lock_stats type, s8 *state, s8 sval)
+{
+	PVOP_VCALL3(pv_lock_ops.halt_cpu, type, state, sval);
+}
 
+static __always_inline void __queue_lockstat(enum pv_lock_stats type)
+{
+	PVOP_VCALL1(pv_lock_ops.lockstat, type);
+}
+#else
 static __always_inline void __ticket_lock_spinning(struct arch_spinlock *lock,
 							__ticket_t ticket)
 {
@@ -723,7 +739,7 @@ static __always_inline void __ticket_unlock_kick(struct arch_spinlock *lock,
 {
 	PVOP_VCALL2(pv_lock_ops.unlock_kick, lock, ticket);
 }
-
+#endif
 #endif
 
 #ifdef CONFIG_X86_32
diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h
index 7549b8b..549b3a0 100644
--- a/arch/x86/include/asm/paravirt_types.h
+++ b/arch/x86/include/asm/paravirt_types.h
@@ -333,9 +333,26 @@ struct arch_spinlock;
 typedef u16 __ticket_t;
 #endif
 
+#ifdef CONFIG_QUEUE_SPINLOCK
+enum pv_lock_stats {
+	PV_HALT_QHEAD,		/* Queue head halting	    */
+	PV_HALT_QNODE,		/* Other queue node halting */
+	PV_HALT_ABORT,		/* Halting aborted	    */
+	PV_WAKE_KICKED,		/* Wakeup by kicking	    */
+	PV_WAKE_SPURIOUS,	/* Spurious wakeup	    */
+	PV_KICK_NOHALT		/* Kick but CPU not halted  */
+};
+#endif
+
 struct pv_lock_ops {
+#ifdef CONFIG_QUEUE_SPINLOCK
+	void (*kick_cpu)(int cpu);
+	void (*halt_cpu)(enum pv_lock_stats type, s8 *state, s8 sval);
+	void (*lockstat)(enum pv_lock_stats type);
+#else
 	struct paravirt_callee_save lock_spinning;
 	void (*unlock_kick)(struct arch_spinlock *lock, __ticket_t ticket);
+#endif
 };
 
 /* This contains all the paravirt structures: we get a convenient
diff --git a/arch/x86/kernel/paravirt-spinlocks.c b/arch/x86/kernel/paravirt-spinlocks.c
index 6d36731..8d15bea 100644
--- a/arch/x86/kernel/paravirt-spinlocks.c
+++ b/arch/x86/kernel/paravirt-spinlocks.c
@@ -11,9 +11,15 @@
 #ifdef CONFIG_PARAVIRT_SPINLOCKS
 struct pv_lock_ops pv_lock_ops = {
 #ifdef CONFIG_SMP
+#ifdef CONFIG_QUEUE_SPINLOCK
+	.kick_cpu = paravirt_nop,
+	.halt_cpu = paravirt_nop,
+	.lockstat = paravirt_nop,
+#else
 	.lock_spinning = __PV_IS_CALLEE_SAVE(paravirt_nop),
 	.unlock_kick = paravirt_nop,
 #endif
+#endif
 };
 EXPORT_SYMBOL(pv_lock_ops);
 
-- 
1.7.1

  parent reply	other threads:[~2014-04-17 15:05 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1397747051-15401-1-git-send-email-Waiman.Long@hp.com>
2014-04-17 15:03 ` [PATCH v9 01/19] qspinlock: A simple generic 4-byte queue spinlock Waiman Long
2014-04-17 15:03 ` [PATCH v9 02/19] qspinlock, x86: Enable x86-64 to use " Waiman Long
2014-04-17 15:03 ` [PATCH v9 03/19] qspinlock: Add pending bit Waiman Long
2014-04-17 15:03 ` [PATCH v9 04/19] qspinlock: Extract out the exchange of tail code word Waiman Long
2014-04-17 15:03 ` [PATCH v9 05/19] qspinlock: Optimize for smaller NR_CPUS Waiman Long
2014-04-17 15:03 ` [PATCH v9 06/19] qspinlock: prolong the stay in the pending bit path Waiman Long
2014-04-17 16:36   ` Peter Zijlstra
     [not found]   ` <20140417163640.GT11096@twins.programming.kicks-ass.net>
2014-04-18  1:46     ` Waiman Long
     [not found]     ` <535083DC.2040406@hp.com>
2014-04-18  8:33       ` Peter Zijlstra
     [not found]       ` <20140418083342.GA11096@twins.programming.kicks-ass.net>
2014-04-18 18:07         ` Waiman Long
2014-04-17 15:03 ` [PATCH v9 07/19] qspinlock: Use a simple write to grab the lock, if applicable Waiman Long
2014-04-17 15:04 ` [PATCH v9 08/19] qspinlock: Make a new qnode structure to support virtualization Waiman Long
2014-04-17 15:04 ` [PATCH v9 09/19] qspinlock: Prepare for unfair lock support Waiman Long
2014-04-17 15:04 ` [PATCH v9 10/19] qspinlock, x86: Allow unfair spinlock in a virtual guest Waiman Long
2014-04-17 15:04 ` [PATCH v9 11/19] qspinlock: Split the MCS queuing code into a separate slowerpath Waiman Long
2014-04-17 15:04 ` [PATCH v9 12/19] unfair qspinlock: Variable frequency lock stealing mechanism Waiman Long
2014-04-17 15:04 ` [PATCH v9 13/19] unfair qspinlock: Enable lock stealing in lock waiters Waiman Long
2014-04-17 15:04 ` [PATCH v9 14/19] pvqspinlock, x86: Rename paravirt_ticketlocks_enabled Waiman Long
2014-04-17 15:04 ` Waiman Long [this message]
2014-04-17 15:04 ` [PATCH v9 16/19] pvqspinlock: Enable coexistence with the unfair lock Waiman Long
2014-04-17 15:04 ` [PATCH v9 17/19] pvqspinlock: Add qspinlock para-virtualization support Waiman Long
2014-04-17 15:04 ` [PATCH v9 18/19] pvqspinlock, x86: Enable PV qspinlock PV for KVM Waiman Long
2014-04-17 15:04 ` [PATCH v9 19/19] pvqspinlock, x86: Enable PV qspinlock for XEN Waiman Long
     [not found] ` <1397747051-15401-4-git-send-email-Waiman.Long@hp.com>
2014-04-17 15:42   ` [PATCH v9 03/19] qspinlock: Add pending bit Peter Zijlstra
     [not found]   ` <20140417154200.GN11096@twins.programming.kicks-ass.net>
2014-04-17 21:20     ` Waiman Long
     [not found]     ` <5350459F.5010903@hp.com>
2014-04-18  8:13       ` Peter Zijlstra
     [not found]       ` <20140418081345.GX11096@twins.programming.kicks-ass.net>
2014-04-18 17:07         ` Waiman Long
2014-04-18  7:42   ` Ingo Molnar
     [not found]   ` <20140418074255.GA13517@gmail.com>
2014-04-18 16:23     ` Waiman Long
     [not found]     ` <53515181.8090303@hp.com>
2014-04-18 16:35       ` Konrad Rzeszutek Wilk
     [not found]       ` <20140418163543.GA6208@phenom.dumpdata.com>
2014-04-18 18:12         ` Waiman Long
     [not found] ` <1397747051-15401-5-git-send-email-Waiman.Long@hp.com>
2014-04-17 15:49   ` [PATCH v9 04/19] qspinlock: Extract out the exchange of tail code word Peter Zijlstra
     [not found]   ` <20140417154902.GO11096@twins.programming.kicks-ass.net>
2014-04-17 21:28     ` Waiman Long
     [not found]     ` <53504771.9070102@hp.com>
2014-04-18  8:15       ` Peter Zijlstra
     [not found]       ` <20140418081517.GY11096@twins.programming.kicks-ass.net>
2014-04-18 17:32         ` Waiman Long
     [not found]         ` <535161BF.90405@hp.com>
2014-04-18 17:53           ` Peter Zijlstra
     [not found]           ` <20140418175339.GZ11182@twins.programming.kicks-ass.net>
2014-04-18 18:13             ` Waiman Long
     [not found] ` <1397747051-15401-6-git-send-email-Waiman.Long@hp.com>
2014-04-17 15:50   ` [PATCH v9 05/19] qspinlock: Optimize for smaller NR_CPUS Peter Zijlstra
2014-04-17 15:51   ` Peter Zijlstra
2014-04-17 15:56   ` Peter Zijlstra
2014-04-17 15:58   ` Peter Zijlstra
     [not found]   ` <20140417155002.GP11096@twins.programming.kicks-ass.net>
2014-04-17 21:29     ` Waiman Long
     [not found]   ` <20140417155115.GQ11096@twins.programming.kicks-ass.net>
2014-04-17 21:33     ` Waiman Long
     [not found]   ` <20140417155649.GR11096@twins.programming.kicks-ass.net>
2014-04-17 21:46     ` Waiman Long
     [not found]     ` <53504BB3.4010009@hp.com>
2014-04-18  8:27       ` Peter Zijlstra
     [not found]       ` <20140418082716.GZ11096@twins.programming.kicks-ass.net>
2014-04-18 17:52         ` Waiman Long
     [not found]         ` <53516672.3010701@hp.com>
2014-04-18 19:05           ` Peter Zijlstra
     [not found]           ` <20140418190519.GA11182@twins.programming.kicks-ass.net>
2014-04-18 21:40             ` Waiman Long
     [not found]             ` <53519BBF.7060506@hp.com>
2014-04-23 14:23               ` Waiman Long
     [not found]               ` <5357CCEF.2000606@hp.com>
2014-04-23 14:56                 ` Konrad Rzeszutek Wilk
     [not found]                 ` <20140423145649.GE2777@phenom.dumpdata.com>
2014-04-23 17:43                   ` Waiman Long
     [not found]                   ` <5357FBDE.4040400@hp.com>
2014-04-23 17:55                     ` Konrad Rzeszutek Wilk
     [not found]                     ` <20140423175535.GB11152@phenom.dumpdata.com>
2014-04-23 22:24                       ` Waiman Long
     [not found]                       ` <53583DA8.4030901@hp.com>
2014-04-23 23:48                         ` Waiman Long
     [not found]   ` <20140417155844.GS11096@twins.programming.kicks-ass.net>
2014-04-17 21:49     ` Waiman Long
     [not found]     ` <53504C4E.8060800@hp.com>
2014-04-18  7:46       ` Ingo Molnar
     [not found]       ` <20140418074616.GB13517@gmail.com>
2014-04-18 16:26         ` Waiman Long
     [not found]         ` <53515232.50905@hp.com>
2014-04-19  9:24           ` Ingo Molnar
     [not found] ` <1397747051-15401-8-git-send-email-Waiman.Long@hp.com>
2014-04-17 16:54   ` [PATCH v9 07/19] qspinlock: Use a simple write to grab the lock, if applicable Peter Zijlstra
2014-04-17 17:23 ` [PATCH v9 00/19] qspinlock: a 4-byte queue spinlock with PV support Konrad Rzeszutek Wilk
     [not found] ` <20140417172246.GA9849@localhost.localdomain>
2014-04-17 17:40   ` Raghavendra K T
2014-04-18  1:50     ` Waiman Long
2014-04-18  1:48   ` Waiman Long
     [not found]   ` <53508474.7010402@hp.com>
2014-04-18 13:18     ` Konrad Rzeszutek Wilk
     [not found]     ` <20140418131807.GD4010@phenom.dumpdata.com>
2014-04-18 17:05       ` Waiman Long
2014-04-27 18:09 ` Raghavendra K T
     [not found] ` <535D47D3.20202@linux.vnet.ibm.com>
2014-05-07 15:00   ` Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397747051-15401-16-git-send-email-Waiman.Long@hp.com \
    --to=waiman.long@hp.com \
    --cc=chegu_vinod@hp.com \
    --cc=david.vrabel@citrix.com \
    --cc=gleb@redhat.com \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=oleg@redhat.com \
    --cc=paolo.bonzini@gmail.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=raghavendra.kt@linux.vnet.ibm.com \
    --cc=scott.norton@hp.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).