xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: [OSSTEST PATCH 1/2] mg-allocate: Fix an "uninitialized value" warning
Date: Thu, 17 Apr 2014 16:14:54 +0100	[thread overview]
Message-ID: <1397747695-9409-1-git-send-email-ian.jackson@eu.citrix.com> (raw)

If $ok is 0, $got_shareix could be undef but would still be used
for Info in the return value.  Initialise it to "x".

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 mg-allocate |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mg-allocate b/mg-allocate
index 00182f7..fc1b394 100755
--- a/mg-allocate
+++ b/mg-allocate
@@ -103,7 +103,7 @@ END
     $resq->execute($restype, $resname);
 
     my $ok= 0;
-    my $got_shareix;
+    my $got_shareix = 'x';
     while (my $candrow= $resq->fetchrow_hashref()) {
         my $desc= "$candrow->{restype}/$candrow->{resname}".
             "/$candrow->{shareix}";
-- 
1.7.10.4

             reply	other threads:[~2014-04-17 15:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-17 15:14 Ian Jackson [this message]
2014-04-17 15:14 ` [OSSTEST PATCH 2/2] preseed_base: drop obsolete references to NetGateway and NetNetmask Ian Jackson
2014-04-22  8:42 ` [OSSTEST PATCH 1/2] mg-allocate: Fix an "uninitialized value" warning Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397747695-9409-1-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).