From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: [OSSTEST PATCH 2/2] preseed_base: drop obsolete references to NetGateway and NetNetmask
Date: Thu, 17 Apr 2014 16:14:55 +0100 [thread overview]
Message-ID: <1397747695-9409-2-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1397747695-9409-1-git-send-email-ian.jackson@eu.citrix.com>
NetGateway and NetNetmask are not honoured (their lines in the preseed
file are commented out) and I'm not aware of anyone who sets them.
They have been there from the dawn of time.
Removing them gets rid of this warning (which appears twice)
Use of uninitialized value in concatenation (.) or string at Osstest/Debian.pm line 432.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
Osstest/Debian.pm | 2 --
1 file changed, 2 deletions(-)
diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm
index 059858e..ab09abb 100644
--- a/Osstest/Debian.pm
+++ b/Osstest/Debian.pm
@@ -459,8 +459,6 @@ d-i partman-crypto/confirm_nooverwrite true
#d-i netcfg/disable_dhcp boolean true
d-i netcfg/get_nameservers string $c{NetNameservers}
-#d-i netcfg/get_netmask string $c{NetNetmask}
-#d-i netcfg/get_gateway string $c{NetGateway}
d-i netcfg/confirm_static boolean true
d-i netcfg/get_domain string $c{TestHostDomain}
d-i netcfg/wireless_wep string
--
1.7.10.4
next prev parent reply other threads:[~2014-04-17 15:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 15:14 [OSSTEST PATCH 1/2] mg-allocate: Fix an "uninitialized value" warning Ian Jackson
2014-04-17 15:14 ` Ian Jackson [this message]
2014-04-22 8:42 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397747695-9409-2-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).