[OSSTEST PATCH 1/2] mg-allocate: Fix an "uninitialized value" warning

[OSSTEST PATCH 1/2] mg-allocate: Fix an "uninitialized value" warning

[Ian Jackson]

If $ok is 0, $got_shareix could be undef but would still be used
for Info in the return value.  Initialise it to "x".

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 mg-allocate |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mg-allocate b/mg-allocate
index 00182f7..fc1b394 100755
--- a/mg-allocate
+++ b/mg-allocate
@@ -103,7 +103,7 @@ END
     $resq->execute($restype, $resname);
 
     my $ok= 0;
-    my $got_shareix;
+    my $got_shareix = 'x';
     while (my $candrow= $resq->fetchrow_hashref()) {
         my $desc= "$candrow->{restype}/$candrow->{resname}".
             "/$candrow->{shareix}";
-- 
1.7.10.4

[OSSTEST PATCH 2/2] preseed_base: drop obsolete references to NetGateway and NetNetmask

[Ian Jackson]

NetGateway and NetNetmask are not honoured (their lines in the preseed
file are commented out) and I'm not aware of anyone who sets them.
They have been there from the dawn of time.

Removing them gets rid of this warning (which appears twice)
 Use of uninitialized value in concatenation (.) or string at Osstest/Debian.pm line 432.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 Osstest/Debian.pm |    2 --
 1 file changed, 2 deletions(-)

diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm
index 059858e..ab09abb 100644
--- a/Osstest/Debian.pm
+++ b/Osstest/Debian.pm
@@ -459,8 +459,6 @@ d-i partman-crypto/confirm_nooverwrite true
 
 #d-i netcfg/disable_dhcp boolean true
 d-i netcfg/get_nameservers string $c{NetNameservers}
-#d-i netcfg/get_netmask string $c{NetNetmask}
-#d-i netcfg/get_gateway string $c{NetGateway}
 d-i netcfg/confirm_static boolean true
 d-i netcfg/get_domain string $c{TestHostDomain}
 d-i netcfg/wireless_wep string
-- 
1.7.10.4

Re: [OSSTEST PATCH 1/2] mg-allocate: Fix an "uninitialized value" warning

[Ian Campbell]

On Thu, 2014-04-17 at 16:14 +0100, Ian Jackson wrote:

Both patches: Acked-by: Ian Campbell <ian.campbell@citrix.com>