From: Julien Grall <julien.grall@linaro.org>
To: xen-devel@lists.xenproject.org
Cc: ian.campbell@citrix.com, HyonYoung Choi <commani@gmail.com>,
Julien Grall <julien.grall@linaro.org>,
tim@xen.org, stefano.stabellini@citrix.com,
Meng Xu <xumengpanda@gmail.com>
Subject: [PATCH] xen/arm: debug-exynos4210: Remove early_uart_init
Date: Tue, 22 Apr 2014 14:41:14 +0100 [thread overview]
Message-ID: <1398174074-2799-1-git-send-email-julien.grall@linaro.org> (raw)
The function early_uart_init contains specific initialization for the
Arndale Board 5250.
Usually U-boot as already setup the UART correctly (ie. clock, baud rate...)
so we don't have to do again.
Futhermore, this code won't work on new platform such as the Arndale Octa.
Signed-off-by: Julien Grall <julien.grall@linaro.org>
Cc: HyonYoung Choi <commani@gmail.com>
Cc: Meng Xu <xumengpanda@gmail.com>
---
xen/arch/arm/Rules.mk | 1 -
xen/arch/arm/arm32/debug-exynos4210.inc | 32 -------------------------------
2 files changed, 33 deletions(-)
diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
index c551afb..8d5624b 100644
--- a/xen/arch/arm/Rules.mk
+++ b/xen/arch/arm/Rules.mk
@@ -53,7 +53,6 @@ EARLY_UART_BASE_ADDRESS := 0x1c090000
endif
ifeq ($(CONFIG_EARLY_PRINTK), exynos5250)
EARLY_PRINTK_INC := exynos4210
-EARLY_PRINTK_INIT_UART := y
EARLY_PRINTK_BAUD := 115200
EARLY_UART_BASE_ADDRESS := 0x12c20000
endif
diff --git a/xen/arch/arm/arm32/debug-exynos4210.inc b/xen/arch/arm/arm32/debug-exynos4210.inc
index 39f2db3..752942d 100644
--- a/xen/arch/arm/arm32/debug-exynos4210.inc
+++ b/xen/arch/arm/arm32/debug-exynos4210.inc
@@ -18,38 +18,6 @@
#include <asm/exynos4210-uart.h>
-/* Exynos 5 UART initialization
- * rb: register which contains the UART base address
- * rc: scratch register 1
- * rd: scratch register 2 */
-.macro early_uart_init rb rc rd
- /* init clock */
- ldr \rc, =0x10020000
- /* select MPLL (800MHz) source clock */
- ldr \rd, [\rc, #0x250]
- and \rd, \rd, #(~(0xf<<8))
- orr \rd, \rd, #(0x6<<8)
- str \rd, [\rc, #0x250]
- /* ratio 800/(7+1) */
- ldr \rd, [\rc, #0x558]
- and \rd, \rd, #(~(0xf<<8))
- orr \rd, \rd, #(0x7<<8)
- str \rd, [\rc, #0x558]
-
- mov \rc, #(100000000 / EARLY_PRINTK_BAUD % 16)
- str \rc, [\rb, #UFRACVAL] /* -> UFRACVAL (Baud divisor fraction) */
- mov \rc, #(100000000 / EARLY_PRINTK_BAUD / 16 - 1)
- str \rc, [\rb, #UBRDIV] /* -> UBRDIV (Baud divisor integer) */
- mov \rc, #3 /* 8n1 */
- str \rc, [\rb, #ULCON] /* -> (Line control) */
- ldr \rc, =UCON_TX_IRQ /* TX IRQMODE */
- str \rc, [\rb, #UCON] /* -> (Control Register) */
- mov \rc, #0x0
- str \rc, [\rb, #UFCON] /* disable FIFO */
- mov \rc, #0x0
- str \rc, [\rb, #UMCON] /* no auto flow control */
-.endm
-
/* Exynos 5 UART wait UART to be ready to transmit
* rb: register which contains the UART base address
* rc: scratch register */
--
1.7.10.4
next reply other threads:[~2014-04-22 13:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 13:41 Julien Grall [this message]
2014-04-23 11:45 ` [PATCH] xen/arm: debug-exynos4210: Remove early_uart_init Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398174074-2799-1-git-send-email-julien.grall@linaro.org \
--to=julien.grall@linaro.org \
--cc=commani@gmail.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xumengpanda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).