From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH V4 04/24] libxl.h: move / add some libxl defbool #define here Date: Tue, 6 May 2014 13:50:43 +0100 Message-ID: <1399380643.3014.117.camel@kazak.uk.xensource.com> References: <1398949101-23320-1-git-send-email-wei.liu2@citrix.com> <1398949101-23320-5-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1398949101-23320-5-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, 2014-05-01 at 13:58 +0100, Wei Liu wrote: > They will be used by both JSON generator and parser so they should be in > header file. > > Signed-off-by: Wei Liu > --- > tools/libxl/libxl.c | 10 +++------- > tools/libxl/libxl.h | 6 ++++++ These are still internal (LIBXL__ indicates this) so I think libxl_internal.h is where they belong. Ian.