From: Wei Liu <wei.liu2@citrix.com>
To: xen-devel@lists.xen.org
Cc: Wei Liu <wei.liu2@citrix.com>,
ian.jackson@eu.citrix.com, ian.campbell@citrix.com
Subject: [PATCH V5 28/32] libxl: store up-to-date domain configuration as we create domain
Date: Tue, 13 May 2014 22:54:10 +0100 [thread overview]
Message-ID: <1400018054-26038-29-git-send-email-wei.liu2@citrix.com> (raw)
In-Reply-To: <1400018054-26038-1-git-send-email-wei.liu2@citrix.com>
This patch utilizes "libxl-json" format and helper functions introduced
in previous patch to store up-to-do domain configuration when creating a
domain.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
tools/libxl/libxl_create.c | 53 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 53 insertions(+)
diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
index da1517c..47859e0 100644
--- a/tools/libxl/libxl_create.c
+++ b/tools/libxl/libxl_create.c
@@ -716,6 +716,7 @@ static void initiate_domain_create(libxl__egc *egc,
int i, ret;
size_t last_devid = -1;
bool pod_enabled = false;
+ libxl_domain_config d_config_saved;
/* convenience aliases */
libxl_domain_config *const d_config = dcs->guest_config;
@@ -724,6 +725,8 @@ static void initiate_domain_create(libxl__egc *egc,
domid = 0;
+ libxl_domain_config_init(&d_config_saved);
+
if (d_config->c_info.ssid_label) {
char *s = d_config->c_info.ssid_label;
ret = libxl_flask_context_to_sid(ctx, s, strlen(s),
@@ -800,6 +803,8 @@ static void initiate_domain_create(libxl__egc *egc,
goto error_out;
}
+ libxl_domain_config_copy(ctx, &d_config_saved, d_config);
+
ret = libxl__domain_create_info_setdefault(gc, &d_config->c_info);
if (ret) goto error_out;
@@ -814,6 +819,16 @@ static void initiate_domain_create(libxl__egc *egc,
dcs->guest_domid = domid;
dcs->dmss.dm.guest_domid = 0; /* means we haven't spawned */
+ /* At this point we've got domid and UUID, store configuration */
+ ret = libxl_store_domain_configuration(ctx, domid, &d_config_saved);
+ if (ret) {
+ LIBXL__LOG(ctx, LIBXL__LOG_ERROR, "cannot store domain configuration: %d",
+ ret);
+ ret = ERROR_FAIL;
+ goto error_out;
+ }
+ libxl_domain_config_dispose(&d_config_saved);
+
ret = libxl__domain_build_info_setdefault(gc, &d_config->b_info);
if (ret) goto error_out;
@@ -874,6 +889,7 @@ static void initiate_domain_create(libxl__egc *egc,
return;
error_out:
+ libxl_domain_config_dispose(&d_config_saved);
assert(ret);
domcreate_complete(egc, dcs, ret);
}
@@ -1356,6 +1372,24 @@ error_out:
domcreate_complete(egc, dcs, ret);
}
+static void update_domain_config(libxl_ctx *ctx,
+ libxl_domain_config *dst,
+ const libxl_domain_config *src)
+{
+ int i;
+
+ /* update network interface information */
+ for (i = 0; i < src->num_nics; i++)
+ libxl_mac_copy(ctx, &dst->nics[i].mac, &src->nics[i].mac);
+
+ /* update vtpm information */
+ for (i = 0; i < src->num_vtpms; i++)
+ libxl_uuid_copy(ctx, &dst->vtpms[i].uuid, &src->vtpms[i].uuid);
+
+ /* update guest UUID */
+ libxl_uuid_copy(ctx, &dst->c_info.uuid, &src->c_info.uuid);
+}
+
static void domcreate_complete(libxl__egc *egc,
libxl__domain_create_state *dcs,
int rc)
@@ -1366,6 +1400,25 @@ static void domcreate_complete(libxl__egc *egc,
if (!rc && d_config->b_info.exec_ssidref)
rc = xc_flask_relabel_domain(CTX->xch, dcs->guest_domid, d_config->b_info.exec_ssidref);
+ if (!rc) {
+ libxl_domain_config d_config_saved;
+
+ libxl_domain_config_init(&d_config_saved);
+ rc = libxl_load_domain_configuration(CTX, dcs->guest_domid,
+ &d_config_saved);
+ if (rc) {
+ LOG(ERROR, "cannot load domain configuration: %d", rc);
+ goto out;
+ }
+ update_domain_config(CTX, &d_config_saved, d_config);
+ rc = libxl_store_domain_configuration(CTX, dcs->guest_domid,
+ &d_config_saved);
+ if (rc)
+ LOG(ERROR, "cannot store domain configuration: %d", rc);
+ libxl_domain_config_dispose(&d_config_saved);
+ }
+
+out:
if (rc) {
if (dcs->guest_domid) {
dcs->dds.ao = ao;
--
1.7.10.4
next prev parent reply other threads:[~2014-05-13 21:54 UTC|newest]
Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 21:53 [PATCH V5 00/32] JSON infrastructure, new "xl-json" format and domain configuration synchronization Wei Liu
2014-05-13 21:53 ` [PATCH V5 01/32] libxl: make cpupool_qualifier_to_cpupoolid a library function Wei Liu
2014-05-15 16:28 ` Ian Campbell
2014-05-20 14:47 ` Ian Jackson
2014-05-20 17:24 ` Wei Liu
2014-05-21 8:27 ` Ian Campbell
2014-05-21 8:37 ` Comments on LIBXL_HAVE_* defines (Was: Re: [PATCH V5 01/32] libxl: make cpupool_qualifier_to_cpupoolid a library function) Ian Campbell
2014-05-22 9:35 ` George Dunlap
2014-05-27 23:04 ` Wei Liu
2014-05-13 21:53 ` [PATCH V5 02/32] xl / libxl: push parsing of SSID and CPU pool ID down to libxl Wei Liu
2014-05-15 16:38 ` Ian Campbell
2014-05-15 17:11 ` Wei Liu
2014-05-13 21:53 ` [PATCH V5 03/32] xl / libxl: push VCPU affinity pinning " Wei Liu
2014-05-15 0:59 ` Dario Faggioli
2014-05-15 9:24 ` Wei Liu
2014-05-15 15:31 ` Dario Faggioli
2014-05-15 15:37 ` Wei Liu
2014-05-15 16:45 ` Ian Campbell
2014-05-15 17:06 ` Wei Liu
2014-05-15 17:19 ` Wei Liu
2014-05-16 9:51 ` Ian Campbell
2014-05-16 8:10 ` Dario Faggioli
2014-05-16 9:57 ` Ian Campbell
2014-05-16 10:15 ` Wei Liu
2014-05-16 10:28 ` Ian Campbell
2014-05-13 21:53 ` [PATCH V5 04/32] libxl: libxl_uuid_copy now taks a ctx argument Wei Liu
2014-05-15 16:51 ` Ian Campbell
2014-05-15 17:13 ` Wei Liu
2014-05-16 9:46 ` Ian Campbell
2014-05-16 10:18 ` Wei Liu
2014-05-16 10:30 ` Ian Campbell
2014-05-16 11:17 ` Wei Liu
2014-05-16 11:21 ` Wei Liu
2014-05-16 11:23 ` Ian Campbell
2014-05-16 11:28 ` Wei Liu
2014-05-16 11:31 ` Ian Campbell
2014-05-13 21:53 ` [PATCH V5 05/32] xl: remove parsing of "vncviewer" option in xl domain config file Wei Liu
2014-05-20 12:44 ` Ian Campbell
2014-05-13 21:53 ` [PATCH V5 06/32] libxl: fix memory leak in libxl_cpuid_dispose Wei Liu
2014-05-13 21:53 ` [PATCH V5 07/32] libxl.h: document the paradigm of using libxl types Wei Liu
2014-05-20 12:49 ` Ian Campbell
2014-05-20 14:54 ` Ian Jackson
2014-05-20 15:02 ` Ian Campbell
2014-05-13 21:53 ` [PATCH V5 08/32] libxl.h: document libxl_<type>_to_json Wei Liu
2014-05-20 12:50 ` Ian Campbell
2014-05-13 21:53 ` [PATCH V5 09/32] libxl_internal.h: move / add some libxl defbool #define here Wei Liu
2014-05-20 12:51 ` Ian Campbell
2014-05-13 21:53 ` [PATCH V5 10/32] libxl: fix JSON generator for uint64_t Wei Liu
2014-05-20 12:55 ` Ian Campbell
2014-05-20 13:15 ` Wei Liu
2014-05-13 21:53 ` [PATCH V5 11/32] libxl IDL: rename json_fn to json_gen_fn Wei Liu
2014-05-13 21:53 ` [PATCH V5 12/32] libxl_json: introduce libxl__object_from_json Wei Liu
2014-05-13 21:53 ` [PATCH V5 13/32] libxl_internal: make JSON_* types a bit-field Wei Liu
2014-05-13 21:53 ` [PATCH V5 14/32] libxl_internal.h: introduce libxl__json_object_is_{null, number, double} Wei Liu
2014-05-13 21:53 ` [PATCH V5 15/32] libxl_internal.h: introduce libxl__json_object_get_number Wei Liu
2014-05-20 12:56 ` Ian Campbell
2014-05-20 15:11 ` Ian Campbell
2014-05-13 21:53 ` [PATCH V5 16/32] libxl_json: introduce parser functions for builtin types Wei Liu
2014-05-13 21:53 ` [PATCH V5 17/32] libxl_json: allow basic JSON type objects generation Wei Liu
2014-05-13 21:54 ` [PATCH V5 18/32] libxl/gentypes.py: special-case KeyedUnion map handle generation Wei Liu
2014-05-20 13:26 ` Ian Campbell
2014-05-13 21:54 ` [PATCH V5 19/32] libxl/gentypes.py: don't generate default values Wei Liu
2014-05-20 13:29 ` Ian Campbell
2014-05-20 17:17 ` Wei Liu
2014-05-21 8:31 ` Ian Campbell
2014-05-13 21:54 ` [PATCH V5 20/32] libxl IDL: generate code to parse libxl__json_object to libxl_FOO struct Wei Liu
2014-05-20 13:35 ` Ian Campbell
2014-06-01 17:43 ` Wei Liu
2014-05-13 21:54 ` [PATCH V5 21/32] libxl/gentest.py: test JSON parser Wei Liu
2014-05-13 21:54 ` [PATCH V5 22/32] libxl: introduce libxl_key_value_list_length Wei Liu
2014-05-20 13:36 ` Ian Campbell
2014-05-13 21:54 ` [PATCH V5 23/32] libxl: introduce libxl_cpuid_policy_list_length Wei Liu
2014-05-20 13:36 ` Ian Campbell
2014-05-13 21:54 ` [PATCH V5 24/32] libxl: copy function for builtin types Wei Liu
2014-05-20 13:39 ` Ian Campbell
2014-05-13 21:54 ` [PATCH V5 25/32] libxl IDL: generate deep copy functions Wei Liu
2014-05-20 13:42 ` Ian Campbell
2014-05-13 21:54 ` [PATCH V5 26/32] libxl/gentest.py: test " Wei Liu
2014-05-13 21:54 ` [PATCH V5 27/32] libxl: libxl-json format and load/store configuration functions Wei Liu
2014-05-20 14:03 ` Ian Campbell
2014-06-01 18:41 ` Wei Liu
2014-06-02 16:19 ` Ian Campbell
2014-06-02 19:56 ` Wei Liu
2014-05-20 15:01 ` Ian Jackson
2014-06-01 18:46 ` Wei Liu
2014-05-13 21:54 ` Wei Liu [this message]
2014-05-20 14:12 ` [PATCH V5 28/32] libxl: store up-to-date domain configuration as we create domain Ian Campbell
2014-06-01 19:02 ` Wei Liu
2014-06-02 16:21 ` Ian Campbell
2014-05-20 15:04 ` Ian Jackson
2014-05-13 21:54 ` [PATCH V5 29/32] xl: use "libxl-json" format Wei Liu
2014-05-20 14:23 ` Ian Campbell
2014-05-20 15:13 ` Ian Jackson
2014-05-20 15:31 ` Ian Campbell
2014-06-01 19:37 ` Wei Liu
2014-06-02 16:30 ` Ian Campbell
2014-06-03 10:02 ` Wei Liu
2014-06-03 10:34 ` Ian Campbell
2014-05-20 15:11 ` Ian Jackson
2014-05-20 15:15 ` Ian Campbell
2014-05-20 15:39 ` Ian Jackson
2014-06-01 19:18 ` Wei Liu
2014-06-01 19:07 ` Wei Liu
2014-06-02 16:23 ` Ian Campbell
2014-05-13 21:54 ` [PATCH V5 30/32] libxl: consider force removal of device successful Wei Liu
2014-05-20 14:26 ` Ian Campbell
2014-06-01 19:44 ` Wei Liu
2014-05-20 15:15 ` Ian Jackson
2014-06-01 19:46 ` Wei Liu
2014-05-13 21:54 ` [PATCH V5 31/32] libxl: update domain configuration when updating memory targets Wei Liu
2014-05-20 14:32 ` Ian Campbell
2014-06-01 20:00 ` Wei Liu
2014-05-20 15:21 ` Ian Jackson
2014-05-20 15:35 ` Ian Campbell
2014-05-20 15:44 ` Ian Jackson
2014-05-20 15:55 ` Ian Campbell
2014-05-20 16:03 ` Ian Jackson
2014-05-21 8:38 ` Ian Campbell
2014-06-01 20:51 ` Wei Liu
2014-06-01 20:22 ` Wei Liu
2014-06-02 16:32 ` Ian Campbell
2014-05-13 21:54 ` [PATCH V5 32/32] libxl: synchronize configuration when we plug / unplug device Wei Liu
2014-05-20 14:35 ` Ian Campbell
2014-05-20 15:33 ` Ian Jackson
2014-06-01 20:57 ` Wei Liu
2014-06-02 16:33 ` Ian Campbell
2014-05-21 10:18 ` [PATCH V5 00/32] JSON infrastructure, new "xl-json" format and domain configuration synchronization Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400018054-26038-29-git-send-email-wei.liu2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).