From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: [PATCH 1/4] x86/nmi: remove spurious local_irq_enable from check_nmi_watchdog() Date: Wed, 14 May 2014 13:58:16 +0100 Message-ID: <1400072299-2285-2-git-send-email-david.vrabel@citrix.com> References: <1400072299-2285-1-git-send-email-david.vrabel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WkYlp-0001y5-GN for xen-devel@lists.xenproject.org; Wed, 14 May 2014 12:58:53 +0000 In-Reply-To: <1400072299-2285-1-git-send-email-david.vrabel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: Keir Fraser , David Vrabel , Jan Beulich List-Id: xen-devel@lists.xenproject.org All callers of check_nmi_watchdog() already have local irqs enabled so remove the unpaired local_irq_enable(). Signed-off-by: David Vrabel --- xen/arch/x86/nmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c index 526020b..18d3820 100644 --- a/xen/arch/x86/nmi.c +++ b/xen/arch/x86/nmi.c @@ -126,7 +126,6 @@ int __init check_nmi_watchdog (void) for_each_online_cpu ( cpu ) prev_nmi_count[cpu] = nmi_count(cpu); - local_irq_enable(); /* Wait for 10 ticks. Busy-wait on all CPUs: the LAPIC counter that * the NMI watchdog uses only runs while the core's not halted */ -- 1.7.10.4