xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Keir Fraser <keir@xen.org>,
	David Vrabel <david.vrabel@citrix.com>,
	Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 2/4] x86/nmi: enable local irqs in wait_for_nmis()
Date: Wed, 14 May 2014 13:58:17 +0100	[thread overview]
Message-ID: <1400072299-2285-3-git-send-email-david.vrabel@citrix.com> (raw)
In-Reply-To: <1400072299-2285-1-git-send-email-david.vrabel@citrix.com>

wait_for_nmis() runs for 10 ticks with local interrupts disabled,
which is quite a long time.

We occasionally see serial output (particularly with virtual serial
ports such as HP's iLO) stopping on the "Testing for NMIs" line.  We
think the long delay in handling the serial interrupt is the cause.

Signed-off-by: David Vrabel <david.vrabel@citrix.com>
---
 xen/arch/x86/nmi.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c
index 18d3820..07488da 100644
--- a/xen/arch/x86/nmi.c
+++ b/xen/arch/x86/nmi.c
@@ -111,7 +111,14 @@ int nmi_active;
 
 static void __init wait_for_nmis(void *p)
 {
+    unsigned long flags;
+
+    local_save_flags(flags);
+    local_irq_enable();
+
     mdelay((10*1000)/nmi_hz); /* wait 10 ticks */
+
+    local_irq_restore(flags);
 }
 
 int __init check_nmi_watchdog (void)
-- 
1.7.10.4

  parent reply	other threads:[~2014-05-14 12:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14 12:58 [PATCH 0/4] x86/nmi: improve NMI watchdog test David Vrabel
2014-05-14 12:58 ` [PATCH 1/4] x86/nmi: remove spurious local_irq_enable from check_nmi_watchdog() David Vrabel
2014-05-14 13:25   ` Jan Beulich
2014-05-14 13:31     ` David Vrabel
2014-05-14 13:53       ` Jan Beulich
2014-05-15 11:40   ` Tim Deegan
2014-05-14 12:58 ` David Vrabel [this message]
2014-05-14 13:57   ` [PATCH 2/4] x86/nmi: enable local irqs in wait_for_nmis() Jan Beulich
2014-05-14 14:38     ` David Vrabel
2014-05-14 14:45       ` Jan Beulich
2014-05-15 11:55     ` Tim Deegan
2014-05-14 12:58 ` [PATCH 3/4] x86/nmi: wait for all CPUs in check_nmi_watchdog() David Vrabel
2014-05-14 13:59   ` Jan Beulich
2014-05-14 14:09     ` David Vrabel
2014-05-14 14:33       ` Jan Beulich
2014-05-14 14:09     ` Andrew Cooper
2014-05-15 11:47   ` Tim Deegan
2014-05-14 12:58 ` [PATCH 4/4] x86/nmi: be less verbose when testing the NMI watchdog David Vrabel
2014-05-15 11:48   ` Tim Deegan
2014-05-14 13:03 ` [PATCH 0/4] x86/nmi: improve NMI watchdog test Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400072299-2285-3-git-send-email-david.vrabel@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).