From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: [PATCH 2/4] x86/nmi: enable local irqs in wait_for_nmis() Date: Wed, 14 May 2014 13:58:17 +0100 Message-ID: <1400072299-2285-3-git-send-email-david.vrabel@citrix.com> References: <1400072299-2285-1-git-send-email-david.vrabel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WkYlq-0001yE-5B for xen-devel@lists.xenproject.org; Wed, 14 May 2014 12:58:54 +0000 In-Reply-To: <1400072299-2285-1-git-send-email-david.vrabel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: Keir Fraser , David Vrabel , Jan Beulich List-Id: xen-devel@lists.xenproject.org wait_for_nmis() runs for 10 ticks with local interrupts disabled, which is quite a long time. We occasionally see serial output (particularly with virtual serial ports such as HP's iLO) stopping on the "Testing for NMIs" line. We think the long delay in handling the serial interrupt is the cause. Signed-off-by: David Vrabel --- xen/arch/x86/nmi.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c index 18d3820..07488da 100644 --- a/xen/arch/x86/nmi.c +++ b/xen/arch/x86/nmi.c @@ -111,7 +111,14 @@ int nmi_active; static void __init wait_for_nmis(void *p) { + unsigned long flags; + + local_save_flags(flags); + local_irq_enable(); + mdelay((10*1000)/nmi_hz); /* wait 10 ticks */ + + local_irq_restore(flags); } int __init check_nmi_watchdog (void) -- 1.7.10.4