From: David Vrabel <david.vrabel@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Keir Fraser <keir@xen.org>,
David Vrabel <david.vrabel@citrix.com>,
Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 3/4] x86/nmi: wait for all CPUs in check_nmi_watchdog()
Date: Wed, 14 May 2014 13:58:18 +0100 [thread overview]
Message-ID: <1400072299-2285-4-git-send-email-david.vrabel@citrix.com> (raw)
In-Reply-To: <1400072299-2285-1-git-send-email-david.vrabel@citrix.com>
The counting of a CPUs NMIs in check_nmi_watchdog() is only reliable
if all CPUs have been spinning for 5 or more ticks. There may be
delays in waking other CPUs from deep power states that can mean that
when the counts are checked CPUs haven't run for long enough.
Fix this by waiting for all CPUs to have delayed in wait_for_nmis().
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
---
xen/arch/x86/nmi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c
index 07488da..4f330d8 100644
--- a/xen/arch/x86/nmi.c
+++ b/xen/arch/x86/nmi.c
@@ -136,9 +136,7 @@ int __init check_nmi_watchdog (void)
/* Wait for 10 ticks. Busy-wait on all CPUs: the LAPIC counter that
* the NMI watchdog uses only runs while the core's not halted */
- if ( nmi_watchdog == NMI_LOCAL_APIC )
- smp_call_function(wait_for_nmis, NULL, 0);
- wait_for_nmis(NULL);
+ on_selected_cpus(&cpu_online_map, wait_for_nmis, NULL, 1);
for_each_online_cpu ( cpu )
{
--
1.7.10.4
next prev parent reply other threads:[~2014-05-14 12:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 12:58 [PATCH 0/4] x86/nmi: improve NMI watchdog test David Vrabel
2014-05-14 12:58 ` [PATCH 1/4] x86/nmi: remove spurious local_irq_enable from check_nmi_watchdog() David Vrabel
2014-05-14 13:25 ` Jan Beulich
2014-05-14 13:31 ` David Vrabel
2014-05-14 13:53 ` Jan Beulich
2014-05-15 11:40 ` Tim Deegan
2014-05-14 12:58 ` [PATCH 2/4] x86/nmi: enable local irqs in wait_for_nmis() David Vrabel
2014-05-14 13:57 ` Jan Beulich
2014-05-14 14:38 ` David Vrabel
2014-05-14 14:45 ` Jan Beulich
2014-05-15 11:55 ` Tim Deegan
2014-05-14 12:58 ` David Vrabel [this message]
2014-05-14 13:59 ` [PATCH 3/4] x86/nmi: wait for all CPUs in check_nmi_watchdog() Jan Beulich
2014-05-14 14:09 ` David Vrabel
2014-05-14 14:33 ` Jan Beulich
2014-05-14 14:09 ` Andrew Cooper
2014-05-15 11:47 ` Tim Deegan
2014-05-14 12:58 ` [PATCH 4/4] x86/nmi: be less verbose when testing the NMI watchdog David Vrabel
2014-05-15 11:48 ` Tim Deegan
2014-05-14 13:03 ` [PATCH 0/4] x86/nmi: improve NMI watchdog test Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400072299-2285-4-git-send-email-david.vrabel@citrix.com \
--to=david.vrabel@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).