From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [RFC v3 2/6] xen/arm: Add save/restore support for
 ARM GIC V2
Date: Fri, 16 May 2014 08:36:24 +0100
Message-ID: <1400225784.29121.8.camel@dagon.hellion.org.uk>
References: <1399583908-21755-1-git-send-email-w1.huang@samsung.com>
	<1399583908-21755-3-git-send-email-w1.huang@samsung.com>
	<5374F623.6040801@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5374F623.6040801@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: Wei Huang <w1.huang@samsung.com>, keir@xen.org, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, tim@xen.org, jaeyong.yoo@samsung.com, xen-devel@lists.xen.org, jbeulich@suse.com, ian.jackson@eu.citrix.com, yjhyun.yoo@samsung.com
List-Id: xen-devel@lists.xenproject.org

On Thu, 2014-05-15 at 18:15 +0100, Julien Grall wrote:
> Hi Wei,
> 
> On 05/08/2014 10:18 PM, Wei Huang wrote:
> > +struct hvm_arm_gich_v2
> > +{
> > +    uint32_t gic_hcr;
> > +    uint32_t gic_vmcr;
> > +    uint32_t gic_apr;
> > +    uint32_t gic_lr[64];
> > +    uint64_t event_mask;
> 
> FYI, the field event_mask as been dropped in xen upstream [1]
> 
> So you don't need to save it.

Quite apart from it's existence in upstream Xen it is not and never was
an architectural field and so shouldn't ever be saved. It's presence or
absence in some struct inside Xen has no impact on that.

Ian.