From: Dario Faggioli <dario.faggioli@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: KeirFraser <keir@xen.org>,
George Dunlap <george.dunlap@eu.citrix.com>,
AndrewCooper <Andrew.Cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 8/9] xl: enable for specifying node-affinity in the config file
Date: Wed, 28 May 2014 17:55:43 +0100 [thread overview]
Message-ID: <1401296143.7504.66.camel@Abyss> (raw)
In-Reply-To: <1401292082.10916.43.camel@kazak.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 1545 bytes --]
On Wed, 2014-05-28 at 16:48 +0100, Ian Campbell wrote:
> On Wed, 2014-05-28 at 01:42 +0100, Dario Faggioli wrote:
> > in a similar way to how it is possible to specify vcpu-affinity.
>
> $subject says node-affinity, but the body all seems to be dealing with
> vcpu affinity. (the "for" in $subj is redundant btw)
>
Ok, thanks (for the "for" thing).
> OK, so having read a bit closer it seems that the node affinity is
> derived from the vcpu soft affinity, which makes sense. So the thing you
> actually specify is vcpu soft affinity which then gets turned into a
> node aff'ty internally. This would be better expressed in those terms in
> the commit message I think.
>
> Before I dig too deeply into the code can you confirm that I am grasping
> the correct end of the stick.
>
You are. Actually, the 'node-affinity' in the subject must be a remnant
for one of the first versions of the series that neither I or the
various rounds of review noticed. :-(
Anyway, it is true that the vcpu soft affinity may affect node affinity,
but this patch is all about "allowing the user to specify soft affinity
in the VM config file", and certainly both the subject and the commit
message should say so more clearly. I'll make it that way.
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-05-28 16:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 0:42 [PATCH v6 0/9] Implement vcpu soft affinity for credit1 Dario Faggioli
2014-05-28 0:42 ` [PATCH v6 1/9] xen: sched: rename v->cpu_affinity into v->cpu_hard_affinity Dario Faggioli
2014-05-28 7:28 ` Jan Beulich
2014-05-28 0:42 ` [PATCH v6 2/9] xen: sched: introduce soft-affinity and use it instead d->node-affinity Dario Faggioli
2014-05-28 7:33 ` Jan Beulich
2014-05-28 15:50 ` Dario Faggioli
2014-06-02 14:40 ` George Dunlap
2014-05-28 0:42 ` [PATCH v6 3/9] xen: derive NUMA node affinity from hard and soft CPU affinity Dario Faggioli
2014-05-28 7:36 ` Jan Beulich
2014-05-28 0:42 ` [PATCH v6 4/9] xen/libxc: sched: DOMCTL_*vcpuaffinity works with hard and soft affinity Dario Faggioli
2014-05-28 7:40 ` Jan Beulich
2014-05-28 15:09 ` Ian Campbell
2014-05-28 0:42 ` [PATCH v6 5/9] libxc: get and set soft and hard affinity Dario Faggioli
2014-05-28 0:42 ` [PATCH v6 6/9] libxl: get and set soft affinity Dario Faggioli
2014-05-28 15:13 ` Ian Campbell
2014-05-28 15:15 ` Dario Faggioli
2014-05-28 15:23 ` Ian Campbell
2014-06-05 12:59 ` Dario Faggioli
2014-06-06 8:46 ` Ian Campbell
2014-06-06 22:11 ` Dario Faggioli
2014-05-28 0:42 ` [PATCH v6 7/9] xl: enable getting and setting soft Dario Faggioli
2014-05-28 15:33 ` Ian Campbell
2014-05-28 16:01 ` Dario Faggioli
2014-06-02 15:20 ` George Dunlap
2014-05-28 0:42 ` [PATCH v6 8/9] xl: enable for specifying node-affinity in the config file Dario Faggioli
2014-05-28 15:48 ` Ian Campbell
2014-05-28 16:55 ` Dario Faggioli [this message]
2014-05-28 0:42 ` [PATCH v6 9/9] libxl: automatic NUMA placement affects soft affinity Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401296143.7504.66.camel@Abyss \
--to=dario.faggioli@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=george.dunlap@eu.citrix.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).