From: Feng Wu <feng.wu@intel.com>
To: xen-devel@lists.xen.org
Cc: Feng Wu <feng.wu@intel.com>,
ian.campbell@citrix.com, andrew.cooper3@citrix.com, tim@xen.org,
keir.xen@gmail.com, stefano.stabellini@citrix.com,
JBeulich@suse.com, boris.ostrovsky@oracle.com
Subject: [PATCH v3 3/5] x86: Make set_nmi_callback return the old nmi callback
Date: Fri, 30 May 2014 16:56:23 +0800 [thread overview]
Message-ID: <1401440185-11266-4-git-send-email-feng.wu@intel.com> (raw)
In-Reply-To: <1401440185-11266-1-git-send-email-feng.wu@intel.com>
This patch makes set_nmi_callback return the old nmi callback, so
we can set it back later.
Signed-off-by: Feng Wu <feng.wu@intel.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
xen/arch/x86/traps.c | 4 +++-
xen/include/asm-x86/nmi.h | 4 ++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index 1722912..171cff0 100644
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -3322,9 +3322,11 @@ void do_nmi(struct cpu_user_regs *regs)
}
}
-void set_nmi_callback(nmi_callback_t callback)
+nmi_callback_t set_nmi_callback(nmi_callback_t callback)
{
+ nmi_callback_t old_nmi_callback = nmi_callback;
nmi_callback = callback;
+ return old_nmi_callback;
}
void unset_nmi_callback(void)
diff --git a/xen/include/asm-x86/nmi.h b/xen/include/asm-x86/nmi.h
index 98b5e04..58cd9a1 100644
--- a/xen/include/asm-x86/nmi.h
+++ b/xen/include/asm-x86/nmi.h
@@ -15,9 +15,9 @@ typedef int (*nmi_callback_t)(struct cpu_user_regs *regs, int cpu);
* set_nmi_callback
*
* Set a handler for an NMI. Only one handler may be
- * set. Return 1 if the NMI was handled.
+ * set. Return the old nmi callback handler.
*/
-void set_nmi_callback(nmi_callback_t callback);
+nmi_callback_t set_nmi_callback(nmi_callback_t callback);
/**
* unset_nmi_callback
--
1.8.3.1
next prev parent reply other threads:[~2014-05-30 8:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 8:56 [PATCH v3 0/5] x86: Use alternative mechanism to define CLAC/STAC Feng Wu
2014-05-30 8:56 ` [PATCH v3 1/5] Use __stringify() as the only method for performing preprocessor stringificaion Feng Wu
2014-05-30 11:35 ` Jan Beulich
2014-06-03 0:42 ` Wu, Feng
2014-06-03 12:37 ` Wu, Feng
2014-06-03 13:05 ` Jan Beulich
2014-06-03 13:13 ` Wu, Feng
2014-05-30 8:56 ` [PATCH v3 2/5] x86: Add definitions for NOP operation Feng Wu
2014-05-30 8:56 ` Feng Wu [this message]
2014-05-30 8:56 ` [PATCH v3 4/5] x86: Port the basic alternative mechanism from Linux to Xen Feng Wu
2014-06-03 10:00 ` Jan Beulich
2014-06-03 10:13 ` Wu, Feng
2014-06-03 10:25 ` Jan Beulich
2014-06-03 10:35 ` Wu, Feng
2014-06-03 10:51 ` Jan Beulich
2014-06-03 11:42 ` Wu, Feng
2014-06-03 11:59 ` Jan Beulich
2014-06-03 13:05 ` Wu, Feng
2014-06-03 13:10 ` Jan Beulich
2014-06-03 13:27 ` Wu, Feng
2014-05-30 8:56 ` [PATCH v3 5/5] x86: Use alternative mechanism to define CLAC/STAC Feng Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401440185-11266-4-git-send-email-feng.wu@intel.com \
--to=feng.wu@intel.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=keir.xen@gmail.com \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).