From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com,
ian.campbell@citrix.com
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [PATCH v1 1/2] libxl: give pciback a chance to do its teardown before we reset the device.
Date: Wed, 4 Jun 2014 09:33:32 -0400 [thread overview]
Message-ID: <1401888813-30987-2-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1401888813-30987-1-git-send-email-konrad.wilk@oracle.com>
We try to reset the device before we signal the pciback that
the device is no longer to be used by the guest. As such
we should give the pciback (or QEMU) a chance first to
some cleanup before we deploy the sledghammer approach
of resetting the device.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
tools/libxl/libxl_pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
index 44d0453..5a7cc9e 100644
--- a/tools/libxl/libxl_pci.c
+++ b/tools/libxl/libxl_pci.c
@@ -1260,6 +1260,8 @@ skip1:
abort();
}
out:
+ libxl__device_pci_remove_xenstore(gc, domid, pcidev);
+
/* don't do multiple resets while some functions are still passed through */
if ( (pcidev->vdevfn & 0x7) == 0 ) {
libxl__device_pci_reset(gc, pcidev->domain, pcidev->bus, pcidev->dev, pcidev->func);
@@ -1277,8 +1279,6 @@ out:
libxl__device_pci_remove_common(gc, stubdomid, &pcidev_s, force);
}
- libxl__device_pci_remove_xenstore(gc, domid, pcidev);
-
rc = 0;
out_fail:
free(assigned);
--
1.9.3
next prev parent reply other threads:[~2014-06-04 13:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 13:33 [PATCH v1] Misc fixes to libxl (v1) Konrad Rzeszutek Wilk
2014-06-04 13:33 ` Konrad Rzeszutek Wilk [this message]
2014-06-05 10:58 ` [PATCH v1 1/2] libxl: give pciback a chance to do its teardown before we reset the device Ian Campbell
2014-06-05 17:41 ` Konrad Rzeszutek Wilk
2014-06-05 17:56 ` Ian Jackson
2014-06-06 9:07 ` Ian Campbell
2014-06-04 13:33 ` [PATCH v1 2/2] libxl: vcpu-set - allow to decrease vcpu count on overcommitted guests (v2) Konrad Rzeszutek Wilk
2014-06-05 11:02 ` Ian Campbell
2014-06-05 17:44 ` Konrad Rzeszutek Wilk
2014-06-06 9:07 ` Ian Campbell
2015-02-02 20:47 ` Konrad Rzeszutek Wilk
2015-02-02 20:47 ` [PATCH 1/4] libxl: vcpuset: Return error values Konrad Rzeszutek Wilk
2015-02-03 11:29 ` Ian Jackson
2015-02-02 20:47 ` [PATCH 2/4] libxl: vcpuset: Check max_vcpus argument against the maximum number of vCPUs the guest has set Konrad Rzeszutek Wilk
2015-02-03 15:11 ` Ian Jackson
2015-02-03 15:45 ` Konrad Rzeszutek Wilk
2015-03-11 10:56 ` Ian Campbell
2015-02-02 20:47 ` [PATCH 3/4] libxl: vcpuset: Remove useless limit on max_vcpus Konrad Rzeszutek Wilk
2015-02-02 20:47 ` [PATCH 4/4] libxl: vcpu-set - allow to decrease vcpu count on overcommitted guests (v3) Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401888813-30987-2-git-send-email-konrad.wilk@oracle.com \
--to=konrad.wilk@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).