From: Ian Campbell <ian.campbell@citrix.com>
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@eu.citrix.com,
ian.jackson@eu.citrix.com
Subject: Re: [PATCH v1 4/5] xentrace: Use xc_cpumask_t when setting the cpu mask (v4)
Date: Thu, 5 Jun 2014 13:55:09 +0100 [thread overview]
Message-ID: <1401972909.15729.67.camel@hastur.hellion.org.uk> (raw)
In-Reply-To: <538F50F1.3090308@eu.citrix.com>
On Wed, 2014-06-04 at 18:01 +0100, George Dunlap wrote:
> On 06/04/2014 02:44 PM, Konrad Rzeszutek Wilk wrote:
> > Instead of using an uint32_t. This requires us using the
> > xc_tbuf_set_cpu_mask_array API call that can handle variable
> > sized uint8_t arrays.
> >
> > As this is just swapping over to use the new API, the existing
> > shortcomming when using -c is still present: it can only do up
> > to 32 CPUs.
> >
> > But if '-c' has not been specified it will construct an CPU mask
> > for the full amount of physical CPUs.
> >
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > [v2: Changes per Boris's and Daniel's review]
> > [v3,v4: Change per Boris's review]
>
> Looks good (saving the reviewed-by because
> I think this should probably be merged into patch 2).
I agree.
next prev parent reply other threads:[~2014-06-05 12:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 13:44 [PATCH v1] Misc fixes to xentrace, docs, and add code to support selective human CPU selection Konrad Rzeszutek Wilk
2014-06-04 13:44 ` [PATCH v1 1/5] docs: xentrace manpage Konrad Rzeszutek Wilk
2014-06-04 16:25 ` George Dunlap
2014-06-05 13:31 ` Ian Campbell
2014-06-04 13:44 ` [PATCH v1 2/5] libxc/trace: Add xc_tbuf_set_cpu_mask_array a variant of xc_tbuf_set_cpu_mask (v3) Konrad Rzeszutek Wilk
2014-06-04 16:45 ` George Dunlap
2014-06-04 16:52 ` George Dunlap
2014-06-13 17:52 ` Konrad Rzeszutek Wilk
2014-06-05 12:49 ` Ian Campbell
2014-06-13 18:30 ` Konrad Rzeszutek Wilk
2014-06-04 13:44 ` [PATCH v1 3/5] libxc/trace: Fix style Konrad Rzeszutek Wilk
2014-06-04 16:46 ` George Dunlap
2014-06-04 13:44 ` [PATCH v1 4/5] xentrace: Use xc_cpumask_t when setting the cpu mask (v4) Konrad Rzeszutek Wilk
2014-06-04 17:01 ` George Dunlap
2014-06-05 12:55 ` Ian Campbell [this message]
2014-06-04 13:44 ` [PATCH v1 5/5] xentrace: Implement cpu mask range parsing of human values (-C) Konrad Rzeszutek Wilk
2014-06-04 17:18 ` George Dunlap
2014-06-13 19:57 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401972909.15729.67.camel@hastur.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).