From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v8 06/14] arch/x86: warn if to-be-removed mapping does not exist Date: Thu, 5 Jun 2014 15:06:37 +0100 Message-ID: <1401977197.15729.102.camel@hastur.hellion.org.uk> References: <1401015115-7610-1-git-send-email-avanzini.arianna@gmail.com> <1401015115-7610-7-git-send-email-avanzini.arianna@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1401015115-7610-7-git-send-email-avanzini.arianna@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Arianna Avanzini Cc: Ian.Campbell@eu.citrix.com, paolo.valente@unimore.it, keir@xen.org, stefano.stabellini@eu.citrix.com, Ian.Jackson@eu.citrix.com, dario.faggioli@citrix.com, tim@xen.org, xen-devel@lists.xen.org, julien.grall@citrix.com, etrudeau@broadcom.com, JBeulich@suse.com, andrew.cooper3@citrix.com, viktor.kleinik@globallogic.com List-Id: xen-devel@lists.xenproject.org On Sun, 2014-05-25 at 12:51 +0200, Arianna Avanzini wrote: > Currently, when a memory mapping is removed with the memory_mapping > DOMCTL, no check is performed on the existence of such a mapping. > This commit adds such a consistency check to the code performing the > unmap, emitting a warning message if the check fails. This is only a warning on x86 but is a fatal error on ARM (from patch #2 of this series). Is this discrepancy deliberate? I think the ARM behaviour is more correct but I appreciate that it might be more difficult to switch x86 to that model right away, hence a warning might consider be more appropriate (for now at least). Is that the answer to my question? Ian.