From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v8 08/14] xen/common: move memory_type_changed() function to common code Date: Thu, 5 Jun 2014 15:08:27 +0100 Message-ID: <1401977307.15729.103.camel@hastur.hellion.org.uk> References: <1401015115-7610-1-git-send-email-avanzini.arianna@gmail.com> <1401015115-7610-9-git-send-email-avanzini.arianna@gmail.com> <53821719.9060305@linaro.org> <53832C5E0200007800015AB1@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53832C5E0200007800015AB1@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Ian.Campbell@eu.citrix.com, paolo.valente@unimore.it, keir@xen.org, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, Julien Grall , Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, julien.grall@citrix.com, etrudeau@broadcom.com, tim@xen.org, Arianna Avanzini , viktor.kleinik@globallogic.com List-Id: xen-devel@lists.xenproject.org On Mon, 2014-05-26 at 10:58 +0100, Jan Beulich wrote: > >>> On 25.05.14 at 18:15, wrote: > > On 25/05/14 11:51, Arianna Avanzini wrote: > >> Currently, MTRR-related code is not available for the ARM architecture. > >> Given that the memory_type_changed() function must be called also from > >> common code, its invocation is currently ifdef'd out to be only compiled > >> in on an x86 machine. This commit adds an empty stub for ARM, instead, > >> also moving the function's definition to common code. > > > > Hrmmm, MTRR doesn't have any sense on ARM, IIRC, this is only > > x86-related. So we should not expose this concept (i.e naming the > > include and source file) to the common architecture. > > > > I would move the function declaration in xen/p2m*.h and add the stub for > > arm in arch/arm/p2m.c > > Seconded. Thirded ;-) Ian.