From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 01/17] configure: make the libaio test conditional on blktap1 Date: Thu, 5 Jun 2014 16:06:29 +0100 Message-ID: <1401980789.15729.130.camel@hastur.hellion.org.uk> References: <1401721703-34974-1-git-send-email-roger.pau@citrix.com> <1401721703-34974-2-git-send-email-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WsZFT-0001vh-Ih for xen-devel@lists.xenproject.org; Thu, 05 Jun 2014 15:06:35 +0000 In-Reply-To: <1401721703-34974-2-git-send-email-roger.pau@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roger Pau Monne Cc: xen-devel@lists.xenproject.org, Ian Jackson List-Id: xen-devel@lists.xenproject.org On Mon, 2014-06-02 at 17:08 +0200, Roger Pau Monne wrote: > libaio is only required for blktap1, so make the check conditional on > whether the user has requested blktap1 or not. I think it is used for blktap2 as well. I thought blktap2 was Linux specific (and hence that the libaio could be too) but, from tools/Makefile: SUBDIRS-$(CONFIG_Linux) += blktap2 SUBDIRS-$(CONFIG_NetBSD) += blktap2 I'm totally surprised by that! And TBH I find it a little hard to believe... Ian.