Re: [PATCH v2 15/17] libxl: allow usage of char devices as block backends

[Ian Campbell <ian.campbell@citrix.com>]

On Mon, 2014-06-02 at 17:08 +0200, Roger Pau Monne wrote:
> On FreeBSD ZVOLs/disks/partitions are char devices, so libxl must
> allow it's usage.

Are they really, how... interesting...

Do we think this should be made platform specific?

> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> ---
>  tools/libxl/libxl_device.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/libxl/libxl_device.c b/tools/libxl/libxl_device.c
> index fa99f77..7dd359c 100644
> --- a/tools/libxl/libxl_device.c
> +++ b/tools/libxl/libxl_device.c
> @@ -266,7 +266,8 @@ int libxl__device_disk_set_backend(libxl__gc *gc, libxl_device_disk *disk) {
>              return ERROR_INVAL;
>          }
>          if (!S_ISBLK(a.stab.st_mode) &
> -            !S_ISREG(a.stab.st_mode)) {
> +            !S_ISREG(a.stab.st_mode) &
> +            !S_ISCHR(a.stab.st_mode)) {
>              LOG(ERROR, "Disk vdev=%s phys path is not a block dev or file: %s",
>                         disk->vdev, disk->pdev_path);
>              return ERROR_INVAL;



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel