From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: [RFC 01/19] xen/arm: guest_physmap_remove_page: Print a warning if we fail to unmap the page Date: Mon, 16 Jun 2014 17:17:48 +0100 Message-ID: <1402935486-29136-2-git-send-email-julien.grall@linaro.org> References: <1402935486-29136-1-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WwZbt-0006h1-EL for xen-devel@lists.xenproject.org; Mon, 16 Jun 2014 16:18:17 +0000 Received: by mail-wg0-f44.google.com with SMTP id x13so5877540wgg.27 for ; Mon, 16 Jun 2014 09:18:15 -0700 (PDT) In-Reply-To: <1402935486-29136-1-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: stefano.stabellini@citrix.com, Julien Grall , tim@xen.org, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org The function guest_physmap_remove_page does't have a return value. With the change "arch/arm: add consistency check to REMOVE p2m changes", apply_p2m_changes can unlikely fail. Warn the user in this case. Signed-off-by: Julien Grall --- xen/arch/arm/p2m.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index f93f99a..51f9225 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -607,10 +607,16 @@ void guest_physmap_remove_page(struct domain *d, unsigned long gpfn, unsigned long mfn, unsigned int page_order) { - apply_p2m_changes(d, REMOVE, - pfn_to_paddr(gpfn), - pfn_to_paddr(gpfn + (1<domain_id, gpfn, gpfn + (1 << page_order), mfn); } int p2m_alloc_table(struct domain *d) -- 1.7.10.4