From: Dario Faggioli <dario.faggioli@citrix.com>
To: Meng Xu <xumengpanda@gmail.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Sisu Xi <xisisu@gmail.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Meng Xu <mengxu@cis.upenn.edu>, Chong Li <lichong659@gmail.com>,
Dagaen Golomb <dgolomb@seas.upenn.edu>
Subject: Re: [PATCH RFC v1 2/4] xl for rt scheduler
Date: Mon, 14 Jul 2014 09:40:39 +0200 [thread overview]
Message-ID: <1405323639.29306.567.camel@Solace> (raw)
In-Reply-To: <CAENZ-+=r7kFbJKyXix+xwP3nH0T86KKikjbJLLJY3vd+9xj2Bg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 900 bytes --]
On dom, 2014-07-13 at 08:58 -0400, Meng Xu wrote:
> I think you are right! But I think the implementation of this
> functionality for credit scheduler also has the exactly same issue:
> scinfo will not be disposed when hypercall returns false.
> (Note: sched_domain_get() init the scinfo, but didn't dispose it. )
>
ISWYM.
Yes, I think either in sched_domain_get(), or at the three (four
considering your code) callsites, a _dispose() would be good.
> As you can see, it has the exact issue I had. :-) If it's the case, I
> can submit a separate patch for this. :-)
>
Go ahead. :-)
Thanks and Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-07-14 7:40 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 4:49 Introduce rt real-time scheduler for Xen Meng Xu
2014-07-11 4:49 ` [PATCH RFC v1 1/4] rt: Add rt scheduler to hypervisor Meng Xu
2014-07-11 14:27 ` Dario Faggioli
2014-07-11 14:37 ` Andrew Cooper
2014-07-11 15:21 ` Dario Faggioli
2014-07-11 15:40 ` Andrew Cooper
2014-07-11 15:48 ` Dario Faggioli
2014-07-16 17:05 ` Konrad Rzeszutek Wilk
2014-07-17 10:12 ` Meng Xu
2014-07-17 15:12 ` Dario Faggioli
2014-07-18 5:46 ` Meng Xu
2014-07-18 18:40 ` Konrad Rzeszutek Wilk
2014-07-11 4:49 ` [PATCH RFC v1 2/4] xl for rt scheduler Meng Xu
2014-07-11 11:02 ` Wei Liu
2014-07-11 14:59 ` Meng Xu
2014-07-11 15:07 ` Dario Faggioli
2014-07-11 16:25 ` Meng Xu
2014-07-13 12:58 ` Meng Xu
2014-07-14 7:40 ` Dario Faggioli [this message]
2014-07-14 9:31 ` Wei Liu
2014-07-17 15:39 ` Ian Campbell
2014-07-11 4:49 ` [PATCH RFC v1 3/4] libxl " Meng Xu
2014-07-11 11:05 ` Wei Liu
2014-07-11 15:08 ` Dario Faggioli
2014-07-12 18:16 ` Meng Xu
2014-07-14 10:38 ` Dario Faggioli
2014-07-17 15:34 ` Ian Campbell
2014-07-17 15:36 ` Ian Campbell
2014-07-18 11:05 ` Meng Xu
2014-07-11 4:49 ` [PATCH RFC v1 4/4] libxc " Meng Xu
2014-07-11 14:49 ` Dario Faggioli
2014-07-11 16:23 ` Meng Xu
2014-07-11 16:35 ` Dario Faggioli
2014-07-11 16:49 ` Andrew Cooper
2014-07-12 19:46 ` Meng Xu
2014-07-17 15:29 ` Ian Campbell
2014-07-17 15:34 ` George Dunlap
2014-07-17 22:16 ` Meng Xu
2014-07-18 9:49 ` Dario Faggioli
2014-07-18 9:51 ` Ian Campbell
2014-07-18 12:11 ` Meng Xu
2014-07-18 9:47 ` Ian Campbell
2014-07-18 10:00 ` Dario Faggioli
2014-07-11 10:50 ` Introduce rt real-time scheduler for Xen Wei Liu
2014-07-11 11:06 ` Dario Faggioli
2014-07-11 16:14 ` Meng Xu
2014-07-11 16:19 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405323639.29306.567.camel@Solace \
--to=dario.faggioli@citrix.com \
--cc=dgolomb@seas.upenn.edu \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=lichong659@gmail.com \
--cc=mengxu@cis.upenn.edu \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=xisisu@gmail.com \
--cc=xumengpanda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).