From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH RFC v1 2/4] xl for rt scheduler
Date: Mon, 14 Jul 2014 09:40:39 +0200
Message-ID: <1405323639.29306.567.camel@Solace>
References: <1405054198-29106-1-git-send-email-mengxu@cis.upenn.edu>
	<1405054198-29106-3-git-send-email-mengxu@cis.upenn.edu>
	<20140711110206.GD12584@zion.uk.xensource.com>
	<CAENZ-+ncydo8fZ9QCLeogsPnNnJeRYp2B83UV95RCRK_G4uksg@mail.gmail.com>
	<1405091227.29306.463.camel@Solace>
	<CAENZ-+=r7kFbJKyXix+xwP3nH0T86KKikjbJLLJY3vd+9xj2Bg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2042938964444569416=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAENZ-+=r7kFbJKyXix+xwP3nH0T86KKikjbJLLJY3vd+9xj2Bg@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Meng Xu <xumengpanda@gmail.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Sisu Xi <xisisu@gmail.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Meng Xu <mengxu@cis.upenn.edu>, Chong Li <lichong659@gmail.com>, Dagaen Golomb <dgolomb@seas.upenn.edu>
List-Id: xen-devel@lists.xenproject.org

--===============2042938964444569416==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-HjunCp7hOwMhwUBFhvfw"

--=-HjunCp7hOwMhwUBFhvfw
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On dom, 2014-07-13 at 08:58 -0400, Meng Xu wrote:

> I think you are right! But I think the implementation of this
> functionality for credit scheduler also has the exactly same issue:
> scinfo will not be disposed when hypercall returns false.=20

> (Note: sched_domain_get() init the scinfo, but didn't dispose it. )
>=20
ISWYM.

Yes, I think either in sched_domain_get(), or at the three (four
considering your code) callsites, a _dispose() would be good.

>  As you can see, it has the exact issue I had. :-) If it's the case, I
> can submit a separate patch for this. :-)
>
Go ahead. :-)

Thanks and Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-HjunCp7hOwMhwUBFhvfw
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlPDiXcACgkQk4XaBE3IOsRqCwCfaGeLqSF8XICFFoQWQmCoEdHc
2PYAn2P06VQduXwVFB05TaZxS0VkDjy+
=1gjw
-----END PGP SIGNATURE-----

--=-HjunCp7hOwMhwUBFhvfw--


--===============2042938964444569416==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============2042938964444569416==--