From: George Dunlap <george.dunlap@eu.citrix.com>
To: xen-devel@lists.xen.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Ian Jackson <ian.jackson@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 1/5] make: Check tools/qemu-xen[-traditional] for qemu before downloading
Date: Mon, 14 Jul 2014 17:15:22 +0100 [thread overview]
Message-ID: <1405354526-20929-1-git-send-email-george.dunlap@eu.citrix.com> (raw)
Currently xen, qemu-xen, and qemu-xen-traditional are kept in separate
repositories, but when we release them as a tarball, qemu-xen and
qemu-xen-traditional are in-lined into the tools/ directory.
In order to make this "just work", at the moment developer doing the
release manually modifies Config.mk as part of the relase process so
that CONFIG_QEMU and QEMU_UPSTREAM_URL point into the tools/ directory
instead.
Modify Config.mk to automatically check there before trying a remote
repository.
Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
---
Since we're essentially manually doing this for each release anyway, I
propose this c/s be backported to all currently-maintained branches.
v2:
- Make *_INTREE variables to avoid duplication
- Make assignment more compact for CONFIG_QEMU
CC: Ian Campbell <ian.campbell@citrix.com>
CC: Ian Jackson <ian.jackson@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
---
Config.mk | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/Config.mk b/Config.mk
index ab95b1c..a9b3468 100644
--- a/Config.mk
+++ b/Config.mk
@@ -224,6 +224,21 @@ else
QEMU_REMOTE ?= git://xenbits.xen.org/qemu-xen-unstable.git
endif
+# Where to look for inlined subtrees (for example, from a tarball)
+QEMU_UPSTREAM_INTREE ?= $(XEN_ROOT)/tools/qemu-xen
+QEMU_TRADITIONAL_INTREE ?= $(XEN_ROOT)/tools/qemu-xen-traditional
+
+
+# Specify which qemu-dm to use. This may be `ioemu' to use the old
+# Mercurial in-tree version, or a local directory, or a git URL.
+# CONFIG_QEMU ?= `pwd`/$(XEN_ROOT)/../qemu-xen.git
+CONFIG_QEMU ?= $(or $(wildcard $(QEMU_TRADITIONAL_INTREE)),\
+ $(QEMU_REMOTE))
+
+ifneq (,$(wildcard $(QEMU_UPSTREAM_INTREE)))
+QEMU_UPSTREAM_URL ?= $(QEMU_UPSTREAM_INTREE)
+endif
+
ifeq ($(GIT_HTTP),y)
OVMF_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/ovmf.git
QEMU_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/qemu-upstream-unstable.git
@@ -241,10 +256,6 @@ SEABIOS_UPSTREAM_TAG ?= rel-1.7.5
ETHERBOOT_NICS ?= rtl8139 8086100e
-# Specify which qemu-dm to use. This may be `ioemu' to use the old
-# Mercurial in-tree version, or a local directory, or a git URL.
-# CONFIG_QEMU ?= `pwd`/$(XEN_ROOT)/../qemu-xen.git
-CONFIG_QEMU ?= $(QEMU_REMOTE)
QEMU_TAG ?= d0395cc49b2ec6d1723c01f1daf2394b9264ca29
# Tue Apr 8 16:50:06 2014 +0000
--
1.7.9.5
next reply other threads:[~2014-07-14 16:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 16:15 George Dunlap [this message]
2014-07-14 16:15 ` [PATCH 2/5] make: Normalize config options for external trees George Dunlap
2014-07-16 8:58 ` Ian Campbell
2014-07-16 14:53 ` Ian Jackson
2014-07-21 10:22 ` Olaf Hering
2014-07-21 10:28 ` George Dunlap
2014-07-21 10:44 ` Olaf Hering
2014-07-21 10:46 ` George Dunlap
2014-07-21 10:49 ` Olaf Hering
2014-07-14 16:15 ` [PATCH 3/5] make: Make *-dir-force-update depend on *-dir-find George Dunlap
2014-07-16 14:53 ` Ian Jackson
2014-07-14 16:15 ` [PATCH 4/5] make: Add subtree-update target George Dunlap
2014-07-16 9:00 ` Ian Campbell
2014-07-16 14:54 ` Ian Jackson
2014-07-14 16:15 ` [PATCH 5/5] make: Make "src-tarball" target actually make a source tarball George Dunlap
2014-07-16 15:06 ` Ian Jackson
2014-07-16 16:56 ` Ian Campbell
2014-07-16 17:45 ` George Dunlap
2014-07-17 9:21 ` Ian Campbell
2014-07-17 16:46 ` George Dunlap
2014-07-18 10:45 ` Ian Jackson
2014-09-15 15:42 ` George Dunlap
2014-09-15 15:46 ` Ian Jackson
2014-07-16 9:02 ` [PATCH 1/5] make: Check tools/qemu-xen[-traditional] for qemu before downloading Ian Campbell
2014-07-16 14:50 ` Ian Jackson
2014-07-18 12:39 ` Ian Campbell
2014-07-23 10:52 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405354526-20929-1-git-send-email-george.dunlap@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).