From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: [OSSTEST PATCH 02/13] BuildSupport: make selectbuildhost modify @ARGV
Date: Tue, 15 Jul 2014 16:22:16 +0100 [thread overview]
Message-ID: <1405437747-12753-3-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1405437747-12753-1-git-send-email-ian.jackson@eu.citrix.com>
We pass it \@ARGV everywhere now, and it eats the argument (if it
finds one). This allows build scripts to take extra arguments.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
Osstest/BuildSupport.pm | 5 +++--
ts-kernel-build | 2 +-
ts-libvirt-build | 2 +-
ts-rumpuserxen-build | 2 +-
ts-xen-build | 2 +-
5 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/Osstest/BuildSupport.pm b/Osstest/BuildSupport.pm
index 6d43cbc..0938810 100644
--- a/Osstest/BuildSupport.pm
+++ b/Osstest/BuildSupport.pm
@@ -56,8 +56,9 @@ our ($builddir,$makeflags);
our ($xendist);
sub selectbuildhost {
- # pass @ARGV
- ($whhost) = @_;
+ # pass \@ARGV
+ my ($av) = @_;
+ $whhost = shift @$av;
$whhost ||= 'host';
$ho= selecthost($whhost);
}
diff --git a/ts-kernel-build b/ts-kernel-build
index 984a935..3b48920 100755
--- a/ts-kernel-build
+++ b/ts-kernel-build
@@ -22,7 +22,7 @@ use Osstest::TestSupport;
use Osstest::BuildSupport;
tsreadconfig();
-selectbuildhost(@ARGV);
+selectbuildhost(\@ARGV);
builddirsprops();
my $archparms = {
diff --git a/ts-libvirt-build b/ts-libvirt-build
index 5f493e4..940c034 100755
--- a/ts-libvirt-build
+++ b/ts-libvirt-build
@@ -22,7 +22,7 @@ use Osstest::TestSupport;
use Osstest::BuildSupport;
tsreadconfig();
-selectbuildhost(@ARGV);
+selectbuildhost(\@ARGV);
builddirsprops();
sub libvirtd_init ();
diff --git a/ts-rumpuserxen-build b/ts-rumpuserxen-build
index ee2db97..a1f31cd 100755
--- a/ts-rumpuserxen-build
+++ b/ts-rumpuserxen-build
@@ -22,7 +22,7 @@ use Osstest::TestSupport;
use Osstest::BuildSupport;
tsreadconfig();
-selectbuildhost(@ARGV);
+selectbuildhost(\@ARGV);
builddirsprops();
our %submodmap = qw(nblibs nblibs
diff --git a/ts-xen-build b/ts-xen-build
index 828c2b4..3913273 100755
--- a/ts-xen-build
+++ b/ts-xen-build
@@ -24,7 +24,7 @@ use Osstest::TestSupport;
use Osstest::BuildSupport;
tsreadconfig();
-selectbuildhost(@ARGV);
+selectbuildhost(\@ARGV);
builddirsprops();
sub checkout () {
--
1.7.10.4
next prev parent reply other threads:[~2014-07-15 15:22 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 15:22 [OSSTEST PATCH 00/13] Build and test rump kernel xenstore-ls Ian Jackson
2014-07-15 15:22 ` [OSSTEST PATCH 01/13] selectguest: log a message Ian Jackson
2014-07-15 15:22 ` Ian Jackson [this message]
2014-07-15 15:22 ` [OSSTEST PATCH 03/13] sg-run-job: Support toggling `adding' by repeating `+' Ian Jackson
2014-07-16 9:17 ` Ian Campbell
2014-07-15 15:22 ` [OSSTEST PATCH 04/13] building: Delete when cloning, not when preparing $builddir Ian Jackson
2014-07-16 9:19 ` Ian Campbell
2014-07-16 9:58 ` Ian Jackson
2014-07-16 10:06 ` Ian Campbell
2014-07-16 10:18 ` Ian Jackson
2014-07-16 10:20 ` Ian Campbell
2014-07-16 10:29 ` Ian Jackson
2014-07-16 11:25 ` Ian Campbell
2014-07-15 15:22 ` [OSSTEST PATCH 05/13] make-flight: rumpuserxen tests: use same buildjob for all guests Ian Jackson
2014-07-16 9:19 ` Ian Campbell
2014-07-16 10:10 ` Ian Jackson
2014-07-15 15:22 ` [OSSTEST PATCH 06/13] ts-xen-build: Allow specification of make targets Ian Jackson
2014-07-15 15:22 ` [OSSTEST PATCH 07/13] ts-xen-build: Honour cmdprefix_configure, cmdprefix_make Ian Jackson
2014-07-15 15:22 ` [OSSTEST PATCH 08/13] rump kernel tests: Do a xen.git tools build Ian Jackson
2014-07-15 15:22 ` [OSSTEST PATCH 09/13] rump kernel tests: Use guest-specific fs images location Ian Jackson
2014-07-15 15:22 ` [OSSTEST PATCH 10/13] rump kernel tests: Specify kernel via runvar Ian Jackson
2014-07-15 15:22 ` [OSSTEST PATCH 11/13] rump kernel tests: Specify cmdline " Ian Jackson
2014-07-15 15:22 ` [OSSTEST PATCH 12/13] ts-guest-destroy-hard: New script Ian Jackson
2014-07-16 9:24 ` Ian Campbell
2014-07-16 10:10 ` Ian Jackson
2014-07-16 10:12 ` Ian Campbell
2014-07-16 10:20 ` Ian Jackson
2014-07-16 10:21 ` Ian Campbell
2014-07-16 10:30 ` Ian Jackson
2014-07-15 15:22 ` [OSSTEST PATCH 13/13] rump kernel tests: Run xenstore-ls demo Ian Jackson
2014-07-16 9:26 ` Ian Campbell
2014-07-16 10:15 ` Ian Jackson
2014-07-16 10:17 ` Ian Campbell
2014-07-16 9:26 ` [OSSTEST PATCH 00/13] Build and test rump kernel xenstore-ls Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405437747-12753-3-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).