xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: [OSSTEST PATCH 04/13] building: Delete when cloning, not when preparing $builddir
Date: Tue, 15 Jul 2014 16:22:18 +0100	[thread overview]
Message-ID: <1405437747-12753-5-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1405437747-12753-1-git-send-email-ian.jackson@eu.citrix.com>

Make prepbuilddirs no longer delete $builddir; instead:
 - have prepbuilddirs delete *-stamp files and dist/;
 - have build_clone delete the specific source directories;
 - any individual ts-*-build scripts that use other things
   would have to delete them (but searching for $builddir
   reveals none).

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 Osstest/BuildSupport.pm |    2 +-
 Osstest/TestSupport.pm  |    4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/Osstest/BuildSupport.pm b/Osstest/BuildSupport.pm
index 0938810..874e27e 100644
--- a/Osstest/BuildSupport.pm
+++ b/Osstest/BuildSupport.pm
@@ -74,7 +74,7 @@ sub builddirsprops {
 
 sub prepbuilddirs {
     my (@xbuilddirs) = @_;
-    my $cmd = "rm -rf $builddir && mkdir $builddir";
+    my $cmd = "mkdir -p $builddir && rm -rf $builddir/*-stamp $builddir/dist";
     $cmd .= " && mkdir $builddir/$_" foreach @xbuilddirs;
     target_cmd($ho,$cmd,600);
 }
diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index 22dcbff..3930595 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -1061,9 +1061,12 @@ sub build_clone ($$$$) {
 	}
     }
 
+    my $rm = "rm -rf $subdir";
+
     if ($vcs eq 'hg') {
         
         target_cmd_build($ho, $timeout, $builddir, <<END.
+	    $rm
 	    hg clone '$tree' $subdir
 	    cd $subdir
 END
@@ -1075,6 +1078,7 @@ END
 	my $eff_tree = git_massage_url($tree);
 
         target_cmd_build($ho, $timeout, $builddir, <<END.
+            $rm
             git clone '$eff_tree' $subdir
             cd $subdir
 END
-- 
1.7.10.4

  parent reply	other threads:[~2014-07-15 15:22 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-15 15:22 [OSSTEST PATCH 00/13] Build and test rump kernel xenstore-ls Ian Jackson
2014-07-15 15:22 ` [OSSTEST PATCH 01/13] selectguest: log a message Ian Jackson
2014-07-15 15:22 ` [OSSTEST PATCH 02/13] BuildSupport: make selectbuildhost modify @ARGV Ian Jackson
2014-07-15 15:22 ` [OSSTEST PATCH 03/13] sg-run-job: Support toggling `adding' by repeating `+' Ian Jackson
2014-07-16  9:17   ` Ian Campbell
2014-07-15 15:22 ` Ian Jackson [this message]
2014-07-16  9:19   ` [OSSTEST PATCH 04/13] building: Delete when cloning, not when preparing $builddir Ian Campbell
2014-07-16  9:58     ` Ian Jackson
2014-07-16 10:06       ` Ian Campbell
2014-07-16 10:18         ` Ian Jackson
2014-07-16 10:20           ` Ian Campbell
2014-07-16 10:29             ` Ian Jackson
2014-07-16 11:25               ` Ian Campbell
2014-07-15 15:22 ` [OSSTEST PATCH 05/13] make-flight: rumpuserxen tests: use same buildjob for all guests Ian Jackson
2014-07-16  9:19   ` Ian Campbell
2014-07-16 10:10     ` Ian Jackson
2014-07-15 15:22 ` [OSSTEST PATCH 06/13] ts-xen-build: Allow specification of make targets Ian Jackson
2014-07-15 15:22 ` [OSSTEST PATCH 07/13] ts-xen-build: Honour cmdprefix_configure, cmdprefix_make Ian Jackson
2014-07-15 15:22 ` [OSSTEST PATCH 08/13] rump kernel tests: Do a xen.git tools build Ian Jackson
2014-07-15 15:22 ` [OSSTEST PATCH 09/13] rump kernel tests: Use guest-specific fs images location Ian Jackson
2014-07-15 15:22 ` [OSSTEST PATCH 10/13] rump kernel tests: Specify kernel via runvar Ian Jackson
2014-07-15 15:22 ` [OSSTEST PATCH 11/13] rump kernel tests: Specify cmdline " Ian Jackson
2014-07-15 15:22 ` [OSSTEST PATCH 12/13] ts-guest-destroy-hard: New script Ian Jackson
2014-07-16  9:24   ` Ian Campbell
2014-07-16 10:10     ` Ian Jackson
2014-07-16 10:12       ` Ian Campbell
2014-07-16 10:20         ` Ian Jackson
2014-07-16 10:21           ` Ian Campbell
2014-07-16 10:30             ` Ian Jackson
2014-07-15 15:22 ` [OSSTEST PATCH 13/13] rump kernel tests: Run xenstore-ls demo Ian Jackson
2014-07-16  9:26   ` Ian Campbell
2014-07-16 10:15     ` Ian Jackson
2014-07-16 10:17       ` Ian Campbell
2014-07-16  9:26 ` [OSSTEST PATCH 00/13] Build and test rump kernel xenstore-ls Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405437747-12753-5-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).