xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: vijay.kilari@gmail.com
Cc: stefano.stabellini@eu.citrix.com,
	Prasun.Kapoor@caviumnetworks.com,
	vijaya.kumar@caviumnetworks.com, julien.grall@linaro.org,
	tim@xen.org, xen-devel@lists.xen.org,
	stefano.stabellini@citrix.com, manish.jaggi@caviumnetworks.com
Subject: Re: [PATCH v7 5/5] xen/arm: check for GICv3 platform support
Date: Wed, 16 Jul 2014 13:11:38 +0100	[thread overview]
Message-ID: <1405512698.7019.93.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <1405083092-20216-6-git-send-email-vijay.kilari@gmail.com>

On Fri, 2014-07-11 at 18:21 +0530, vijay.kilari@gmail.com wrote:

This all looks good apart from:

> @@ -188,9 +188,8 @@ struct cpuinfo_arm {
>              unsigned long el3:4;
>              unsigned long fp:4;   /* Floating Point */
>              unsigned long simd:4; /* Advanced SIMD */
> -            unsigned long __res0:8;
> -
> -            unsigned long __res1;
> +            unsigned long gicv3:4; /* GIC support */
> +            unsigned long __res0:36;

Please leave __res1 alone. so:
            unsigned long simd:4; /* Advanced SIMD */ 
-           unsigned long __res0:8;
+           unsigned long __res0:4;
+           unsigned long gic:4; /* GIC support */
 
            unsigned long __res1;

Also note that in the ARMv8 this field is just called "gic", so I have
done the same, please do it that way otherwise when gic vN adds a new
sysreg we'll just have to rename the field.

Ian

  reply	other threads:[~2014-07-16 12:11 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11 12:51 [PATCH v7 0/5] xen/arm: Add GICv3 support vijay.kilari
2014-07-11 12:51 ` [PATCH v7 1/5] xen/arm: Add support for GIC v3 vijay.kilari
2014-07-16 11:41   ` Ian Campbell
2014-07-22  9:48     ` Vijay Kilari
2014-07-22 10:01       ` Julien Grall
2014-07-22 10:43         ` Ian Campbell
2014-07-22 11:13           ` Julien Grall
2014-07-22 11:30             ` Vijay Kilari
2014-07-22 11:45               ` Ian Campbell
2014-07-22 10:39       ` Ian Campbell
2014-07-22 10:49         ` Vijay Kilari
2014-07-22 10:55           ` Ian Campbell
2014-07-22 11:12             ` Vijay Kilari
2014-07-22 11:15               ` Julien Grall
2014-07-22 11:19                 ` Ian Campbell
2014-07-11 12:51 ` [PATCH v7 2/5] xen/arm: Add virtual GICv3 support vijay.kilari
2014-07-14 15:59   ` Julien Grall
2014-07-16 11:47   ` Ian Campbell
2014-07-16 11:56     ` Vijay Kilari
2014-07-11 12:51 ` [PATCH v7 3/5] xen/arm: Update Dom0 GIC dt node with GICv3 information vijay.kilari
2014-07-16 11:53   ` Ian Campbell
2014-07-11 12:51 ` [PATCH v7 4/5] xen/arm: add SGI handling for GICv3 vijay.kilari
2014-07-11 13:43   ` Julien Grall
2014-07-11 14:08     ` Ian Campbell
2014-07-11 14:12       ` Julien Grall
2014-07-11 14:18         ` Ian Campbell
2014-07-22 13:48   ` Stefano Stabellini
2014-07-22 14:13     ` Vijay Kilari
2014-07-23  5:48       ` Vijay Kilari
2014-07-23 10:35         ` Stefano Stabellini
2014-07-11 12:51 ` [PATCH v7 5/5] xen/arm: check for GICv3 platform support vijay.kilari
2014-07-16 12:11   ` Ian Campbell [this message]
2014-07-16 10:35 ` [PATCH v7 0/5] xen/arm: Add GICv3 support Ian Campbell
2014-07-16 11:47   ` Vijay Kilari
2014-07-16 12:38     ` Ian Campbell
2014-07-16 13:32       ` Ian Campbell
2014-07-23 10:51         ` Vijay Kilari
2014-07-23 11:31           ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405512698.7019.93.camel@kazak.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=Prasun.Kapoor@caviumnetworks.com \
    --cc=julien.grall@linaro.org \
    --cc=manish.jaggi@caviumnetworks.com \
    --cc=stefano.stabellini@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=vijay.kilari@gmail.com \
    --cc=vijaya.kumar@caviumnetworks.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).