xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Dario Faggioli <dario.faggioli@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Ian.Jackson@citrix.com,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Wei Liu <wei.liu2@citrix.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH RFC 2/9] ts-unixbench-prep: prep the environment for running unixbench
Date: Wed, 16 Jul 2014 17:57:13 +0200	[thread overview]
Message-ID: <1405526233.5333.101.camel@Solace> (raw)
In-Reply-To: <1405523380.1087.14.camel@kazak.uk.xensource.com>


[-- Attachment #1.1: Type: text/plain, Size: 2566 bytes --]

On mer, 2014-07-16 at 16:09 +0100, Ian Campbell wrote:
> On Thu, 2014-06-26 at 15:02 +0200, Dario Faggioli wrote:
> > by installing some dependencies,
> 
> this isn't currently possible due to the (possibly futuristic) potential
> to share build hosts. ts-xen-build-prep is special in this regard
> (AIUI). I don't see you installing anything which would be so
> intolerable to install on every machine.
> 
> I have an old patch "apt: lock osstest's usages of apt-get against each
> other" which is supposed to help with this, but I need to revisit and
> fix some comments from Ian I think.
> 
Mm... I'd be fine with installing everything on every test host.
However, as we grow the number of supported benchmark, dependencies will
also grow. E.g., if we want to run SpecJBB, we'll need JVM stuff. If we
want to run even a subset of Phoronix test suite, we'll need a lot of
stuff, I think... Is this still acceptable?

> >  shipping the archive, untaring
> > and building the sources.
> 
> ts-unixbench-build would be the more conventional name I think.
> 
Indeed. Fact is, there are benchmarks that require building (e.g., this
one), and benchmark that does not (e.g., kernbench).

I thought it would be good to have all the prepping script to have a
similar name (if not to include all the prep work in just one
ts-bench-prep that takes the benchmark name as a parameter! Look at the
very last patch of the series).

That's the reason for the 'prep' instead than 'build'. What do you
think?

> > This accepts two parametrs, in the form 'host=somehost someguest',
> > as most of the ts-guest-xxx scripts. If only the first one is
> > provided, it must be 'host=somehost', and the script will prep
> > the host.
> > 
> >  XXX: I see it useful that this works for the host too, as
> >       at some point we may want to run benchmarks on dom0
> >       or even bare metal.
> 
> Absolutely. I realise now that the comments about apt install above is
> only really relevant to the host case.
> 
Which would make the 'path' for running benches on host and guest a bit
different, but that's certainly fine. If we're installing *everything*
on hosts, I've got no problem making this prepping scripts available for
guests only.

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  parent reply	other threads:[~2014-07-16 15:57 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-26 13:02 [PATCH RFC 0/9] Running benchmarks via OSSTest Dario Faggioli
2014-06-26 13:02 ` [PATCH RFC 1/9] mg-unixbench-download: new script for downloading the unixbench archive Dario Faggioli
2014-07-16 15:02   ` Ian Campbell
2014-07-16 16:08     ` Dario Faggioli
2014-06-26 13:02 ` [PATCH RFC 2/9] ts-unixbench-prep: prep the environment for running unixbench Dario Faggioli
2014-07-16 15:09   ` Ian Campbell
2014-07-16 15:11     ` Ian Jackson
2014-07-16 15:57     ` Dario Faggioli [this message]
2014-07-16 16:07     ` Dario Faggioli
2014-06-26 13:02 ` [PATCH RFC 3/9] ts-unixbench-run: kick off the benchmark on the target Dario Faggioli
2014-06-26 13:02 ` [PATCH RFC 4/9] ts-unixbench-reslts: for retrieving the results Dario Faggioli
2014-07-16 15:11   ` Ian Campbell
2014-07-16 15:58     ` Dario Faggioli
2014-06-26 13:02 ` [PATCH RFC 5/9] sg-run-job: new recipe for a unixbench job Dario Faggioli
2014-06-26 13:03 ` [PATCH RFC 6/9] make-bench-flight: to create a benchmarking flight Dario Faggioli
2014-06-26 13:03 ` [PATCH RFC 7/9] make-flight: introduce a new -t option Dario Faggioli
2014-07-16 15:13   ` Ian Campbell
2014-07-16 15:14     ` Dario Faggioli
2014-06-26 13:03 ` [PATCH RFC 8/9] mg-unixbench-download: make it generic Dario Faggioli
2014-06-26 13:03 ` [PATCH RFC 9/9] ts-unixbench-prep: " Dario Faggioli
2014-06-27  9:40   ` Dario Faggioli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405526233.5333.101.camel@Solace \
    --to=dario.faggioli@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).