From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH RFC 1/9] mg-unixbench-download: new script for downloading the unixbench archive Date: Wed, 16 Jul 2014 18:08:55 +0200 Message-ID: <1405526935.5333.111.camel@Solace> References: <20140626124540.20110.24159.stgit@Solace> <20140626130221.20110.31084.stgit@Solace> <1405522941.1087.7.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4852238195094852824==" Return-path: In-Reply-To: <1405522941.1087.7.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian.Jackson@citrix.com, Stefano Stabellini , Wei Liu , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============4852238195094852824== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-qOreP0T721r3jjIrdhbW" --=-qOreP0T721r3jjIrdhbW Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mer, 2014-07-16 at 16:02 +0100, Ian Campbell wrote: > On Thu, 2014-06-26 at 15:02 +0200, Dario Faggioli wrote: > > The script fetches it, and saves it in c{Images}/benchs. > >=20 > > Default values for URL and actual filename are in ap-common, and > > can be overridden as usual. >=20 > ap-* are to do with the pushing machinery, so I'm not sure this is the > right place for it. >=20 Right. Sorry then, I must have missed this. > I think it would be OK to hardcode the URL into the script and put the > version number in the config file (e.g. production-config). Perhaps with > a default (in the script). >=20 I'll do it this way. > > XXX: this may or may not be something suitable to do in a > > function in cri-common, called by ap-fetch-version. It's > > not a git tree, and it's not something that changes much > > so I think it's fine like it is in this patch. If it is > > not, advise otherwise and I'll cope. >=20 > The usual approach would be to have a setup script (as you have done > here) to populate an output directory rather than to run the dl on every > run (as you propose in this comment, I think). >=20 Great, less (re)work! :-) Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-qOreP0T721r3jjIrdhbW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlPGo5cACgkQk4XaBE3IOsTIUgCgoo1mvGOAcT4W/y321HytV1nF PLcAoKORMf7fxPKVt81E5cCqIjbWX3ii =DQBQ -----END PGP SIGNATURE----- --=-qOreP0T721r3jjIrdhbW-- --===============4852238195094852824== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4852238195094852824==--