From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH 0/2] Xen/mem_event: Do not rely on the toolstack being bug-free
Date: Thu, 17 Jul 2014 14:10:35 +0100 [thread overview]
Message-ID: <1405602637-8321-1-git-send-email-andrew.cooper3@citrix.com> (raw)
Xen performs insufficient validation of the contents of mem_event responses
from the toolstack. As a result, a buggy toolstack could cause Xen to walk
off the end of a domain's vcpu list, and get out of sync with vcpu pause
reference counts.
These two fixes are compile tested only, as I have no way to plausibly test
the mem-event functionality itself.
Andrew Cooper (2):
Xen/mem_event: Validate the response vcpu_id before acting on it.
Xen/mem_event: Prevent underflow of vcpu pause counts
xen/arch/x86/hvm/hvm.c | 2 +-
xen/arch/x86/mm/mem_event.c | 14 ++++++++++++++
xen/arch/x86/mm/mem_sharing.c | 13 +++++++++++--
xen/arch/x86/mm/p2m.c | 26 ++++++++++++++++++++++----
xen/include/asm-x86/mem_event.h | 3 +++
xen/include/xen/sched.h | 2 ++
6 files changed, 53 insertions(+), 7 deletions(-)
next reply other threads:[~2014-07-17 13:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 13:10 Andrew Cooper [this message]
2014-07-17 13:10 ` [PATCH 1/2] Xen/mem_event: Validate the response vcpu_id before acting on it Andrew Cooper
2014-07-17 18:33 ` Andres Lagar Cavilla
2014-07-17 13:10 ` [PATCH 2/2] Xen/mem_event: Prevent underflow of vcpu pause counts Andrew Cooper
2014-07-17 18:38 ` Andres Lagar Cavilla
[not found] ` <CAGU+auv8zMj+xqU8KhbQSZXM+J+HovjV=TZMab5Z+nzNCvpjaQ@mail.gmail.com>
2014-07-17 18:51 ` Aravindh Puthiyaparambil (aravindp)
2014-07-17 18:54 ` Andres Lagar Cavilla
2014-07-17 18:57 ` Aravindh Puthiyaparambil (aravindp)
2014-07-17 19:07 ` Andrew Cooper
2014-07-17 19:18 ` Aravindh Puthiyaparambil (aravindp)
2014-07-17 18:55 ` Andrew Cooper
2014-07-18 9:42 ` Ian Campbell
2014-07-18 10:41 ` [PATCH v2 " Andrew Cooper
2014-07-18 13:47 ` Razvan Cojocaru
2014-07-18 13:53 ` [PATCH v3 " Andrew Cooper
2014-07-18 16:37 ` Andres Lagar Cavilla
2014-07-18 16:44 ` Andrew Cooper
2014-07-18 17:29 ` Aravindh Puthiyaparambil (aravindp)
2014-07-17 13:23 ` [PATCH 0/2] Xen/mem_event: Do not rely on the toolstack being bug-free Tim Deegan
2014-07-17 14:40 ` Razvan Cojocaru
2014-07-17 14:46 ` Andrew Cooper
2014-07-17 14:50 ` Razvan Cojocaru
[not found] ` <CAGU+auuzOr5HSErrxmyhtxtP74gn=0L5TAZGR8FWBF6MeGFxUA@mail.gmail.com>
2014-07-17 19:01 ` Aravindh Puthiyaparambil (aravindp)
2014-07-17 20:26 ` Razvan Cojocaru
2014-07-17 22:17 ` Tamas Lengyel
2014-07-17 22:42 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405602637-8321-1-git-send-email-andrew.cooper3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).