From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH RFC v1 4/4] libxc for rt scheduler
Date: Fri, 18 Jul 2014 12:00:47 +0200
Message-ID: <1405677647.5333.167.camel@Solace>
References: <1405054198-29106-1-git-send-email-mengxu@cis.upenn.edu>
	<1405054198-29106-5-git-send-email-mengxu@cis.upenn.edu>
	<1405090176.29306.451.camel@Solace>
	<1405610976.1977.20.camel@kazak.uk.xensource.com>
	<CAFLBxZZyjOpWvabtDnCrhhHtTac8uphzGhfZRPe6vNvs-AJf9Q@mail.gmail.com>
	<1405676854.13883.5.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7848710212268051746=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1405676854.13883.5.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Sisu Xi <xisisu@gmail.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Meng Xu <xumengpanda@gmail.com>, Meng Xu <mengxu@cis.upenn.edu>, lichong659@gmail.com, dgolomb@seas.upenn.edu
List-Id: xen-devel@lists.xenproject.org

--===============7848710212268051746==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-GRbNOTypQLzVFYQHlVzx"

--=-GRbNOTypQLzVFYQHlVzx
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On ven, 2014-07-18 at 10:47 +0100, Ian Campbell wrote:

> Lets not repeat that mistake with this new scheduler, if the domctl (or
> a sysctl for that matter) needs per VCPU information then it should IMHO
> take the parameters inline in the struct (like the others), anything
> dynamic like the per-vcpu stuff should then be a GUEST_HANDLE pointer to
> a dynamically sized array (accessed with copy_from_guest_offset et al).
>=20
Indeed.

There is one other subtle difference, between the new scheduler Meng is
working on, and the existing ones (even leaving ARINC out).

In fact, SEDF, Credit and Credit2, only allows per domain parameters,
while Meng's scheduler supports per-vcpu parameters, and hence he needs
a guest handle to deal with the array of these per-vcpu parameters.

BTW, while writing this, I saw your
<1405677108.13883.9.camel@kazak.uk.xensource.com>, which goes straight
to the point I was trying to make, and with which I totally concur. :-)

Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-GRbNOTypQLzVFYQHlVzx
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlPI8E8ACgkQk4XaBE3IOsTklACfdeCBhSTfztrY12yVON9yr/KS
AqkAnjxFkgWuR1+JAeM44bf7dEkTYfOz
=MruL
-----END PGP SIGNATURE-----

--=-GRbNOTypQLzVFYQHlVzx--


--===============7848710212268051746==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============7848710212268051746==--