From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xen.org
Cc: julien.grall@linaro.org, tim@xen.org,
Ian Campbell <ian.campbell@citrix.com>,
stefano.stabellini@eu.citrix.com
Subject: [PATCH v4] xen: arm: Only lookup kernel/initrd bootmodule once while building dom0.
Date: Mon, 21 Jul 2014 13:09:16 +0100 [thread overview]
Message-ID: <1405944556-8372-1-git-send-email-ian.campbell@citrix.com> (raw)
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
v4: Call the new field kernel_bootmodule for clarity
Use the new field throughout kernel.c as well as in domain_build.c
Add and use initrd_bootmodule too.
Const up the uses
v3: New patch
---
xen/arch/arm/domain_build.c | 6 +++---
xen/arch/arm/kernel.c | 2 ++
xen/arch/arm/kernel.h | 1 +
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 154367e..23261e4 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -405,7 +405,7 @@ static int write_properties(struct domain *d, struct kernel_info *kinfo,
int res = 0;
int had_dom0_bootargs = 0;
- struct bootmodule *mod = boot_module_find_by_kind(BOOTMOD_KERNEL);
+ const struct bootmodule *mod = kinfo->kernel_bootmodule;
if ( mod && mod->cmdline[0] )
bootargs = &mod->cmdline[0];
@@ -455,7 +455,7 @@ static int write_properties(struct domain *d, struct kernel_info *kinfo,
if ( dt_node_path_is_equal(node, "/chosen") )
{
- struct bootmodule *mod = boot_module_find_by_kind(BOOTMOD_RAMDISK);
+ const struct bootmodule *mod = kinfo->initrd_bootmodule;
if ( bootargs )
{
@@ -1224,7 +1224,7 @@ static void dtb_load(struct kernel_info *kinfo)
static void initrd_load(struct kernel_info *kinfo)
{
- struct bootmodule *mod = boot_module_find_by_kind(BOOTMOD_RAMDISK);
+ const struct bootmodule *mod = kinfo->initrd_bootmodule;
paddr_t load_addr = kinfo->initrd_paddr;
paddr_t paddr, len;
unsigned long offs;
diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c
index 230ff8f..eaeadb5 100644
--- a/xen/arch/arm/kernel.c
+++ b/xen/arch/arm/kernel.c
@@ -116,6 +116,7 @@ static void place_modules(struct kernel_info *info,
info->dtb_paddr = modbase;
info->initrd_paddr = info->dtb_paddr + dtb_len;
+ info->initrd_bootmodule = mod;
}
static paddr_t kernel_zimage_place(struct kernel_info *info)
@@ -383,6 +384,7 @@ int kernel_probe(struct kernel_info *info)
return -ENOENT;
}
+ info->kernel_bootmodule = mod;
start = mod->start;
size = mod->size;
diff --git a/xen/arch/arm/kernel.h b/xen/arch/arm/kernel.h
index 7c7f624..0050dfb 100644
--- a/xen/arch/arm/kernel.h
+++ b/xen/arch/arm/kernel.h
@@ -23,6 +23,7 @@ struct kernel_info {
paddr_t entry;
/* boot blob load addresses */
+ const struct bootmodule *kernel_bootmodule, *initrd_bootmodule;
paddr_t dtb_paddr;
paddr_t initrd_paddr;
--
1.7.10.4
next reply other threads:[~2014-07-21 12:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 12:09 Ian Campbell [this message]
2014-07-21 12:20 ` [PATCH v4] xen: arm: Only lookup kernel/initrd bootmodule once while building dom0 Julien Grall
2014-07-21 12:24 ` Ian Campbell
2014-07-21 12:30 ` Julien Grall
2014-07-24 15:51 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405944556-8372-1-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).