From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>
Subject: [PATCH 2/3] tools/xenconsoled: Possibly perform repeated xc_readconsolering() hypercalls
Date: Tue, 22 Jul 2014 17:17:15 +0100 [thread overview]
Message-ID: <1406045836-9955-3-git-send-email-andrew.cooper3@citrix.com> (raw)
In-Reply-To: <1406045836-9955-1-git-send-email-andrew.cooper3@citrix.com>
The size of the Xen console ring is runtime configurable, so the statically
sized 16k buffer is not necessarily sufficient. Make repeated
xc_readconsolering() hypercalls while Xen managed to completely fill the
provided buffer.
Also, change the buffer to being static to save on stack space.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Ian Campbell <Ian.Campbell@citrix.com>
CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
tools/console/daemon/io.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/tools/console/daemon/io.c b/tools/console/daemon/io.c
index 313b256..b1268fa 100644
--- a/tools/console/daemon/io.c
+++ b/tools/console/daemon/io.c
@@ -909,17 +909,24 @@ static void handle_xs(void)
static void handle_hv_logs(xc_evtchn *xce_handle)
{
- char buffer[1024*16];
+ static char buffer[1024*16];
char *bufptr = buffer;
- unsigned int size = sizeof(buffer);
+ unsigned int size;
static uint32_t index = 0;
evtchn_port_or_error_t port;
if ((port = xc_evtchn_pending(xce_handle)) == -1)
return;
- if (xc_readconsolering(xc, bufptr, &size, 0, 1, &index) == 0 && size > 0) {
+ do
+ {
int logret;
+
+ size = sizeof(buffer);
+ if (xc_readconsolering(xc, bufptr, &size, 0, 1, &index) != 0 ||
+ size == 0)
+ break;
+
if (log_time_hv)
logret = write_with_timestamp(log_hv_fd, buffer, size,
&log_time_hv_needts);
@@ -929,7 +936,7 @@ static void handle_hv_logs(xc_evtchn *xce_handle)
if (logret < 0)
dolog(LOG_ERR, "Failed to write hypervisor log: "
"%d (%s)", errno, strerror(errno));
- }
+ } while (size == sizeof(buffer));
(void)xc_evtchn_unmask(xce_handle, port);
}
--
1.7.10.4
next prev parent reply other threads:[~2014-07-22 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 16:17 [PATCH 0/3] Improvements for xenconsoled Andrew Cooper
2014-07-22 16:17 ` [PATCH 1/3] tools/xenconsoled: Newline on 'Logfile Opened' messages Andrew Cooper
2014-07-22 16:17 ` Andrew Cooper [this message]
2014-07-22 16:17 ` [PATCH 3/3] tools/xenconsoled: Log Xen boot messages at startup Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406045836-9955-3-git-send-email-andrew.cooper3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).