From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>
Subject: [PATCH 3/3] tools/xenconsoled: Log Xen boot messages at startup.
Date: Tue, 22 Jul 2014 17:17:16 +0100 [thread overview]
Message-ID: <1406045836-9955-4-git-send-email-andrew.cooper3@citrix.com> (raw)
In-Reply-To: <1406045836-9955-1-git-send-email-andrew.cooper3@citrix.com>
When xenconsoled starts, there will be log lines in the Xen console ring from
boot, even though VIRQ_CON_RING is not yet pending.
Add a force option to handle_hv_logs() which bypasses the event channel check,
allowing xenconsoled to drain the Xen boot messages when it starts, rather
than at the first subsequent time that VIRQ_CON_RING becomes set.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Ian Campbell <Ian.Campbell@citrix.com>
CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
tools/console/daemon/io.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/tools/console/daemon/io.c b/tools/console/daemon/io.c
index b1268fa..ac08b5b 100644
--- a/tools/console/daemon/io.c
+++ b/tools/console/daemon/io.c
@@ -907,15 +907,15 @@ static void handle_xs(void)
free(vec);
}
-static void handle_hv_logs(xc_evtchn *xce_handle)
+static void handle_hv_logs(xc_evtchn *xce_handle, bool force)
{
static char buffer[1024*16];
char *bufptr = buffer;
unsigned int size;
static uint32_t index = 0;
- evtchn_port_or_error_t port;
+ evtchn_port_or_error_t port = -1;
- if ((port = xc_evtchn_pending(xce_handle)) == -1)
+ if (!force && ((port = xc_evtchn_pending(xce_handle)) == -1))
return;
do
@@ -938,7 +938,8 @@ static void handle_hv_logs(xc_evtchn *xce_handle)
"%d (%s)", errno, strerror(errno));
} while (size == sizeof(buffer));
- (void)xc_evtchn_unmask(xce_handle, port);
+ if (port != -1)
+ (void)xc_evtchn_unmask(xce_handle, port);
}
static void handle_log_reload(void)
@@ -1024,6 +1025,8 @@ void handle_io(void)
"%d (%s)", errno, strerror(errno));
goto out;
}
+ /* Log the boot dmesg even if VIRQ_CON_RING isn't pending. */
+ handle_hv_logs(xce_handle, true);
}
xcg_handle = xc_gnttab_open(NULL, 0);
@@ -1134,7 +1137,7 @@ void handle_io(void)
errno, strerror(errno));
break;
} else if (fds[xce_pollfd_idx].revents & POLLIN)
- handle_hv_logs(xce_handle);
+ handle_hv_logs(xce_handle, false);
xce_pollfd_idx = -1;
}
--
1.7.10.4
prev parent reply other threads:[~2014-07-22 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 16:17 [PATCH 0/3] Improvements for xenconsoled Andrew Cooper
2014-07-22 16:17 ` [PATCH 1/3] tools/xenconsoled: Newline on 'Logfile Opened' messages Andrew Cooper
2014-07-22 16:17 ` [PATCH 2/3] tools/xenconsoled: Possibly perform repeated xc_readconsolering() hypercalls Andrew Cooper
2014-07-22 16:17 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406045836-9955-4-git-send-email-andrew.cooper3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).