From: Tiejun Chen <tiejun.chen@intel.com>
To: yang.z.zhang@intel.com, kevin.tian@intel.com
Cc: xen-devel@lists.xen.org
Subject: [PATCH 1/1] xen:vtd: missing RMRR mapping while share EPT
Date: Wed, 23 Jul 2014 17:35:03 +0800 [thread overview]
Message-ID: <1406108103-11981-1-git-send-email-tiejun.chen@intel.com> (raw)
intel_iommu_map_page() does nothing if VT-d shares EPT page table.
So rmrr_identity_mapping() never create RMRR mapping but in some
cases like some GFX drivers it still need to access RMRR.
Here we will create those RMRR mappings even in shared EPT case.
Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
---
xen/drivers/passthrough/vtd/iommu.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c
index 042b882..be9384d 100644
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -41,6 +41,7 @@
#include "extern.h"
#include "vtd.h"
#include "../ats.h"
+#include "../../../arch/x86/mm/mm-locks.h"
struct mapped_rmrr {
struct list_head list;
@@ -1842,6 +1843,7 @@ static int rmrr_identity_mapping(struct domain *d,
unsigned long base_pfn, end_pfn;
struct mapped_rmrr *mrmrr;
struct hvm_iommu *hd = domain_hvm_iommu(d);
+ struct p2m_domain *p2m = p2m_get_hostp2m(d);
ASSERT(spin_is_locked(&pcidevs_lock));
ASSERT(rmrr->base_address < rmrr->end_address);
@@ -1867,7 +1869,19 @@ static int rmrr_identity_mapping(struct domain *d,
while ( base_pfn < end_pfn )
{
- if ( intel_iommu_map_page(d, base_pfn, base_pfn,
+ if ( iommu_use_hap_pt(d) ) {
+ dprintk(XENLOG_DEBUG VTDPREFIX,
+ "Set RMRR mapping: pfn:0x%lx mfn:0x%lx.\n",
+ base_pfn, mfn_x(_mfn(base_pfn)));
+ p2m_lock(p2m);
+ if ( p2m_set_entry(p2m, base_pfn, _mfn(base_pfn), PAGE_ORDER_4K,
+ p2m_mmio_direct, p2m_access_rw) ) {
+ p2m_unlock(p2m);
+ return -1;
+ }
+ p2m_unlock(p2m);
+ }
+ else if ( intel_iommu_map_page(d, base_pfn, base_pfn,
IOMMUF_readable|IOMMUF_writable) )
return -1;
base_pfn++;
--
1.9.1
next reply other threads:[~2014-07-23 9:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 9:35 Tiejun Chen [this message]
2014-07-23 15:42 ` [PATCH 1/1] xen:vtd: missing RMRR mapping while share EPT Jan Beulich
2014-07-24 1:23 ` Chen, Tiejun
2014-07-24 6:14 ` Jan Beulich
2014-07-24 7:00 ` Chen, Tiejun
2014-07-24 7:15 ` Chen, Tiejun
2014-07-24 7:47 ` Jan Beulich
2014-07-24 7:45 ` Jan Beulich
2014-07-24 8:28 ` Chen, Tiejun
2014-07-24 9:41 ` Jan Beulich
2014-07-24 9:56 ` Chen, Tiejun
2014-07-24 10:11 ` Jan Beulich
2014-07-24 10:42 ` Chen, Tiejun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406108103-11981-1-git-send-email-tiejun.chen@intel.com \
--to=tiejun.chen@intel.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xen.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).