Re: [Patch v6 02/13] tools/python: Scripts relating to migrationv2 streams

[Ian Campbell <Ian.Campbell@citrix.com>]

On Mon, 2014-07-28 at 16:38 +0100, Andrew Cooper wrote:
> > Have you developed any particular unit tests for the conversion stuff as
> > you've been developing this? I think we could check them in if yes, so
> > long as the input dataset isn't an entire domain of course...
> 
> andrewcoop@andrewcoop:/local/xen.git$ ls -hlA tools/python/v2tests/
> total 285M
> -rw-rw-r-- 1 andrewcoop xendev  65M Jul 11 11:35 conv-v1-t64-hvm
> -rw-rw-r-- 1 andrewcoop xendev  40M Jul 11 11:35 conv-v1-t64-pv32
> -rw-rw-r-- 1 andrewcoop xendev  40M Jul 11 11:35 conv-v1-t64-pv64
> -rw-rw-r-- 1 andrewcoop xendev 1.1K Jul  6 20:06 Makefile
> -rw-r--r-- 1 andrewcoop xendev  65M May  6 14:09 v1-t64-hvm
> -rw-r--r-- 1 andrewcoop xendev  40M May  6 14:05 v1-t64-pv32
> -rw-r--r-- 1 andrewcoop xendev  40M May  6 14:04 v1-t64-pv64
> 
> They are the smallest domains I could create and suspend, but are still
> too large to reasonably be committed

Agreed.

> I will see if I can come up with something smaller which can be
> committed, but nothing comes immediately to mind.

Perhaps a minios domain for the pv cases at least?

For HVM perhaps a tiny domain sat at its bootloader prompt?

> 
> >
> >> +        elif marker == -1: # XC_SAVE_ID_ENABLE_VERIFY_MODE
> > You could define names for all these.
> 
> I considered that, but they are used exactly once, and commented in
> place.  I decided that, on balance, it was better without.

OK.

Ian.